From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org,
Jayachandran Nair <Jayachandran.Nair@cavium.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
Robert Richter <Robert.Richter@cavium.com>,
Tom Vaden <tom.vaden@hpe.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
George Cherian <george.cherian@cavium.com>
Subject: Re: [PATCH v1 1/2] PCI: Probe for device reset support before driver claim
Date: Mon, 19 Feb 2018 13:59:38 +0100 [thread overview]
Message-ID: <9067468.WjanRiEMkP@aspire.rjw.lan> (raw)
In-Reply-To: <20180216225010.67295.92539.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Friday, February 16, 2018 11:50:11 PM CET Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Previously we called pci_probe_reset_function() in this path:
>
> pci_sysfs_init # late_initcall
> for_each_pci_dev(dev)
> pci_create_sysfs_dev_files(dev)
> pci_create_capabilities_sysfs(dev)
> pci_probe_reset_function
> pci_dev_specific_reset
> pcie_has_flr
> pcie_capability_read_dword
>
> pci_sysfs_init() is a late_initcall, and a driver may have already claimed
> one of these devices and enabled runtime power management for it, so the
> device could already be in D3hot by the time we get to pci_sysfs_init().
It also may be in D3cold if, say, AML can cut off power from it or ACPI
power resources can be used for that.
> The device itself should respond to the config read even while it's in
> D3hot, but if an upstream bridge is also in D3hot, the read won't even
> reach the device because the bridge won't forward it downstream to the
> device. If the bridge is a PCIe port, it should complete the read as an
> Unsupported Request, which may be reported to the CPU as an exception or as
> invalid data.
>
> Avoid this case by probing for reset support from pci_init_capabilities(),
> before a driver can claim the device. The device should be in D0 and fully
> accessible at that point.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/pci/pci-sysfs.c | 3 +--
> drivers/pci/probe.c | 3 +++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index eb6bee8724cc..4933f0270471 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -1542,11 +1542,10 @@ static int pci_create_capabilities_sysfs(struct pci_dev *dev)
> /* Active State Power Management */
> pcie_aspm_create_sysfs_dev_files(dev);
>
> - if (!pci_probe_reset_function(dev)) {
> + if (dev->reset_fn) {
> retval = device_create_file(&dev->dev, &reset_attr);
> if (retval)
> goto error;
> - dev->reset_fn = 1;
> }
> return 0;
>
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index ef5377438a1e..489660d0d384 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -2121,6 +2121,9 @@ static void pci_init_capabilities(struct pci_dev *dev)
>
> /* Advanced Error Reporting */
> pci_aer_init(dev);
> +
> + if (pci_probe_reset_function(dev) == 0)
> + dev->reset_fn = 1;
> }
>
> /*
>
>
next prev parent reply other threads:[~2018-02-19 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 22:50 [PATCH v1 0/2] PCI: Probe for reset support earlier Bjorn Helgaas
2018-02-16 22:50 ` [PATCH v1 1/2] PCI: Probe for device reset support before driver claim Bjorn Helgaas
2018-02-19 12:59 ` Rafael J. Wysocki [this message]
2018-02-16 22:50 ` [PATCH v1 2/2] PCI: Remove redundant probes for device reset support Bjorn Helgaas
2018-02-19 13:00 ` Rafael J. Wysocki
2018-02-19 20:43 ` [PATCH v1 0/2] PCI: Probe for reset support earlier Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9067468.WjanRiEMkP@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=Jayachandran.Nair@cavium.com \
--cc=Robert.Richter@cavium.com \
--cc=alex.williamson@redhat.com \
--cc=george.cherian@cavium.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=tom.vaden@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).