From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-pci@vger.kernel.org
Cc: Jayachandran Nair <Jayachandran.Nair@cavium.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
Robert Richter <Robert.Richter@cavium.com>,
Tom Vaden <tom.vaden@hpe.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
George Cherian <george.cherian@cavium.com>
Subject: Re: [PATCH v1 0/2] PCI: Probe for reset support earlier
Date: Mon, 19 Feb 2018 14:43:31 -0600 [thread overview]
Message-ID: <20180219204331.GB48133@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20180216224213.67295.2251.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Fri, Feb 16, 2018 at 04:50:03PM -0600, Bjorn Helgaas wrote:
> The PCI core currently uses a late_initcall to probe each device for
> whether it supports reset. This is dangerous because a driver may have
> already claimed the device by this point, and the PCI core should not
> interfere with the driver by touching the device on its own.
>
> These patches move the probe to be earlier, during enumeration, before a
> driver has a chance to claim the device.
>
> ---
>
> Bjorn Helgaas (2):
> PCI: Probe for device reset support before driver claim
> PCI: Remove redundant probes for device reset support
>
>
> drivers/pci/pci-sysfs.c | 3 +--
> drivers/pci/pci.c | 15 ++++++---------
> drivers/pci/probe.c | 3 +++
> 3 files changed, 10 insertions(+), 11 deletions(-)
Applied both to pci/virtualization with Rafael's reviewed-by (and
update to comment to s/D3hot/D3/) for v4.17.
prev parent reply other threads:[~2018-02-19 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 22:50 [PATCH v1 0/2] PCI: Probe for reset support earlier Bjorn Helgaas
2018-02-16 22:50 ` [PATCH v1 1/2] PCI: Probe for device reset support before driver claim Bjorn Helgaas
2018-02-19 12:59 ` Rafael J. Wysocki
2018-02-16 22:50 ` [PATCH v1 2/2] PCI: Remove redundant probes for device reset support Bjorn Helgaas
2018-02-19 13:00 ` Rafael J. Wysocki
2018-02-19 20:43 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219204331.GB48133@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=Jayachandran.Nair@cavium.com \
--cc=Robert.Richter@cavium.com \
--cc=alex.williamson@redhat.com \
--cc=george.cherian@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=tom.vaden@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).