linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [BISECTED] Suspend / USB broken on XPS 9370 + TB16
@ 2019-10-07  7:21 Carlo Caione
  2019-10-07  8:13 ` Mathias Nyman
  0 siblings, 1 reply; 3+ messages in thread
From: Carlo Caione @ 2019-10-07  7:21 UTC (permalink / raw)
  To: linux-kernel
  Cc: andrew.smirnov, rrangel, mathias.nyman, gregkh, kamal, khalid.elmously

Hi,
I bisected an issue down to commit f7fac17ca925 "xhci: Convert 
xhci_handshake() to use readl_poll_timeout_atomic()".

Setup:
XPS 9370 + Thunderbolt dock Dell TB16

Issue:
The laptop is unable to go to sleep. It never really goes to sleep and 
after a few seconds the USB dies.

Log:
https://termbin.com/icix

Cheers!

-- 
Carlo Caione

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BISECTED] Suspend / USB broken on XPS 9370 + TB16
  2019-10-07  7:21 [BISECTED] Suspend / USB broken on XPS 9370 + TB16 Carlo Caione
@ 2019-10-07  8:13 ` Mathias Nyman
  2019-10-07  8:28   ` Carlo Caione
  0 siblings, 1 reply; 3+ messages in thread
From: Mathias Nyman @ 2019-10-07  8:13 UTC (permalink / raw)
  To: Carlo Caione, linux-kernel
  Cc: andrew.smirnov, rrangel, gregkh, kamal, khalid.elmously

On 7.10.2019 10.21, Carlo Caione wrote:
> Hi,
> I bisected an issue down to commit f7fac17ca925 "xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic()".
> 
> Setup:
> XPS 9370 + Thunderbolt dock Dell TB16
> 
> Issue:
> The laptop is unable to go to sleep. It never really goes to sleep and after a few seconds the USB dies.
> 
> Log:
> https://termbin.com/icix
> 
> Cheers!
> 

Does the below patch help?  Greg just applied it to his usb-linus branch.

ac343366846a xhci: Increase STS_SAVE timeout in xhci_suspend()
Link: https://lore.kernel.org/r/1570190373-30684-8-git-send-email-mathias.nyman@linux.intel.com

-Mathias

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BISECTED] Suspend / USB broken on XPS 9370 + TB16
  2019-10-07  8:13 ` Mathias Nyman
@ 2019-10-07  8:28   ` Carlo Caione
  0 siblings, 0 replies; 3+ messages in thread
From: Carlo Caione @ 2019-10-07  8:28 UTC (permalink / raw)
  To: Mathias Nyman
  Cc: linux-kernel, andrew.smirnov, rrangel, gregkh, kamal, khalid.elmously

On 07/10/2019 09:13, Mathias Nyman wrote:

/cut
> Does the below patch help?  Greg just applied it to his usb-linus branch.
> 
> ac343366846a xhci: Increase STS_SAVE timeout in xhci_suspend()
> Link: 
> https://lore.kernel.org/r/1570190373-30684-8-git-send-email-mathias.nyman@linux.intel.com 

Yes. That patch fixes the issue.

Thank you,

--
Carlo Caione

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-07  8:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-07  7:21 [BISECTED] Suspend / USB broken on XPS 9370 + TB16 Carlo Caione
2019-10-07  8:13 ` Mathias Nyman
2019-10-07  8:28   ` Carlo Caione

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).