From: Kari Argillander <kari.argillander@gmail.com>
To: Colin Ian King <colin.i.king@gmail.com>,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
ntfs3@lists.linux.dev
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] fs/ntfs3: remove redundant assignment to variable vcn
Date: Wed, 20 Apr 2022 20:40:08 +0300 [thread overview]
Message-ID: <90e11a93-4f3a-2209-2bc2-acfb791b8ac0@gmail.com> (raw)
In-Reply-To: <20220418140038.82843-1-colin.i.king@gmail.com>
On 18.4.2022 17.00, Colin Ian King wrote:
> Variable vcn is being assigned a value that is never read, it is
> being re-assigned again in the initialization of a for-loop. The
> assignment is redundant and can be removed.
>
> Cleans up clang scan build warning:
> fs/ntfs3/attrib.c:1176:7: warning: Value stored to 'vcn' during its
> initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Kari Argillander <kari.argillander@gmail.com>
> ---
> fs/ntfs3/attrib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c
> index e8c00dda42ad..fc0623b029e6 100644
> --- a/fs/ntfs3/attrib.c
> +++ b/fs/ntfs3/attrib.c
> @@ -1173,7 +1173,7 @@ int attr_load_runs_range(struct ntfs_inode *ni, enum ATTR_TYPE type,
> {
> struct ntfs_sb_info *sbi = ni->mi.sbi;
> u8 cluster_bits = sbi->cluster_bits;
> - CLST vcn = from >> cluster_bits;
> + CLST vcn;
> CLST vcn_last = (to - 1) >> cluster_bits;
> CLST lcn, clen;
> int err;
next prev parent reply other threads:[~2022-04-20 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 14:00 [PATCH] fs/ntfs3: remove redundant assignment to variable vcn Colin Ian King
2022-04-20 17:40 ` Kari Argillander [this message]
2022-06-08 15:28 ` Konstantin Komarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90e11a93-4f3a-2209-2bc2-acfb791b8ac0@gmail.com \
--to=kari.argillander@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).