* [PATCH] fs/ntfs3: remove redundant assignment to variable vcn
@ 2022-04-18 14:00 Colin Ian King
2022-04-20 17:40 ` Kari Argillander
2022-06-08 15:28 ` Konstantin Komarov
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-04-18 14:00 UTC (permalink / raw)
To: Konstantin Komarov, ntfs3; +Cc: kernel-janitors, linux-kernel, llvm
Variable vcn is being assigned a value that is never read, it is
being re-assigned again in the initialization of a for-loop. The
assignment is redundant and can be removed.
Cleans up clang scan build warning:
fs/ntfs3/attrib.c:1176:7: warning: Value stored to 'vcn' during its
initialization is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/ntfs3/attrib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c
index e8c00dda42ad..fc0623b029e6 100644
--- a/fs/ntfs3/attrib.c
+++ b/fs/ntfs3/attrib.c
@@ -1173,7 +1173,7 @@ int attr_load_runs_range(struct ntfs_inode *ni, enum ATTR_TYPE type,
{
struct ntfs_sb_info *sbi = ni->mi.sbi;
u8 cluster_bits = sbi->cluster_bits;
- CLST vcn = from >> cluster_bits;
+ CLST vcn;
CLST vcn_last = (to - 1) >> cluster_bits;
CLST lcn, clen;
int err;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/ntfs3: remove redundant assignment to variable vcn
2022-04-18 14:00 [PATCH] fs/ntfs3: remove redundant assignment to variable vcn Colin Ian King
@ 2022-04-20 17:40 ` Kari Argillander
2022-06-08 15:28 ` Konstantin Komarov
1 sibling, 0 replies; 3+ messages in thread
From: Kari Argillander @ 2022-04-20 17:40 UTC (permalink / raw)
To: Colin Ian King, Konstantin Komarov, ntfs3
Cc: kernel-janitors, linux-kernel, llvm
On 18.4.2022 17.00, Colin Ian King wrote:
> Variable vcn is being assigned a value that is never read, it is
> being re-assigned again in the initialization of a for-loop. The
> assignment is redundant and can be removed.
>
> Cleans up clang scan build warning:
> fs/ntfs3/attrib.c:1176:7: warning: Value stored to 'vcn' during its
> initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Kari Argillander <kari.argillander@gmail.com>
> ---
> fs/ntfs3/attrib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c
> index e8c00dda42ad..fc0623b029e6 100644
> --- a/fs/ntfs3/attrib.c
> +++ b/fs/ntfs3/attrib.c
> @@ -1173,7 +1173,7 @@ int attr_load_runs_range(struct ntfs_inode *ni, enum ATTR_TYPE type,
> {
> struct ntfs_sb_info *sbi = ni->mi.sbi;
> u8 cluster_bits = sbi->cluster_bits;
> - CLST vcn = from >> cluster_bits;
> + CLST vcn;
> CLST vcn_last = (to - 1) >> cluster_bits;
> CLST lcn, clen;
> int err;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/ntfs3: remove redundant assignment to variable vcn
2022-04-18 14:00 [PATCH] fs/ntfs3: remove redundant assignment to variable vcn Colin Ian King
2022-04-20 17:40 ` Kari Argillander
@ 2022-06-08 15:28 ` Konstantin Komarov
1 sibling, 0 replies; 3+ messages in thread
From: Konstantin Komarov @ 2022-06-08 15:28 UTC (permalink / raw)
To: Colin Ian King, ntfs3; +Cc: kernel-janitors, linux-kernel, llvm
On 4/18/22 17:00, Colin Ian King wrote:
> Variable vcn is being assigned a value that is never read, it is
> being re-assigned again in the initialization of a for-loop. The
> assignment is redundant and can be removed.
>
> Cleans up clang scan build warning:
> fs/ntfs3/attrib.c:1176:7: warning: Value stored to 'vcn' during its
> initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> fs/ntfs3/attrib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c
> index e8c00dda42ad..fc0623b029e6 100644
> --- a/fs/ntfs3/attrib.c
> +++ b/fs/ntfs3/attrib.c
> @@ -1173,7 +1173,7 @@ int attr_load_runs_range(struct ntfs_inode *ni, enum ATTR_TYPE type,
> {
> struct ntfs_sb_info *sbi = ni->mi.sbi;
> u8 cluster_bits = sbi->cluster_bits;
> - CLST vcn = from >> cluster_bits;
> + CLST vcn;
> CLST vcn_last = (to - 1) >> cluster_bits;
> CLST lcn, clen;
> int err;
Thanks for patch, applied!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-08 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-18 14:00 [PATCH] fs/ntfs3: remove redundant assignment to variable vcn Colin Ian King
2022-04-20 17:40 ` Kari Argillander
2022-06-08 15:28 ` Konstantin Komarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).