* [PATCH v2] ubifs: Remove unreachable code in dbg_check_ltab_lnum
@ 2024-01-11 6:36 Kunwu Chan
2024-01-11 12:30 ` Zhihao Cheng
0 siblings, 1 reply; 2+ messages in thread
From: Kunwu Chan @ 2024-01-11 6:36 UTC (permalink / raw)
To: richard, Artem.Bityutskiy
Cc: linux-mtd, linux-kernel, Kunwu Chan, Kunwu Chan, Richard Weinberger
Because there is no break statement in the dead loop above,it is
impossible to execute the 'err=0' statement.Delete the code that
will never execute.
Fixes: 6fb324a4b0c3 ("UBIFS: allocate ltab checking buffer on demand")
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Cc: Kunwu Chan <kunwu.chan@hotmail.com>
Suggested-by: Richard Weinberger <richard.weinberger@gmail.com>
---
v2: Remove the initialization of err
---
fs/ubifs/lpt_commit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ubifs/lpt_commit.c b/fs/ubifs/lpt_commit.c
index c4d079328b92..07351fdce722 100644
--- a/fs/ubifs/lpt_commit.c
+++ b/fs/ubifs/lpt_commit.c
@@ -1646,7 +1646,6 @@ static int dbg_check_ltab_lnum(struct ubifs_info *c, int lnum)
len -= node_len;
}
- err = 0;
out:
vfree(buf);
return err;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ubifs: Remove unreachable code in dbg_check_ltab_lnum
2024-01-11 6:36 [PATCH v2] ubifs: Remove unreachable code in dbg_check_ltab_lnum Kunwu Chan
@ 2024-01-11 12:30 ` Zhihao Cheng
0 siblings, 0 replies; 2+ messages in thread
From: Zhihao Cheng @ 2024-01-11 12:30 UTC (permalink / raw)
To: Kunwu Chan, richard, Artem.Bityutskiy
Cc: linux-mtd, linux-kernel, Kunwu Chan, Richard Weinberger
在 2024/1/11 14:36, Kunwu Chan 写道:
> Because there is no break statement in the dead loop above,it is
> impossible to execute the 'err=0' statement.Delete the code that
> will never execute.
>
> Fixes: 6fb324a4b0c3 ("UBIFS: allocate ltab checking buffer on demand")
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> Cc: Kunwu Chan <kunwu.chan@hotmail.com>
> Suggested-by: Richard Weinberger <richard.weinberger@gmail.com>
>
> ---
> v2: Remove the initialization of err
> ---
> fs/ubifs/lpt_commit.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
>
> diff --git a/fs/ubifs/lpt_commit.c b/fs/ubifs/lpt_commit.c
> index c4d079328b92..07351fdce722 100644
> --- a/fs/ubifs/lpt_commit.c
> +++ b/fs/ubifs/lpt_commit.c
> @@ -1646,7 +1646,6 @@ static int dbg_check_ltab_lnum(struct ubifs_info *c, int lnum)
> len -= node_len;
> }
>
> - err = 0;
> out:
> vfree(buf);
> return err;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-11 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-11 6:36 [PATCH v2] ubifs: Remove unreachable code in dbg_check_ltab_lnum Kunwu Chan
2024-01-11 12:30 ` Zhihao Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).