From: Florian Fainelli <f.fainelli@gmail.com>
To: Lipeng <lipeng321@huawei.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, salil.mehta@huawei.com
Subject: Re: [PATCH net-next 4/6] net: hns3: add support for set_link_ksettings
Date: Fri, 3 Nov 2017 12:52:10 -0700 [thread overview]
Message-ID: <926ca4e8-78af-d442-38c5-bf38141051b5@gmail.com> (raw)
In-Reply-To: <1509682710-94908-5-git-send-email-lipeng321@huawei.com>
On 11/02/2017 09:18 PM, Lipeng wrote:
> From: Fuyun Liang <liangfuyun1@huawei.com>
>
> This patch adds set_link_ksettings support for ethtool cmd.
>
> Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
> Signed-off-by: Lipeng <lipeng321@huawei.com>
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
> index c7b8ebd..7fe193b 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
> @@ -653,6 +653,16 @@ static int hns3_get_link_ksettings(struct net_device *netdev,
> return 0;
> }
>
> +static int hns3_set_link_ksettings(struct net_device *netdev,
> + const struct ethtool_link_ksettings *cmd)
> +{
> + /* Only support ksettings_set for netdev with phy attached for now */
> + if (netdev->phydev)
> + return phy_ethtool_ksettings_set(netdev->phydev, cmd);
> +
> + return -EOPNOTSUPP;
Consider using phy_ethtool_get_link_ksettings() which already checks for
netdev->phydev.
--
Florian
next prev parent reply other threads:[~2017-11-03 19:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 4:18 [PATCH net-next 0/6] net: hns3: support set_link_ksettings and for nway_reset ethtool command Lipeng
2017-11-03 4:18 ` [PATCH net-next 1/6] net: hns3: fix for getting autoneg in hns3_get_link_ksettings Lipeng
2017-11-03 4:18 ` [PATCH net-next 2/6] net: hns3: fix for getting advertised_caps " Lipeng
2017-11-03 4:18 ` [PATCH net-next 3/6] net: hns3: fix a bug in hns3_driv_to_eth_caps Lipeng
2017-11-03 4:18 ` [PATCH net-next 4/6] net: hns3: add support for set_link_ksettings Lipeng
2017-11-03 19:52 ` Florian Fainelli [this message]
2017-11-06 2:28 ` lipeng (Y)
2017-11-03 4:18 ` [PATCH net-next 5/6] net: hns3: add support for nway_reset Lipeng
2017-11-03 19:53 ` Florian Fainelli
2017-11-03 4:18 ` [PATCH net-next 6/6] net: hns3: fix a bug for phy supported feature initialization Lipeng
2017-11-03 12:37 ` [PATCH net-next 0/6] net: hns3: support set_link_ksettings and for nway_reset ethtool command David Miller
2017-11-03 15:51 ` Andrew Lunn
2017-11-03 16:01 ` Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=926ca4e8-78af-d442-38c5-bf38141051b5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).