* [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread
@ 2017-01-03 23:41 Sarangdhar Joshi
2017-01-05 21:08 ` Suman Anna
0 siblings, 1 reply; 5+ messages in thread
From: Sarangdhar Joshi @ 2017-01-03 23:41 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, Santosh Shilimkar
Cc: Sarangdhar Joshi, linux-remoteproc, linux-kernel,
linux-arm-kernel, linux-arm-msm, Stephen Boyd, Trilok Soni,
Dave Gerlach, Suman Anna
The function wkup_m3_rproc_boot_thread waits for
asynchronous firmware loading to parse the resource table
before calling rproc_boot(). However, as the resource table
parsing has been moved to rproc_boot(), there's no need to
wait for the asynchronous firmware loading completion.
So, drop this.
CC: Dave Gerlach <d-gerlach@ti.com>
CC: Suman Anna <s-anna@ti.com>
CC: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
---
This patch seems to be doing an independent clean up now. Hence
removing it from the series.
drivers/soc/ti/wkup_m3_ipc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
index 8823cc8..8bfa44b 100644
--- a/drivers/soc/ti/wkup_m3_ipc.c
+++ b/drivers/soc/ti/wkup_m3_ipc.c
@@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
struct device *dev = m3_ipc->dev;
int ret;
- wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
-
init_completion(&m3_ipc->sync_complete);
ret = rproc_boot(m3_ipc->rproc);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread
2017-01-03 23:41 [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread Sarangdhar Joshi
@ 2017-01-05 21:08 ` Suman Anna
2017-01-05 21:17 ` Santosh Shilimkar
2017-01-05 21:58 ` Sarangdhar Joshi
0 siblings, 2 replies; 5+ messages in thread
From: Suman Anna @ 2017-01-05 21:08 UTC (permalink / raw)
To: Sarangdhar Joshi, Ohad Ben-Cohen, Bjorn Andersson,
Santosh Shilimkar, Tony Lindgren, Santosh Shilimkar
Cc: linux-remoteproc, linux-kernel, linux-arm-kernel, linux-arm-msm,
Stephen Boyd, Trilok Soni, Dave Gerlach
On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote:
> The function wkup_m3_rproc_boot_thread waits for
> asynchronous firmware loading to parse the resource table
> before calling rproc_boot(). However, as the resource table
> parsing has been moved to rproc_boot(), there's no need to
> wait for the asynchronous firmware loading completion.
> So, drop this.
>
> CC: Dave Gerlach <d-gerlach@ti.com>
> CC: Suman Anna <s-anna@ti.com>
> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
+ Tony and Santosh, not sure who is picking up the wkup_m3 related patches.
Only one minor nit, I would prefer the patch subject to start with
soc: ti: wkup_m3_ipc: ....
Tested-by: Suman Anna <s-anna@ti.com>
regards
Suman
> ---
>
> This patch seems to be doing an independent clean up now. Hence
> removing it from the series.
>
> drivers/soc/ti/wkup_m3_ipc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 8823cc8..8bfa44b 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
> struct device *dev = m3_ipc->dev;
> int ret;
>
> - wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
> -
> init_completion(&m3_ipc->sync_complete);
>
> ret = rproc_boot(m3_ipc->rproc);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread
2017-01-05 21:08 ` Suman Anna
@ 2017-01-05 21:17 ` Santosh Shilimkar
2017-01-05 22:03 ` Tony Lindgren
2017-01-05 21:58 ` Sarangdhar Joshi
1 sibling, 1 reply; 5+ messages in thread
From: Santosh Shilimkar @ 2017-01-05 21:17 UTC (permalink / raw)
To: Suman Anna, Sarangdhar Joshi, Ohad Ben-Cohen, Bjorn Andersson,
Santosh Shilimkar, Tony Lindgren
Cc: linux-remoteproc, linux-kernel, linux-arm-kernel, linux-arm-msm,
Stephen Boyd, Trilok Soni, Dave Gerlach
On 1/5/2017 1:08 PM, Suman Anna wrote:
> On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote:
>> The function wkup_m3_rproc_boot_thread waits for
>> asynchronous firmware loading to parse the resource table
>> before calling rproc_boot(). However, as the resource table
>> parsing has been moved to rproc_boot(), there's no need to
>> wait for the asynchronous firmware loading completion.
>> So, drop this.
>>
>> CC: Dave Gerlach <d-gerlach@ti.com>
>> CC: Suman Anna <s-anna@ti.com>
>> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
>
> + Tony and Santosh, not sure who is picking up the wkup_m3 related patches.
>
I think Tony has queued patches for wakeup_m3 before.
Regards,
Snatosh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread
2017-01-05 21:08 ` Suman Anna
2017-01-05 21:17 ` Santosh Shilimkar
@ 2017-01-05 21:58 ` Sarangdhar Joshi
1 sibling, 0 replies; 5+ messages in thread
From: Sarangdhar Joshi @ 2017-01-05 21:58 UTC (permalink / raw)
To: Suman Anna, Ohad Ben-Cohen, Bjorn Andersson, Santosh Shilimkar,
Tony Lindgren
Cc: linux-remoteproc, linux-kernel, linux-arm-kernel, linux-arm-msm,
Stephen Boyd, Trilok Soni, Dave Gerlach
On 01/05/2017 01:08 PM, Suman Anna wrote:
> On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote:
>> The function wkup_m3_rproc_boot_thread waits for
>> asynchronous firmware loading to parse the resource table
>> before calling rproc_boot(). However, as the resource table
>> parsing has been moved to rproc_boot(), there's no need to
>> wait for the asynchronous firmware loading completion.
>> So, drop this.
>>
>> CC: Dave Gerlach <d-gerlach@ti.com>
>> CC: Suman Anna <s-anna@ti.com>
>> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
>
> + Tony and Santosh, not sure who is picking up the wkup_m3 related patches.
>
> Only one minor nit, I would prefer the patch subject to start with
> soc: ti: wkup_m3_ipc: ....
Sure, will update the subject line.
Regards,
Sarang
>
> Tested-by: Suman Anna <s-anna@ti.com>
>
> regards
> Suman
>
>> ---
>>
>> This patch seems to be doing an independent clean up now. Hence
>> removing it from the series.
>>
>> drivers/soc/ti/wkup_m3_ipc.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
>> index 8823cc8..8bfa44b 100644
>> --- a/drivers/soc/ti/wkup_m3_ipc.c
>> +++ b/drivers/soc/ti/wkup_m3_ipc.c
>> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
>> struct device *dev = m3_ipc->dev;
>> int ret;
>>
>> - wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
>> -
>> init_completion(&m3_ipc->sync_complete);
>>
>> ret = rproc_boot(m3_ipc->rproc);
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread
2017-01-05 21:17 ` Santosh Shilimkar
@ 2017-01-05 22:03 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2017-01-05 22:03 UTC (permalink / raw)
To: Santosh Shilimkar
Cc: Suman Anna, Sarangdhar Joshi, Ohad Ben-Cohen, Bjorn Andersson,
Santosh Shilimkar, linux-remoteproc, linux-kernel,
linux-arm-kernel, linux-arm-msm, Stephen Boyd, Trilok Soni,
Dave Gerlach
* Santosh Shilimkar <santosh.shilimkar@oracle.com> [170105 13:18]:
>
>
> On 1/5/2017 1:08 PM, Suman Anna wrote:
> > On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote:
> > > The function wkup_m3_rproc_boot_thread waits for
> > > asynchronous firmware loading to parse the resource table
> > > before calling rproc_boot(). However, as the resource table
> > > parsing has been moved to rproc_boot(), there's no need to
> > > wait for the asynchronous firmware loading completion.
> > > So, drop this.
> > >
> > > CC: Dave Gerlach <d-gerlach@ti.com>
> > > CC: Suman Anna <s-anna@ti.com>
> > > CC: Bjorn Andersson <bjorn.andersson@linaro.org>
> > > Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
> >
> > + Tony and Santosh, not sure who is picking up the wkup_m3 related patches.
> >
> I think Tony has queued patches for wakeup_m3 before.
Sure I can queue it.
Thanks,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-05 22:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-03 23:41 [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread Sarangdhar Joshi
2017-01-05 21:08 ` Suman Anna
2017-01-05 21:17 ` Santosh Shilimkar
2017-01-05 22:03 ` Tony Lindgren
2017-01-05 21:58 ` Sarangdhar Joshi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).