* [PATCH] of: remove unneeded variable
@ 2020-03-30 10:05 Ding Xiang
2020-04-08 16:00 ` Frank Rowand
2020-04-10 17:13 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Ding Xiang @ 2020-03-30 10:05 UTC (permalink / raw)
To: robh+dt, frowand.list; +Cc: devicetree, linux-kernel
rc is unneeded, just return 0.
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
drivers/of/dynamic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
index 08fd823..fe64430 100644
--- a/drivers/of/dynamic.c
+++ b/drivers/of/dynamic.c
@@ -286,7 +286,6 @@ int of_detach_node(struct device_node *np)
{
struct of_reconfig_data rd;
unsigned long flags;
- int rc = 0;
memset(&rd, 0, sizeof(rd));
rd.dn = np;
@@ -301,7 +300,7 @@ int of_detach_node(struct device_node *np)
of_reconfig_notify(OF_RECONFIG_DETACH_NODE, &rd);
- return rc;
+ return 0;
}
EXPORT_SYMBOL_GPL(of_detach_node);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] of: remove unneeded variable
2020-03-30 10:05 [PATCH] of: remove unneeded variable Ding Xiang
@ 2020-04-08 16:00 ` Frank Rowand
2020-04-08 19:27 ` Frank Rowand
2020-04-10 17:13 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Frank Rowand @ 2020-04-08 16:00 UTC (permalink / raw)
To: Ding Xiang, robh+dt; +Cc: devicetree, linux-kernel
On 3/30/20 5:05 AM, Ding Xiang wrote:
> rc is unneeded, just return 0.
of: of_detach_node() remove unneeded local return variable
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
> drivers/of/dynamic.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
> index 08fd823..fe64430 100644
> --- a/drivers/of/dynamic.c
> +++ b/drivers/of/dynamic.c
> @@ -286,7 +286,6 @@ int of_detach_node(struct device_node *np)
> {
> struct of_reconfig_data rd;
> unsigned long flags;
> - int rc = 0;
>
> memset(&rd, 0, sizeof(rd));
> rd.dn = np;
> @@ -301,7 +300,7 @@ int of_detach_node(struct device_node *np)
>
> of_reconfig_notify(OF_RECONFIG_DETACH_NODE, &rd);
>
> - return rc;
> + return 0;
> }
> EXPORT_SYMBOL_GPL(of_detach_node);
>
>
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] of: remove unneeded variable
2020-04-08 16:00 ` Frank Rowand
@ 2020-04-08 19:27 ` Frank Rowand
0 siblings, 0 replies; 4+ messages in thread
From: Frank Rowand @ 2020-04-08 19:27 UTC (permalink / raw)
To: Ding Xiang, robh+dt; +Cc: devicetree, linux-kernel
On 4/8/20 11:00 AM, Frank Rowand wrote:
> On 3/30/20 5:05 AM, Ding Xiang wrote:
>> rc is unneeded, just return 0.
>
> of: of_detach_node() remove unneeded local return variable
never mind, this is not the subject line... My mistake.
-Frank
>
>>
>> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
>> ---
>> drivers/of/dynamic.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
>> index 08fd823..fe64430 100644
>> --- a/drivers/of/dynamic.c
>> +++ b/drivers/of/dynamic.c
>> @@ -286,7 +286,6 @@ int of_detach_node(struct device_node *np)
>> {
>> struct of_reconfig_data rd;
>> unsigned long flags;
>> - int rc = 0;
>>
>> memset(&rd, 0, sizeof(rd));
>> rd.dn = np;
>> @@ -301,7 +300,7 @@ int of_detach_node(struct device_node *np)
>>
>> of_reconfig_notify(OF_RECONFIG_DETACH_NODE, &rd);
>>
>> - return rc;
>> + return 0;
>> }
>> EXPORT_SYMBOL_GPL(of_detach_node);
>>
>>
>
>
> Reviewed-by: Frank Rowand <frank.rowand@sony.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] of: remove unneeded variable
2020-03-30 10:05 [PATCH] of: remove unneeded variable Ding Xiang
2020-04-08 16:00 ` Frank Rowand
@ 2020-04-10 17:13 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-04-10 17:13 UTC (permalink / raw)
To: Ding Xiang; +Cc: robh+dt, frowand.list, devicetree, linux-kernel
On Mon, 30 Mar 2020 18:05:02 +0800, Ding Xiang wrote:
> rc is unneeded, just return 0.
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
> drivers/of/dynamic.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-10 17:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 10:05 [PATCH] of: remove unneeded variable Ding Xiang
2020-04-08 16:00 ` Frank Rowand
2020-04-08 19:27 ` Frank Rowand
2020-04-10 17:13 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).