From: "Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr>
To: Deepa Dinamani <deepa.kernel@gmail.com>, linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Michal Marek <mmarek@suse.com>
Subject: Re: [PATCH] coccicheck: Allow for overriding spatch flags
Date: Sun, 12 Jun 2016 23:38:08 +0200 [thread overview]
Message-ID: <92dd8f8e-7ee1-42df-66c9-95d8cca7210f@imag.fr> (raw)
In-Reply-To: <1465758279-16111-1-git-send-email-deepa.kernel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]
Le 12/06/16 à 21:04, Deepa Dinamani a écrit :
> Documentation/coccinelle.txt suggests using the SPFLAGS
> make variable to pass additional options to spatch.
>
> Reorder the way SPFLAGS is added to FLAGS, to allow
> for options in the SPFLAGS to override the default
> --very-quiet option.
>
> Similarly, rearrage the FLAGS for org or report mode.
> This allows for overriding of the default --no-show-diff
> option through SPFLAGS.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Cc: Julia Lawall <Julia.Lawall@lip6.fr>
> Cc: Gilles Muller <Gilles.Muller@lip6.fr>
> Cc: Nicolas Palix <nicolas.palix@imag.fr>
Acked-By: Nicolas Palix <nicolas.palix@imag.fr>
> Cc: Michal Marek <mmarek@suse.com>
> ---
> scripts/coccicheck | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index dd85a45..f662786 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -25,7 +25,7 @@ else
> NPROC="$J"
> fi
>
> -FLAGS="$SPFLAGS --very-quiet"
> +FLAGS="--very-quiet $SPFLAGS"
>
> # spatch only allows include directories with the syntax "-I include"
> # while gcc also allows "-Iinclude" and "-include include"
> @@ -72,7 +72,7 @@ if [ "$MODE" = "chain" ] ; then
> echo 'All available modes will be tried (in that order): patch, report, context, org'
> fi
> elif [ "$MODE" = "report" -o "$MODE" = "org" ] ; then
> - FLAGS="$FLAGS --no-show-diff"
> + FLAGS="--no-show-diff $FLAGS"
> fi
>
> if [ "$ONLINE" = "0" ] ; then
>
--
Nicolas Palix
http://lig-membres.imag.fr/palix/
[-- Attachment #2: Signature cryptographique S/MIME --]
[-- Type: application/pkcs7-signature, Size: 2959 bytes --]
next prev parent reply other threads:[~2016-06-12 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 19:04 [PATCH] coccicheck: Allow for overriding spatch flags Deepa Dinamani
2016-06-12 19:16 ` Julia Lawall
2016-06-12 20:32 ` Deepa Dinamani
2016-06-12 20:39 ` Julia Lawall
2016-06-12 21:08 ` Deepa Dinamani
2016-06-12 21:09 ` Julia Lawall
2016-06-12 21:38 ` Nicolas Palix (LIG) [this message]
2016-06-12 21:45 ` Julia Lawall
2016-06-20 20:21 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92dd8f8e-7ee1-42df-66c9-95d8cca7210f@imag.fr \
--to=nicolas.palix@imag.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).