linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Deepa Dinamani <deepa.kernel@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Michal Marek <mmarek@suse.com>
Subject: Re: [PATCH] coccicheck: Allow for overriding spatch flags
Date: Sun, 12 Jun 2016 14:08:00 -0700	[thread overview]
Message-ID: <CABeXuvqGvS-LFvpDxhD6_aOoPm1G+aqmWqH3Vtv-FjTbB=J+jQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1606122237540.2180@localhost6.localdomain6>

>> >> Documentation/coccinelle.txt suggests using the SPFLAGS
>> >> make variable to pass additional options to spatch.
>> >>
>> >> Reorder the way SPFLAGS is added to FLAGS, to allow
>> >> for options in the SPFLAGS to override the default
>> >> --very-quiet option.
>> >>
>> >> Similarly, rearrage the FLAGS for org or report mode.
>> >> This allows for overriding of the default --no-show-diff
>> >> option through SPFLAGS.
>> >
>> > The first looks like a good idea, but do you find a use case for the
>> > second?  The diff that is shown in org or report mode may be sort of
>> > random.  It is just an easy hack to reuse the same pattern code for
>> > context, org, and report modes, but there isn't an intent to see the diff
>> > produced by context mode in org or report mode.
>>
>> I thought this at first, that org report mode wouldn't need it the diff.
>> But if a user wishes to override the option, then why should we not
>> accept that the user knows what they are doing?
>
> I guess... Another issue is that the org/report mode output comes from
> python, and the diff output comes from ocaml.  They are not synchronized.
> Ie, the report won't come out next to the relevant diff.

Ok. I was just thinking of user as the final authority because I was
trying to get more
debug output for my script. And, yes I only wanted to override the --very-quiet.
I just thought since --no-show-diff was a similar issue, it would be
good to do the
same thing here.

Let me know if you want me to leave out the second rearrange and submit a v2.

-Deepa

  reply	other threads:[~2016-06-12 21:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-12 19:04 [PATCH] coccicheck: Allow for overriding spatch flags Deepa Dinamani
2016-06-12 19:16 ` Julia Lawall
2016-06-12 20:32   ` Deepa Dinamani
2016-06-12 20:39     ` Julia Lawall
2016-06-12 21:08       ` Deepa Dinamani [this message]
2016-06-12 21:09         ` Julia Lawall
2016-06-12 21:38 ` Nicolas Palix (LIG)
2016-06-12 21:45   ` Julia Lawall
2016-06-20 20:21     ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABeXuvqGvS-LFvpDxhD6_aOoPm1G+aqmWqH3Vtv-FjTbB=J+jQ@mail.gmail.com' \
    --to=deepa.kernel@gmail.com \
    --cc=Gilles.Muller@lip6.fr \
    --cc=arnd@arndb.de \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=nicolas.palix@imag.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).