From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: YueHaibing <yuehaibing@huawei.com>,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
daniel.baluta@nxp.com, krzk@kernel.org
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH -next] ASoC: SOF: imx8: Fix randbuild error
Date: Mon, 10 Feb 2020 15:00:59 -0600 [thread overview]
Message-ID: <9351a746-8823-ee26-70da-fd3127a02c91@linux.intel.com> (raw)
In-Reply-To: <20200210061544.7600-1-yuehaibing@huawei.com>
On 2/10/20 12:15 AM, YueHaibing wrote:
> when do randconfig like this:
> CONFIG_SND_SOC_SOF_IMX8_SUPPORT=y
> CONFIG_SND_SOC_SOF_IMX8=y
> CONFIG_SND_SOC_SOF_OF=y
> CONFIG_IMX_DSP=m
> CONFIG_IMX_SCU=y
>
> there is a link error:
>
> sound/soc/sof/imx/imx8.o: In function 'imx8_send_msg':
> imx8.c:(.text+0x380): undefined reference to 'imx_dsp_ring_doorbell'
>
> Select IMX_DSP in SND_SOC_SOF_IMX8_SUPPORT to fix this
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: f9ad75468453 ("ASoC: SOF: imx: fix reverse CONFIG_SND_SOC_SOF_OF dependency")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for the report.
Would you mind sharing the .config and instructions to reproduce this
case? we have an unrelated issue with allyesconfig that was reviewed here:
https://github.com/thesofproject/linux/pull/1778
and I'd probably a good thing to fix everything in one shot.
Thanks!
> ---
> sound/soc/sof/imx/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig
> index bae4f7b..81274906 100644
> --- a/sound/soc/sof/imx/Kconfig
> +++ b/sound/soc/sof/imx/Kconfig
> @@ -14,7 +14,7 @@ if SND_SOC_SOF_IMX_TOPLEVEL
> config SND_SOC_SOF_IMX8_SUPPORT
> bool "SOF support for i.MX8"
> depends on IMX_SCU
> - depends on IMX_DSP
> + select IMX_DSP
> help
> This adds support for Sound Open Firmware for NXP i.MX8 platforms
> Say Y if you have such a device.
>
next prev parent reply other threads:[~2020-02-10 21:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 6:15 YueHaibing
2020-02-10 21:00 ` Pierre-Louis Bossart [this message]
2020-02-11 1:39 ` [alsa-devel] " Yuehaibing
2020-02-11 9:46 ` Daniel Baluta
2020-02-11 9:59 ` Krzysztof Kozlowski
2020-02-12 9:55 ` Daniel Baluta
2020-02-13 21:09 ` Daniel Baluta
2020-02-14 7:42 ` Krzysztof Kozlowski
2020-02-13 21:12 ` Daniel Baluta
2020-02-14 7:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9351a746-8823-ee26-70da-fd3127a02c91@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tiwai@suse.com \
--cc=yuehaibing@huawei.com \
--subject='Re: [alsa-devel] [PATCH -next] ASoC: SOF: imx8: Fix randbuild error' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).