From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, netdev@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] brcmfmac: increase F2 watermark for BCM4329
Date: Mon, 24 Aug 2020 10:28:57 +0200 [thread overview]
Message-ID: <93536fd4-8abc-e167-a184-5a5e36d4205a@broadcom.com> (raw)
In-Reply-To: <20200823142004.21990-1-digetx@gmail.com>
On 8/23/2020 4:20 PM, Dmitry Osipenko wrote:
> This patch fixes SDHCI CRC errors during of RX throughput testing on
> BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the
> checksum problem is observed on NVIDIA Tegra20 SoCs. The good watermark
> value is borrowed from downstream BCMDHD driver and it's the same as the
> value used for the BCM4339 chip, hence let's re-use it for BCM4329.
one comment, but when fixed you can add my....
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> index 3c07d1bbe1c6..ac3ee93a2378 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> @@ -4278,6 +4278,7 @@ static void brcmf_sdio_firmware_callback(struct device *dev, int err,
> brcmf_sdiod_writeb(sdiod, SBSDIO_FUNC1_MESBUSYCTRL,
> CY_43012_MESBUSYCTRL, &err);
> break;
> + case SDIO_DEVICE_ID_BROADCOM_4329:
> case SDIO_DEVICE_ID_BROADCOM_4339:
> brcmf_dbg(INFO, "set F2 watermark to 0x%x*4 bytes for 4339\n",
Maybe better to drop the chip id from the debug message. The chip id is
printed elsewhere already so it does not add info here and could only
cause confusion. Maybe you can also remove it from the 43455 message a
bit below.
next prev parent reply other threads:[~2020-08-24 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 14:20 [PATCH v1] brcmfmac: increase F2 watermark for BCM4329 Dmitry Osipenko
2020-08-24 8:28 ` Arend Van Spriel [this message]
2020-08-24 15:27 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93536fd4-8abc-e167-a184-5a5e36d4205a@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=digetx@gmail.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).