From: JC Kuo <jckuo@nvidia.com>
To: Arnd Bergmann <arnd@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Marc Zyngier <maz@kernel.org>,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
<linux-phy@lists.infradead.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] phy: tegra: xusb: annotate PM functions as __maybe_unused
Date: Thu, 22 Apr 2021 09:50:40 +0800 [thread overview]
Message-ID: <937252ad-d3f0-ff29-8e3d-1267d46202b0@nvidia.com> (raw)
In-Reply-To: <20210421135613.3560777-1-arnd@kernel.org>
Hi Arnd,
Thanks for the fix.
Reviewed-by: JC Kuo <jckuo@nvidia.com>
On 4/21/21 9:56 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Depending on the configuration, there are no references to these
> two helpers:
>
> drivers/phy/tegra/xusb.c:1286:12: error: 'tegra_xusb_padctl_resume_noirq' defined but not used [-Werror=unused-function]
> 1286 | static int tegra_xusb_padctl_resume_noirq(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/phy/tegra/xusb.c:1276:12: error: 'tegra_xusb_padctl_suspend_noirq' defined but not used [-Werror=unused-function]
>
> Mark them as __maybe_unused to shut up the warnings without adding
> fragile #ifdefs.
>
> Fixes: b8bb3d9c9b74 ("phy: tegra: xusb: Add sleepwalk and suspend/resume")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/phy/tegra/xusb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index 0aadac678191..963de5913e50 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -1273,7 +1273,7 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev)
> return err;
> }
>
> -static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
> +static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev)
> {
> struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev);
>
> @@ -1283,7 +1283,7 @@ static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
> return 0;
> }
>
> -static int tegra_xusb_padctl_resume_noirq(struct device *dev)
> +static __maybe_unused int tegra_xusb_padctl_resume_noirq(struct device *dev)
> {
> struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev);
>
>
next prev parent reply other threads:[~2021-04-22 1:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 13:56 [PATCH 1/2] phy: tegra: xusb: annotate PM functions as __maybe_unused Arnd Bergmann
2021-04-21 13:56 ` [PATCH 2/2] usb: xhci: tegra: mark " Arnd Bergmann
2021-04-22 1:54 ` JC Kuo
2021-04-22 2:06 ` JC Kuo
2021-04-22 1:50 ` JC Kuo [this message]
2021-04-22 2:05 ` [PATCH 1/2] phy: tegra: xusb: annotate " JC Kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=937252ad-d3f0-ff29-8e3d-1267d46202b0@nvidia.com \
--to=jckuo@nvidia.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=chunfeng.yun@mediatek.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maz@kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).