* [PATCH] msm/adreno: fix repeated words in comments
@ 2022-08-23 11:56 Jilin Yuan
2022-08-26 9:45 ` Dmitry Baryshkov
0 siblings, 1 reply; 6+ messages in thread
From: Jilin Yuan @ 2022-08-23 11:56 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, airlied, daniel
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Jilin Yuan
Delete the redundant word 'power'.
Delete the redundant word 'in'.
Delete the redundant word 'for'.
Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index 9f76f5b15759..32ecb783c3c1 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -352,7 +352,7 @@ void a6xx_gmu_clear_oob(struct a6xx_gmu *gmu, enum a6xx_gmu_oob_state state)
gmu_write(gmu, REG_A6XX_GMU_HOST2GMU_INTR_SET, 1 << bit);
}
-/* Enable CPU control of SPTP power power collapse */
+/* Enable CPU control of SPTP power collapse */
static int a6xx_sptprac_enable(struct a6xx_gmu *gmu)
{
int ret;
@@ -374,7 +374,7 @@ static int a6xx_sptprac_enable(struct a6xx_gmu *gmu)
return 0;
}
-/* Disable CPU control of SPTP power power collapse */
+/* Disable CPU control of SPTP power collapse */
static void a6xx_sptprac_disable(struct a6xx_gmu *gmu)
{
u32 val;
@@ -1277,7 +1277,7 @@ static int a6xx_gmu_rpmh_arc_votes_init(struct device *dev, u32 *votes,
}
/*
- * Look for a level in in the secondary list that matches. If
+ * Look for a level in the secondary list that matches. If
* nothing fits, use the maximum non zero vote
*/
@@ -1559,7 +1559,7 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node)
goto err_memory;
}
- /* Allocate memory for for the HFI queues */
+ /* Allocate memory for the HFI queues */
ret = a6xx_gmu_memory_alloc(gmu, &gmu->hfi, SZ_16K, 0, "hfi");
if (ret)
goto err_memory;
--
2.36.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] msm/adreno: fix repeated words in comments
2022-08-23 11:56 [PATCH] msm/adreno: fix repeated words in comments Jilin Yuan
@ 2022-08-26 9:45 ` Dmitry Baryshkov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-08-26 9:45 UTC (permalink / raw)
To: Jilin Yuan, robdclark, quic_abhinavk, airlied, daniel
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 23/08/2022 14:56, Jilin Yuan wrote:
> Delete the redundant word 'power'.
> Delete the redundant word 'in'.
> Delete the redundant word 'for'.
>
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
Could you please:
- adjust the commit subject to follow the rest of commit messages,
- drop the extra whitespace at the beginning of the commit message,
- add a correct Fixes tag.
Thank you
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index 9f76f5b15759..32ecb783c3c1 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -352,7 +352,7 @@ void a6xx_gmu_clear_oob(struct a6xx_gmu *gmu, enum a6xx_gmu_oob_state state)
> gmu_write(gmu, REG_A6XX_GMU_HOST2GMU_INTR_SET, 1 << bit);
> }
>
> -/* Enable CPU control of SPTP power power collapse */
> +/* Enable CPU control of SPTP power collapse */
> static int a6xx_sptprac_enable(struct a6xx_gmu *gmu)
> {
> int ret;
> @@ -374,7 +374,7 @@ static int a6xx_sptprac_enable(struct a6xx_gmu *gmu)
> return 0;
> }
>
> -/* Disable CPU control of SPTP power power collapse */
> +/* Disable CPU control of SPTP power collapse */
> static void a6xx_sptprac_disable(struct a6xx_gmu *gmu)
> {
> u32 val;
> @@ -1277,7 +1277,7 @@ static int a6xx_gmu_rpmh_arc_votes_init(struct device *dev, u32 *votes,
> }
>
> /*
> - * Look for a level in in the secondary list that matches. If
> + * Look for a level in the secondary list that matches. If
> * nothing fits, use the maximum non zero vote
> */
>
> @@ -1559,7 +1559,7 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node)
> goto err_memory;
> }
>
> - /* Allocate memory for for the HFI queues */
> + /* Allocate memory for the HFI queues */
> ret = a6xx_gmu_memory_alloc(gmu, &gmu->hfi, SZ_16K, 0, "hfi");
> if (ret)
> goto err_memory;
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] msm/adreno: fix repeated words in comments
2022-08-26 9:53 ` Dan Carpenter
@ 2022-08-26 10:05 ` Dmitry Baryshkov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-08-26 10:05 UTC (permalink / raw)
To: Dan Carpenter
Cc: wangjianli, robdclark, quic_abhinavk, sean, airlied, daniel,
wangqing, bjorn.andersson, linux-arm-msm, dri-devel, freedreno,
linux-kernel
On 26/08/2022 12:53, Dan Carpenter wrote:
> On Fri, Aug 26, 2022 at 12:45:09PM +0300, Dmitry Baryshkov wrote:
>> On 24/07/2022 10:36, wangjianli wrote:
>>> Delete the redundant word 'in'.
>>
>> Could you please:
>> - adjust the commit subject to follow the rest of commit messages,
>> - drop the extra whitespace at the beginning of the commit message,
>> - add a correct Fixes tag.
>
> This doesn't fix a bug so the fixes tag is inappropriate.
Well, it fixes a typo, but I see your point. Let's not insist on Fixes
for the comment fixes.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] msm/adreno: fix repeated words in comments
2022-08-26 9:45 ` Dmitry Baryshkov
@ 2022-08-26 9:53 ` Dan Carpenter
2022-08-26 10:05 ` Dmitry Baryshkov
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2022-08-26 9:53 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: wangjianli, robdclark, quic_abhinavk, sean, airlied, daniel,
wangqing, bjorn.andersson, linux-arm-msm, dri-devel, freedreno,
linux-kernel
On Fri, Aug 26, 2022 at 12:45:09PM +0300, Dmitry Baryshkov wrote:
> On 24/07/2022 10:36, wangjianli wrote:
> > Delete the redundant word 'in'.
>
> Could you please:
> - adjust the commit subject to follow the rest of commit messages,
> - drop the extra whitespace at the beginning of the commit message,
> - add a correct Fixes tag.
This doesn't fix a bug so the fixes tag is inappropriate.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] msm/adreno: fix repeated words in comments
2022-07-24 7:36 wangjianli
@ 2022-08-26 9:45 ` Dmitry Baryshkov
2022-08-26 9:53 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-08-26 9:45 UTC (permalink / raw)
To: wangjianli, robdclark, quic_abhinavk, sean, airlied, daniel,
wangqing, dan.carpenter, bjorn.andersson
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 24/07/2022 10:36, wangjianli wrote:
> Delete the redundant word 'in'.
Could you please:
- adjust the commit subject to follow the rest of commit messages,
- drop the extra whitespace at the beginning of the commit message,
- add a correct Fixes tag.
Thank you
>
> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index 9f76f5b15759..9303a011b81d 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -1277,7 +1277,7 @@ static int a6xx_gmu_rpmh_arc_votes_init(struct device *dev, u32 *votes,
> }
>
> /*
> - * Look for a level in in the secondary list that matches. If
> + * Look for a level in the secondary list that matches. If
> * nothing fits, use the maximum non zero vote
> */
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] msm/adreno: fix repeated words in comments
@ 2022-07-24 7:36 wangjianli
2022-08-26 9:45 ` Dmitry Baryshkov
0 siblings, 1 reply; 6+ messages in thread
From: wangjianli @ 2022-07-24 7:36 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied,
daniel, wangqing, dan.carpenter, bjorn.andersson
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, wangjianli
Delete the redundant word 'in'.
Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index 9f76f5b15759..9303a011b81d 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -1277,7 +1277,7 @@ static int a6xx_gmu_rpmh_arc_votes_init(struct device *dev, u32 *votes,
}
/*
- * Look for a level in in the secondary list that matches. If
+ * Look for a level in the secondary list that matches. If
* nothing fits, use the maximum non zero vote
*/
--
2.36.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-26 10:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 11:56 [PATCH] msm/adreno: fix repeated words in comments Jilin Yuan
2022-08-26 9:45 ` Dmitry Baryshkov
-- strict thread matches above, loose matches on Subject: below --
2022-07-24 7:36 wangjianli
2022-08-26 9:45 ` Dmitry Baryshkov
2022-08-26 9:53 ` Dan Carpenter
2022-08-26 10:05 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).