* [PATCH] ACPICA: Use ARRAY_SIZE instead of hardcoded siz
@ 2020-04-13 14:31 Jason Yan
2020-04-14 20:22 ` Moore, Robert
0 siblings, 1 reply; 3+ messages in thread
From: Jason Yan @ 2020-04-13 14:31 UTC (permalink / raw)
To: robert.moore, erik.kaneda, rafael.j.wysocki, lenb, linux-acpi,
devel, linux-kernel
Cc: Jason Yan
Fix the following coccicheck warning:
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/acpi/acpica/rsdumpinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpica/rsdumpinfo.c b/drivers/acpi/acpica/rsdumpinfo.c
index cafa8134b4c6..f1ba4cd8080f 100644
--- a/drivers/acpi/acpica/rsdumpinfo.c
+++ b/drivers/acpi/acpica/rsdumpinfo.c
@@ -15,7 +15,7 @@ ACPI_MODULE_NAME("rsdumpinfo")
#if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DISASSEMBLER) || defined(ACPI_DEBUGGER)
#define ACPI_RSD_OFFSET(f) (u8) ACPI_OFFSET (union acpi_resource_data,f)
#define ACPI_PRT_OFFSET(f) (u8) ACPI_OFFSET (struct acpi_pci_routing_table,f)
-#define ACPI_RSD_TABLE_SIZE(name) (sizeof(name) / sizeof (struct acpi_rsdump_info))
+#define ACPI_RSD_TABLE_SIZE(name) ARRAY_SIZE(name)
/*******************************************************************************
*
* Resource Descriptor info tables
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] ACPICA: Use ARRAY_SIZE instead of hardcoded siz
2020-04-13 14:31 [PATCH] ACPICA: Use ARRAY_SIZE instead of hardcoded siz Jason Yan
@ 2020-04-14 20:22 ` Moore, Robert
2020-04-15 3:13 ` Jason Yan
0 siblings, 1 reply; 3+ messages in thread
From: Moore, Robert @ 2020-04-14 20:22 UTC (permalink / raw)
To: Jason Yan, Kaneda, Erik, Wysocki, Rafael J, lenb, linux-acpi,
devel, linux-kernel
I think we've discussed this in the past. ARRAY_SIZE is not standard, and will get in the way of portability:
On gcc v7.4.0:
../../../source/components/resources/rsdumpinfo.c:335:25: note: in expansion of macro 'ACPI_RSD_TABLE_SIZE'
{ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE (AcpiRsDumpGenericReg), "Generic Register", NULL},
../../../source/components/resources/rsdumpinfo.c:166:37: error: initializer element is not constant
#define ACPI_RSD_TABLE_SIZE(name) ARRAY_SIZE (name)
And, on MSVC 2017:
Severity Code Description Project File Line Suppression State
Warning C4013 'ARRAY_SIZE' undefined; assuming extern returning int AcpiExec c:\acpica\source\components\resources\rsdumpinfo.c 179
-----Original Message-----
From: Jason Yan <yanaijie@huawei.com>
Sent: Monday, April 13, 2020 7:32 AM
To: Moore, Robert <robert.moore@intel.com>; Kaneda, Erik <erik.kaneda@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>; lenb@kernel.org; linux-acpi@vger.kernel.org; devel@acpica.org; linux-kernel@vger.kernel.org
Cc: Jason Yan <yanaijie@huawei.com>
Subject: [PATCH] ACPICA: Use ARRAY_SIZE instead of hardcoded siz
Fix the following coccicheck warning:
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/acpi/acpica/rsdumpinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpica/rsdumpinfo.c b/drivers/acpi/acpica/rsdumpinfo.c
index cafa8134b4c6..f1ba4cd8080f 100644
--- a/drivers/acpi/acpica/rsdumpinfo.c
+++ b/drivers/acpi/acpica/rsdumpinfo.c
@@ -15,7 +15,7 @@ ACPI_MODULE_NAME("rsdumpinfo") #if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DISASSEMBLER) || defined(ACPI_DEBUGGER)
#define ACPI_RSD_OFFSET(f) (u8) ACPI_OFFSET (union acpi_resource_data,f)
#define ACPI_PRT_OFFSET(f) (u8) ACPI_OFFSET (struct acpi_pci_routing_table,f)
-#define ACPI_RSD_TABLE_SIZE(name) (sizeof(name) / sizeof (struct acpi_rsdump_info))
+#define ACPI_RSD_TABLE_SIZE(name) ARRAY_SIZE(name)
/*******************************************************************************
*
* Resource Descriptor info tables
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPICA: Use ARRAY_SIZE instead of hardcoded siz
2020-04-14 20:22 ` Moore, Robert
@ 2020-04-15 3:13 ` Jason Yan
0 siblings, 0 replies; 3+ messages in thread
From: Jason Yan @ 2020-04-15 3:13 UTC (permalink / raw)
To: Moore, Robert, Kaneda, Erik, Wysocki, Rafael J, lenb, linux-acpi,
devel, linux-kernel
在 2020/4/15 4:22, Moore, Robert 写道:
> I think we've discussed this in the past. ARRAY_SIZE is not standard, and will get in the way of portability:
>
Thanks for the explanation. Got it.
> On gcc v7.4.0:
> ../../../source/components/resources/rsdumpinfo.c:335:25: note: in expansion of macro 'ACPI_RSD_TABLE_SIZE'
> {ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE (AcpiRsDumpGenericReg), "Generic Register", NULL},
>
> ../../../source/components/resources/rsdumpinfo.c:166:37: error: initializer element is not constant
> #define ACPI_RSD_TABLE_SIZE(name) ARRAY_SIZE (name)
>
>
> And, on MSVC 2017:
> Severity Code Description Project File Line Suppression State
> Warning C4013 'ARRAY_SIZE' undefined; assuming extern returning int AcpiExec c:\acpica\source\components\resources\rsdumpinfo.c 179
> -----Original Message-----
> From: Jason Yan <yanaijie@huawei.com>
> Sent: Monday, April 13, 2020 7:32 AM
> To: Moore, Robert <robert.moore@intel.com>; Kaneda, Erik <erik.kaneda@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>; lenb@kernel.org; linux-acpi@vger.kernel.org; devel@acpica.org; linux-kernel@vger.kernel.org
> Cc: Jason Yan <yanaijie@huawei.com>
> Subject: [PATCH] ACPICA: Use ARRAY_SIZE instead of hardcoded siz
>
> Fix the following coccicheck warning:
>
> ./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
> ./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
> ./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
> ./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
> ./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
> ./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
> ./drivers/acpi/acpica/rsdumpinfo.c:18:48-49: WARNING: Use ARRAY_SIZE
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/acpi/acpica/rsdumpinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/rsdumpinfo.c b/drivers/acpi/acpica/rsdumpinfo.c
> index cafa8134b4c6..f1ba4cd8080f 100644
> --- a/drivers/acpi/acpica/rsdumpinfo.c
> +++ b/drivers/acpi/acpica/rsdumpinfo.c
> @@ -15,7 +15,7 @@ ACPI_MODULE_NAME("rsdumpinfo") #if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DISASSEMBLER) || defined(ACPI_DEBUGGER)
> #define ACPI_RSD_OFFSET(f) (u8) ACPI_OFFSET (union acpi_resource_data,f)
> #define ACPI_PRT_OFFSET(f) (u8) ACPI_OFFSET (struct acpi_pci_routing_table,f)
> -#define ACPI_RSD_TABLE_SIZE(name) (sizeof(name) / sizeof (struct acpi_rsdump_info))
> +#define ACPI_RSD_TABLE_SIZE(name) ARRAY_SIZE(name)
> /*******************************************************************************
> *
> * Resource Descriptor info tables
> --
> 2.21.1
>
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-15 3:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 14:31 [PATCH] ACPICA: Use ARRAY_SIZE instead of hardcoded siz Jason Yan
2020-04-14 20:22 ` Moore, Robert
2020-04-15 3:13 ` Jason Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).