From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Palmer Dabbelt <palmerdabbelt@google.com>,
Atish Patra <atish.patra@wdc.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] riscv: Fix 32-bit RISC-V boot failure
Date: Thu, 1 Jul 2021 10:08:37 +0800 [thread overview]
Message-ID: <94a92009-ce49-bbe4-794c-0631520e4c3d@huawei.com> (raw)
In-Reply-To: <CAEUhbmUvDSocWobb26PcrV6vi6kHjg8o6pNomt9AnGWGbvAuhw@mail.gmail.com>
On 2021/6/30 19:58, Bin Meng wrote:
> On Mon, Jun 28, 2021 at 11:21 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>> On Mon, Jun 28, 2021 at 10:28 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>>
>>> On 2021/6/28 9:15, Bin Meng wrote:
>>>> On Mon, Jun 28, 2021 at 8:53 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>>>> Hi， sorry for the mistake，the bug is fixed by
>>>>>
>>>>> https://lore.kernel.org/linux-riscv/20210602085517.127481-2-wangkefeng.wang@huawei.com/
>>>> What are we on the patch you mentioned?
>>>>
>>>> I don't see it applied in the linux/master.
>>>>
>>>> Also there should be a "Fixes" tag and stable@vger.kernel.org cc'ed
>>>> because 32-bit is broken since v5.12.
>>> https://kernel.googlesource.com/pub/scm/linux/kernel/git/riscv/linux/+/c9811e379b211c67ba29fb09d6f644dd44cfcff2
>>>
>>> it's on Palmer' riscv-next.
>> Not sure riscv-next is for which release? This is a regression and
>> should be on 5.13.
>>
>>> Hi Palmer, should I resend or could you help me to add the fixes tag?
> Your patch mixed 2 things (fix plus one feature) together, so it is
> not proper to back port your patch.
"mem=" will change the range of memblock, so the fix part must be included.
>
> Here is my 2 cents:
>
> 1. Drop your patch from riscv-next
> 2. Apply my patch as it is a simple fix to previous commit. This
> allows stable kernel to cherry-pick the fix to v5.12 and v5.13.
> 3. Rebase your patch against mine, and resend v2
>
> Let me know if this makes sense.
It is not a big problem for me, but I have no right abourt riscv-next,
let's wait Palmer's advise.
>
> Regards,
> Bin
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-07-01 2:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 13:51 [PATCH] riscv: Fix 32-bit RISC-V boot failure Bin Meng
2021-06-28 0:53 ` Kefeng Wang
2021-06-28 1:15 ` Bin Meng
2021-06-28 2:28 ` Kefeng Wang
2021-06-28 3:21 ` Bin Meng
2021-06-30 11:58 ` Bin Meng
2021-07-01 2:08 ` Kefeng Wang [this message]
2021-07-01 2:20 ` Bin Meng
2021-07-08 13:29 ` Bin Meng
2021-07-16 2:14 ` Bin Meng
2021-07-22 5:53 ` Palmer Dabbelt
2021-07-22 6:29 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a92009-ce49-bbe4-794c-0631520e4c3d@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=atish.patra@wdc.com \
--cc=bmeng.cn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmerdabbelt@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).