From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Melody Olvera <quic_molvera@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Robert Marko <robimarko@gmail.com>,
Das Srinagesh <quic_gurus@quicinc.com>
Cc: "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatible
Date: Sun, 20 Nov 2022 11:45:36 +0100 [thread overview]
Message-ID: <94f23d11-dfa3-fd86-32ed-937c78592f20@linaro.org> (raw)
In-Reply-To: <20221118182614.11774-1-quic_molvera@quicinc.com>
On 18/11/2022 19:26, Melody Olvera wrote:
> Add compatible for scm driver for QDU1000 and QRU1000 platforms. These drivers
> only require the compatible field, so update the bindings accordingly for
> these platforms.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> This patch is separated out from [1] and includes
> changes addressing comments from that patch set.
>
> [1] https://lore.kernel.org/all/20221026190549.4005703-2-quic_molvera@quicinc.com/
Then this is a v4. Please always include the changelog.
Did you implement the changes requested? If they are no changes, then
review would stay the same as before.
>
> .../devicetree/bindings/firmware/qcom,scm.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> index 25688571ee7c..71012d43a32f 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -38,6 +38,7 @@ properties:
> - qcom,scm-msm8994
> - qcom,scm-msm8996
> - qcom,scm-msm8998
> + - qcom,scm-qdu1000
> - qcom,scm-sc7180
> - qcom,scm-sc7280
> - qcom,scm-sc8280xp
> @@ -82,6 +83,16 @@ properties:
> description: TCSR hardware block
>
> allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,scm-qdu1000
> + then:
> + properties:
> + clocks: false
> + clock-names: false
> +
> - if:
> properties:
> compatible:
>
> base-commit: 147307c69ba4441ee90c1f8ce8edf5df4ea60f67
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-20 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 18:26 [PATCH] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatible Melody Olvera
2022-11-20 10:45 ` Krzysztof Kozlowski [this message]
2022-11-21 16:17 ` Melody Olvera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94f23d11-dfa3-fd86-32ed-937c78592f20@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_gurus@quicinc.com \
--cc=quic_molvera@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).