* [PATCH] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatible
@ 2022-11-18 18:26 Melody Olvera
2022-11-20 10:45 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Melody Olvera @ 2022-11-18 18:26 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Robert Marko, Das Srinagesh
Cc: Melody Olvera, open list:ARM/QUALCOMM SUPPORT,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Add compatible for scm driver for QDU1000 and QRU1000 platforms. These drivers
only require the compatible field, so update the bindings accordingly for
these platforms.
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
This patch is separated out from [1] and includes
changes addressing comments from that patch set.
[1] https://lore.kernel.org/all/20221026190549.4005703-2-quic_molvera@quicinc.com/
.../devicetree/bindings/firmware/qcom,scm.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
index 25688571ee7c..71012d43a32f 100644
--- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
+++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
@@ -38,6 +38,7 @@ properties:
- qcom,scm-msm8994
- qcom,scm-msm8996
- qcom,scm-msm8998
+ - qcom,scm-qdu1000
- qcom,scm-sc7180
- qcom,scm-sc7280
- qcom,scm-sc8280xp
@@ -82,6 +83,16 @@ properties:
description: TCSR hardware block
allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,scm-qdu1000
+ then:
+ properties:
+ clocks: false
+ clock-names: false
+
- if:
properties:
compatible:
base-commit: 147307c69ba4441ee90c1f8ce8edf5df4ea60f67
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatible
2022-11-18 18:26 [PATCH] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatible Melody Olvera
@ 2022-11-20 10:45 ` Krzysztof Kozlowski
2022-11-21 16:17 ` Melody Olvera
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-20 10:45 UTC (permalink / raw)
To: Melody Olvera, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Robert Marko, Das Srinagesh
Cc: open list:ARM/QUALCOMM SUPPORT,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 18/11/2022 19:26, Melody Olvera wrote:
> Add compatible for scm driver for QDU1000 and QRU1000 platforms. These drivers
> only require the compatible field, so update the bindings accordingly for
> these platforms.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> This patch is separated out from [1] and includes
> changes addressing comments from that patch set.
>
> [1] https://lore.kernel.org/all/20221026190549.4005703-2-quic_molvera@quicinc.com/
Then this is a v4. Please always include the changelog.
Did you implement the changes requested? If they are no changes, then
review would stay the same as before.
>
> .../devicetree/bindings/firmware/qcom,scm.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> index 25688571ee7c..71012d43a32f 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -38,6 +38,7 @@ properties:
> - qcom,scm-msm8994
> - qcom,scm-msm8996
> - qcom,scm-msm8998
> + - qcom,scm-qdu1000
> - qcom,scm-sc7180
> - qcom,scm-sc7280
> - qcom,scm-sc8280xp
> @@ -82,6 +83,16 @@ properties:
> description: TCSR hardware block
>
> allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,scm-qdu1000
> + then:
> + properties:
> + clocks: false
> + clock-names: false
> +
> - if:
> properties:
> compatible:
>
> base-commit: 147307c69ba4441ee90c1f8ce8edf5df4ea60f67
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatible
2022-11-20 10:45 ` Krzysztof Kozlowski
@ 2022-11-21 16:17 ` Melody Olvera
0 siblings, 0 replies; 3+ messages in thread
From: Melody Olvera @ 2022-11-21 16:17 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Robert Marko, Das Srinagesh
Cc: open list:ARM/QUALCOMM SUPPORT,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 11/20/2022 4:45 AM, Krzysztof Kozlowski wrote:
> On 18/11/2022 19:26, Melody Olvera wrote:
>> Add compatible for scm driver for QDU1000 and QRU1000 platforms. These drivers
>> only require the compatible field, so update the bindings accordingly for
>> these platforms.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>> This patch is separated out from [1] and includes
>> changes addressing comments from that patch set.
>>
>> [1] https://lore.kernel.org/all/20221026190549.4005703-2-quic_molvera@quicinc.com/
> Then this is a v4. Please always include the changelog.
Apologies.
>
> Did you implement the changes requested? If they are no changes, then
> review would stay the same as before.
Yes the changes requested are implemented; this document is different from the
one originally submitted.
Thanks,
Melody
>
>> .../devicetree/bindings/firmware/qcom,scm.yaml | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> index 25688571ee7c..71012d43a32f 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> @@ -38,6 +38,7 @@ properties:
>> - qcom,scm-msm8994
>> - qcom,scm-msm8996
>> - qcom,scm-msm8998
>> + - qcom,scm-qdu1000
>> - qcom,scm-sc7180
>> - qcom,scm-sc7280
>> - qcom,scm-sc8280xp
>> @@ -82,6 +83,16 @@ properties:
>> description: TCSR hardware block
>>
>> allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: qcom,scm-qdu1000
>> + then:
>> + properties:
>> + clocks: false
>> + clock-names: false
>> +
>> - if:
>> properties:
>> compatible:
>>
>> base-commit: 147307c69ba4441ee90c1f8ce8edf5df4ea60f67
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-21 16:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-18 18:26 [PATCH] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatible Melody Olvera
2022-11-20 10:45 ` Krzysztof Kozlowski
2022-11-21 16:17 ` Melody Olvera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).