linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/11 linux-next] super magic values consolidation
@ 2017-05-21 15:39 Fabian Frederick
  2017-05-28  9:34 ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: Fabian Frederick @ 2017-05-21 15:39 UTC (permalink / raw)
  To: Alexander Viro
  Cc: linux-fsdevel, linux-kernel, ocfs2-devel, jfs-discussion,
	linux-mtd, pvfs2-developers, ceph-devel, fabf

This small patchset reorganizes magic.h and fixes filesystems
which defined locally super magic values.

Fabian Frederick (11):
  uapi: reorganize magic.h
  exofs: use magic.h
  ceph: use magic.h
  orangefs: use magic.h
  ubifs: use magic.h
  jfs: use magic.h
  ocfs2: use magic.h
  fuse: use magic.h
  freevxfs: use magic.h
  fs: define hfs super magic values globally
  hfsplus: export super magic value

 fs/ceph/super.h            |   4 +-
 fs/exofs/common.h          |   6 +--
 fs/freevxfs/vxfs.h         |   6 +--
 fs/fuse/control.c          |   3 +-
 fs/fuse/inode.c            |   3 +-
 fs/hfs/hfs.h               |   4 +-
 fs/hfsplus/hfsplus_raw.h   |   2 +-
 fs/hfsplus/part_tbl.c      |   2 -
 fs/jfs/jfs_incore.h        |   6 +--
 fs/ocfs2/ocfs2_fs.h        |   5 +--
 fs/orangefs/protocol.h     |   3 +-
 fs/ubifs/ubifs.h           |   4 +-
 include/uapi/linux/magic.h | 104 ++++++++++++++++++++++-----------------------
 13 files changed, 65 insertions(+), 87 deletions(-)

-- 
2.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 00/11 linux-next] super magic values consolidation
  2017-05-21 15:39 [PATCH 00/11 linux-next] super magic values consolidation Fabian Frederick
@ 2017-05-28  9:34 ` Christoph Hellwig
  2017-05-28 12:00   ` Fabian Frederick
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2017-05-28  9:34 UTC (permalink / raw)
  To: Fabian Frederick
  Cc: Alexander Viro, linux-fsdevel, linux-kernel, ocfs2-devel,
	jfs-discussion, linux-mtd, pvfs2-developers, ceph-devel

On Sun, May 21, 2017 at 05:39:47PM +0200, Fabian Frederick wrote:
> This small patchset reorganizes magic.h and fixes filesystems
> which defined locally super magic values.

And what's the point?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 00/11 linux-next] super magic values consolidation
  2017-05-28  9:34 ` Christoph Hellwig
@ 2017-05-28 12:00   ` Fabian Frederick
  0 siblings, 0 replies; 3+ messages in thread
From: Fabian Frederick @ 2017-05-28 12:00 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: linux-mtd, pvfs2-developers, ocfs2-devel, linux-kernel,
	Alexander Viro, ceph-devel, linux-fsdevel, jfs-discussion



> On 28 May 2017 at 11:34 Christoph Hellwig <hch@infradead.org> wrote:
>
>
> On Sun, May 21, 2017 at 05:39:47PM +0200, Fabian Frederick wrote:
> > This small patchset reorganizes magic.h and fixes filesystems
> > which defined locally super magic values.
>
> And what's the point?

Current magic.h organization is strange for the less. Filesystems generally use
SUPER_MAGIC values from magic.h
instead of a local definition plus it looks easier for new subsystems to look at
just one file when
seeking for unique value.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-28 12:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-21 15:39 [PATCH 00/11 linux-next] super magic values consolidation Fabian Frederick
2017-05-28  9:34 ` Christoph Hellwig
2017-05-28 12:00   ` Fabian Frederick

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).