From: Basavaraj Natikar <bnatikar@amd.com>
To: "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@amd.com>,
Jiri Kosina <jikos@kernel.org>,
Evgeny Novikov <novikov@ispras.ru>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ldv-project@linuxtesting.org" <ldv-project@linuxtesting.org>,
"Natikar, Basavaraj" <Basavaraj.Natikar@amd.com>
Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference
Date: Thu, 16 Sep 2021 11:29:32 +0530 [thread overview]
Message-ID: <9597d27e-6df2-03c3-57fe-e77f0b044d4b@amd.com> (raw)
In-Reply-To: <BN9PR12MB505242B95EA964CF0990C006A0DB9@BN9PR12MB5052.namprd12.prod.outlook.com>
On 9/15/2021 11:02 PM, Shah, Nehal-bakulchandra wrote:
> Adding Basavaraj
>
> -----Original Message-----
> From: Jiri Kosina <jikos@kernel.org>
> Sent: Wednesday, September 15, 2021 8:28 PM
> To: Evgeny Novikov <novikov@ispras.ru>
> Cc: Shah, Nehal-bakulchandra <Nehal-bakulchandra.Shah@amd.com>; Sandeep Singh <sandeep.singh@amd.com>; Benjamin Tissoires <benjamin.tissoires@redhat.com>; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; ldv-project@linuxtesting.org
> Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference
>
> On Tue, 1 Jun 2021, Evgeny Novikov wrote:
>
>> devm_add_action_or_reset() can suddenly invoke amd_mp2_pci_remove() at
>> registration that will cause NULL pointer dereference since
>> corresponding data is not initialized yet. The patch moves
>> initialization of data before devm_add_action_or_reset().
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
> Nehal, Basavaraj, could you please Review/Ack this one?
>
Patch looks good to me. Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
next prev parent reply other threads:[~2021-09-16 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 16:38 [PATCH] AMD_SFH: Fix potential NULL pointer dereference Evgeny Novikov
2021-09-15 14:58 ` Jiri Kosina
2021-09-15 17:32 ` Shah, Nehal-bakulchandra
2021-09-16 5:59 ` Basavaraj Natikar [this message]
2021-09-16 7:15 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9597d27e-6df2-03c3-57fe-e77f0b044d4b@amd.com \
--to=bnatikar@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=ldv-project@linuxtesting.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=novikov@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).