From: Jiri Kosina <jikos@kernel.org>
To: Evgeny Novikov <novikov@ispras.ru>
Cc: Nehal Shah <nehal-bakulchandra.shah@amd.com>,
Sandeep Singh <sandeep.singh@amd.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference
Date: Wed, 15 Sep 2021 16:58:19 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2109151657580.15944@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210601163801.17848-1-novikov@ispras.ru>
On Tue, 1 Jun 2021, Evgeny Novikov wrote:
> devm_add_action_or_reset() can suddenly invoke amd_mp2_pci_remove() at
> registration that will cause NULL pointer dereference since
> corresponding data is not initialized yet. The patch moves
> initialization of data before devm_add_action_or_reset().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Nehal, Basavaraj, could you please Review/Ack this one?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2021-09-15 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 16:38 [PATCH] AMD_SFH: Fix potential NULL pointer dereference Evgeny Novikov
2021-09-15 14:58 ` Jiri Kosina [this message]
2021-09-15 17:32 ` Shah, Nehal-bakulchandra
2021-09-16 5:59 ` Basavaraj Natikar
2021-09-16 7:15 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2109151657580.15944@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=novikov@ispras.ru \
--cc=sandeep.singh@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).