linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 6/8]drivers:staging:brcm80211i:sbsdio.h change a typo comamnd to command
@ 2011-02-02  5:07 Justin P. Mattock
  2011-02-04 20:59 ` [PATCH 6/8]staging: brcm80211i: sbsdio.h: " Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Justin P. Mattock @ 2011-02-02  5:07 UTC (permalink / raw)
  To: trivial; +Cc: henryp, gregkh, linux-wireless, linux-kernel, Justin P. Mattock

The below patch fixes a typo comamnd to command.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/staging/brcm80211/include/sbsdio.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/brcm80211/include/sbsdio.h b/drivers/staging/brcm80211/include/sbsdio.h
index 6afdbbe..c190acb 100644
--- a/drivers/staging/brcm80211/include/sbsdio.h
+++ b/drivers/staging/brcm80211/include/sbsdio.h
@@ -144,7 +144,7 @@
 						 */
 
 #define SBSDIO_BYTEMODE_DATALEN_MAX	64	/* sdio byte mode: maximum length of one
-						 * data comamnd
+						 * data command 
 						 */
 
 #define SBSDIO_CORE_ADDR_MASK		0x1FFFF	/* sdio core function one address mask */
-- 
1.6.5.GIT


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 6/8]staging: brcm80211i: sbsdio.h: change a typo comamnd to command
  2011-02-02  5:07 [PATCH 6/8]drivers:staging:brcm80211i:sbsdio.h change a typo comamnd to command Justin P. Mattock
@ 2011-02-04 20:59 ` Greg KH
  2011-02-04 21:00   ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2011-02-04 20:59 UTC (permalink / raw)
  To: Justin P. Mattock; +Cc: trivial, henryp, gregkh, linux-wireless, linux-kernel

On Tue, Feb 01, 2011 at 09:07:28PM -0800, Justin P. Mattock wrote:
> The below patch fixes a typo comamnd to command.
> 
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> 
> ---
>  drivers/staging/brcm80211/include/sbsdio.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/brcm80211/include/sbsdio.h b/drivers/staging/brcm80211/include/sbsdio.h
> index 6afdbbe..c190acb 100644
> --- a/drivers/staging/brcm80211/include/sbsdio.h
> +++ b/drivers/staging/brcm80211/include/sbsdio.h
> @@ -144,7 +144,7 @@
>  						 */
>  
>  #define SBSDIO_BYTEMODE_DATALEN_MAX	64	/* sdio byte mode: maximum length of one
> -						 * data comamnd
> +						 * data command 

This patch adds a trailing space, which is not allowed.

Please fix this and resend.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 6/8]staging: brcm80211i: sbsdio.h: change a typo comamnd to command
  2011-02-04 20:59 ` [PATCH 6/8]staging: brcm80211i: sbsdio.h: " Greg KH
@ 2011-02-04 21:00   ` Greg KH
  2011-02-04 21:13     ` Justin Mattock
  0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2011-02-04 21:00 UTC (permalink / raw)
  To: Justin P. Mattock; +Cc: trivial, henryp, gregkh, linux-wireless, linux-kernel

On Fri, Feb 04, 2011 at 12:59:19PM -0800, Greg KH wrote:
> On Tue, Feb 01, 2011 at 09:07:28PM -0800, Justin P. Mattock wrote:
> > The below patch fixes a typo comamnd to command.
> > 
> > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> > 
> > ---
> >  drivers/staging/brcm80211/include/sbsdio.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/staging/brcm80211/include/sbsdio.h b/drivers/staging/brcm80211/include/sbsdio.h
> > index 6afdbbe..c190acb 100644
> > --- a/drivers/staging/brcm80211/include/sbsdio.h
> > +++ b/drivers/staging/brcm80211/include/sbsdio.h
> > @@ -144,7 +144,7 @@
> >  						 */
> >  
> >  #define SBSDIO_BYTEMODE_DATALEN_MAX	64	/* sdio byte mode: maximum length of one
> > -						 * data comamnd
> > +						 * data command 
> 
> This patch adds a trailing space, which is not allowed.
> 
> Please fix this and resend.

Nevermind, I've edited this by hand and fixed it up.

Please be more careful in the future and ALWAYS run your patches through
scripts/checkpatch.pl to catch these types of things.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 6/8]staging: brcm80211i: sbsdio.h: change a typo comamnd to command
  2011-02-04 21:00   ` Greg KH
@ 2011-02-04 21:13     ` Justin Mattock
  0 siblings, 0 replies; 4+ messages in thread
From: Justin Mattock @ 2011-02-04 21:13 UTC (permalink / raw)
  To: Greg KH; +Cc: trivial, henryp, gregkh, linux-wireless, linux-kernel


On Feb 4, 2011, at 1:00 PM, Greg KH wrote:

> On Fri, Feb 04, 2011 at 12:59:19PM -0800, Greg KH wrote:
>> On Tue, Feb 01, 2011 at 09:07:28PM -0800, Justin P. Mattock wrote:
>>> The below patch fixes a typo comamnd to command.
>>>
>>> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>>>
>>> ---
>>> drivers/staging/brcm80211/include/sbsdio.h |    2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/staging/brcm80211/include/sbsdio.h b/drivers/ 
>>> staging/brcm80211/include/sbsdio.h
>>> index 6afdbbe..c190acb 100644
>>> --- a/drivers/staging/brcm80211/include/sbsdio.h
>>> +++ b/drivers/staging/brcm80211/include/sbsdio.h
>>> @@ -144,7 +144,7 @@
>>> 						 */
>>>
>>> #define SBSDIO_BYTEMODE_DATALEN_MAX	64	/* sdio byte mode: maximum  
>>> length of one
>>> -						 * data comamnd
>>> +						 * data command
>>
>> This patch adds a trailing space, which is not allowed.
>>
>> Please fix this and resend.
>
> Nevermind, I've edited this by hand and fixed it up.
>
> Please be more careful in the future and ALWAYS run your patches  
> through
> scripts/checkpatch.pl to catch these types of things.
>
> thanks,
>
> greg k-h


yep I admit I had forgotten to use that script(was focusing on  
maintainers)..
I will remember that next time..

Thanks..

Justin P. Mattock

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-02-04 21:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-02  5:07 [PATCH 6/8]drivers:staging:brcm80211i:sbsdio.h change a typo comamnd to command Justin P. Mattock
2011-02-04 20:59 ` [PATCH 6/8]staging: brcm80211i: sbsdio.h: " Greg KH
2011-02-04 21:00   ` Greg KH
2011-02-04 21:13     ` Justin Mattock

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).