From: Milo Kim <woogyom.kim@gmail.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1
Date: Tue, 6 Dec 2016 16:23:57 +0900 [thread overview]
Message-ID: <9607940c-1ca9-bb49-291e-ddc7e77546be@gmail.com> (raw)
In-Reply-To: <20161205080932.xaqyl2httgxgso67@lukather>
On 12/05/2016 05:09 PM, Maxime Ripard wrote:
> On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:
>> The board has DDR3 512MB. This patch helps scanning the memory and
>> adding memblock through the DT.
>>
>> Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
>> ---
>> arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
>> index ec63d10..be3668f 100644
>> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
>> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
>> @@ -45,6 +45,11 @@
>> / {
>> model = "FriendlyArm NanoPi M1";
>> compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
>> +
>> + memory@40000000 {
>> + device_type = "memory";
>> + reg = <0x40000000 0x20000000>;
>> + };
>
> U-boot will fill that up, so there's no need to put it there.
Right, my intention was adding memblock through the DT whether the
bootload does or not. However I'm not sure the situation (missing
memblock in u-boot) could really happen.
Best regards,
Milo
next prev parent reply other threads:[~2016-12-06 7:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 2:00 [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Milo Kim
2016-12-05 2:00 ` [PATCH 2/2] ARM: dts: sun8i: Specify memblock for Nano Pi Neo Milo Kim
2016-12-05 8:09 ` [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Maxime Ripard
2016-12-06 7:23 ` Milo Kim [this message]
2016-12-06 14:00 ` Maxime Ripard
2016-12-06 14:28 ` Milo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9607940c-1ca9-bb49-291e-ddc7e77546be@gmail.com \
--to=woogyom.kim@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).