From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Markus Mayer <mmayer@broadcom.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] ACPI / device_sysfs: make use of new strtolower() function
Date: Fri, 01 Jul 2016 22:44:33 +0200 [thread overview]
Message-ID: <9679780.CKS7jhtgO8@vostro.rjw.lan> (raw)
In-Reply-To: <1467330612-26242-5-git-send-email-mmayer@broadcom.com>
On Thursday, June 30, 2016 04:50:10 PM Markus Mayer wrote:
> Call strtolower() rather than walking the string explicitly to convert
> it to lowercase.
>
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
ACK
> ---
> drivers/acpi/device_sysfs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
> index 7b2c48f..1db38c7 100644
> --- a/drivers/acpi/device_sysfs.c
> +++ b/drivers/acpi/device_sysfs.c
> @@ -200,12 +200,10 @@ static int create_of_modalias(struct acpi_device *acpi_dev, char *modalias,
> const union acpi_object *of_compatible, *obj;
> int len, count;
> int i, nval;
> - char *c;
>
> acpi_get_name(acpi_dev->handle, ACPI_SINGLE_NAME, &buf);
> /* DT strings are all in lower case */
> - for (c = buf.pointer; *c != '\0'; c++)
> - *c = tolower(*c);
> + strtolower(buf.pointer);
>
> len = snprintf(modalias, size, "of:N%sT", (char *)buf.pointer);
> ACPI_FREE(buf.pointer);
>
next prev parent reply other threads:[~2016-07-01 20:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 23:50 [PATCH 0/6] lib: string: add function strtolower() Markus Mayer
2016-06-30 23:50 ` [PATCH 1/6] " Markus Mayer
2016-07-01 10:52 ` Jani Nikula
2016-07-01 17:14 ` Markus Mayer
2016-07-01 17:33 ` Jani Nikula
2016-07-01 21:08 ` Rasmus Villemoes
2016-07-04 20:18 ` Markus Mayer
2016-06-30 23:50 ` [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function Markus Mayer
2016-07-02 1:18 ` [Nouveau] " Alexandre Courbot
2016-07-02 15:21 ` Markus Mayer
2016-07-04 1:37 ` Alexandre Courbot
2016-07-04 3:39 ` Alexandre Courbot
2016-06-30 23:50 ` [PATCH 3/6] ACPICA: " Markus Mayer
2016-07-01 1:11 ` Moore, Robert
[not found] ` <CAGt4E5uqbjaubPWE4rq-T7MvqAmwpUhvakM+jv+Sen8est9U5g@mail.gmail.com>
[not found] ` <94F2FBAB4432B54E8AACC7DFDE6C92E37E4C381C@ORSMSX110.amr.corp.intel.com>
2016-07-01 4:13 ` Markus Mayer
2016-07-01 4:32 ` Moore, Robert
2016-06-30 23:50 ` [PATCH 4/6] ACPI / device_sysfs: " Markus Mayer
2016-07-01 20:44 ` Rafael J. Wysocki [this message]
2016-06-30 23:50 ` [PATCH 5/6] staging: speakup: replace spk_strlwr() with strtolower() Markus Mayer
2016-06-30 23:53 ` Samuel Thibault
2016-06-30 23:50 ` [PATCH 6/6] iscsi-target: replace iscsi_initiatorname_tolower() " Markus Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9679780.CKS7jhtgO8@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmayer@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).