Re: [PATCH 3/6] ACPICA: make use of new strtolower() function

[Markus Mayer <markus.mayer@broadcom.com>]

On 30 June 2016 at 19:59, Moore, Robert <robert.moore@intel.com> wrote:
> This is linux-specific code, ACPICA is os-independent. So we cannot accept
> such patch.

Understood. I wasn't aware that this was shared code.

> From: Markus Mayer [mailto:markus.mayer@broadcom.com]
> Sent: Thursday, June 30, 2016 7:50 PM
> To: Moore, Robert
> Cc: Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-acpi@vger.kernel.org;
> devel@acpica.org; linux-kernel@vger.kernel.org; Box, David E
> Subject: Re: [PATCH 3/6] ACPICA: make use of new strtolower() function
>
> On Thursday, 30 June 2016, Moore, Robert <robert.moore@intel.com> wrote:
>
> Where is "strtolower" implemented?
>
> First patch of the series:
>
> https://lkml.org/lkml/2016/6/30/733
>
>> -----Original Message-----
>> From: Markus Mayer [mailto:mmayer@broadcom.com]
>> Sent: Thursday, June 30, 2016 4:50 PM
>> To: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown
>> Cc: Markus Mayer; linux-acpi@vger.kernel.org; devel@acpica.org; linux-
>> kernel@vger.kernel.org
>> Subject: [PATCH 3/6] ACPICA: make use of new strtolower() function
>>
>> Call strtolower() rather than walking the string explicitly to convert it
>> to lowercase.
>>
>> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
>> ---
>>
>> *** Please note that there don't seem to be any callers of
>> acpi_ut_strlwr().
>> *** It may be possible to remove the function altogether.
>>
>>  drivers/acpi/acpica/utnonansi.c | 13 +------------
>>  1 file changed, 1 insertion(+), 12 deletions(-)
>>
>> diff --git a/drivers/acpi/acpica/utnonansi.c
>> b/drivers/acpi/acpica/utnonansi.c index 3465fe2..b6e11dc 100644
>> --- a/drivers/acpi/acpica/utnonansi.c
>> +++ b/drivers/acpi/acpica/utnonansi.c
>> @@ -64,19 +64,8 @@ ACPI_MODULE_NAME("utnonansi")
>>
>> **************************************************************************
>> ****/
>>  void acpi_ut_strlwr(char *src_string)
>>  {
>> -     char *string;
>> -
>>       ACPI_FUNCTION_ENTRY();
>> -
>> -     if (!src_string) {
>> -             return;
>> -     }
>> -
>> -     /* Walk entire string, lowercasing the letters */
>> -
>> -     for (string = src_string; *string; string++) {
>> -             *string = (char)tolower((int)*string);
>> -     }
>> +     strtolower(src_string);
>>  }
>>
>>
>> /*************************************************************************
>> ******
>> --
>> 2.7.4