* [PATCH] drm/fsl-dcu: add COMMON_CLK dependency
@ 2016-05-02 11:00 Arnd Bergmann
2016-05-02 21:22 ` Stefan Agner
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-05-02 11:00 UTC (permalink / raw)
To: Stefan Agner, Alison Wang, David Airlie
Cc: linux-arm-kernel, dri-devel, Arnd Bergmann, Xiubo Li,
Daniel Vetter, Jianwei Wang, linux-kernel
The fsl dcu now uses the clk-provider interfaces, which are not available
when CONFIG_COMMON_CLK is disabled:
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c: In function 'fsl_dcu_drm_probe':
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:362:20: error: implicit declaration of function '__clk_get_name' [-Werror=implicit-function-declaration]
pix_clk_in_name = __clk_get_name(pix_clk_in);
This adds a Kconfig dependency to prevent the driver from being enabled
in this case.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 2d701449bce1 ("drm/fsl-dcu: use common clock framework for pixel clock divider")
---
drivers/gpu/drm/fsl-dcu/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig
index c78cf3f605d0..b9c714de6e40 100644
--- a/drivers/gpu/drm/fsl-dcu/Kconfig
+++ b/drivers/gpu/drm/fsl-dcu/Kconfig
@@ -1,6 +1,6 @@
config DRM_FSL_DCU
tristate "DRM Support for Freescale DCU"
- depends on DRM && OF && ARM
+ depends on DRM && OF && ARM && COMMON_CLK
select BACKLIGHT_CLASS_DEVICE
select BACKLIGHT_LCD_SUPPORT
select DRM_KMS_HELPER
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/fsl-dcu: add COMMON_CLK dependency
2016-05-02 11:00 [PATCH] drm/fsl-dcu: add COMMON_CLK dependency Arnd Bergmann
@ 2016-05-02 21:22 ` Stefan Agner
2016-05-03 8:18 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Agner @ 2016-05-02 21:22 UTC (permalink / raw)
To: Arnd Bergmann, David Airlie
Cc: Alison Wang, David Airlie, linux-arm-kernel, dri-devel, Xiubo Li,
Daniel Vetter, Jianwei Wang, linux-kernel
On 2016-05-02 04:00, Arnd Bergmann wrote:
> The fsl dcu now uses the clk-provider interfaces, which are not available
> when CONFIG_COMMON_CLK is disabled:
>
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c: In function 'fsl_dcu_drm_probe':
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:362:20: error: implicit
> declaration of function '__clk_get_name'
> [-Werror=implicit-function-declaration]
> pix_clk_in_name = __clk_get_name(pix_clk_in);
>
> This adds a Kconfig dependency to prevent the driver from being enabled
> in this case.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 2d701449bce1 ("drm/fsl-dcu: use common clock framework for
> pixel clock divider")
Oh right, thx!
Acked-by: Stefan Agner <stefan@agner.ch>
@Dave, can you pick that up directly or do you prefer a pull request?
--
Stefan
> ---
> drivers/gpu/drm/fsl-dcu/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig
> index c78cf3f605d0..b9c714de6e40 100644
> --- a/drivers/gpu/drm/fsl-dcu/Kconfig
> +++ b/drivers/gpu/drm/fsl-dcu/Kconfig
> @@ -1,6 +1,6 @@
> config DRM_FSL_DCU
> tristate "DRM Support for Freescale DCU"
> - depends on DRM && OF && ARM
> + depends on DRM && OF && ARM && COMMON_CLK
> select BACKLIGHT_CLASS_DEVICE
> select BACKLIGHT_LCD_SUPPORT
> select DRM_KMS_HELPER
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/fsl-dcu: add COMMON_CLK dependency
2016-05-02 21:22 ` Stefan Agner
@ 2016-05-03 8:18 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2016-05-03 8:18 UTC (permalink / raw)
To: Stefan Agner
Cc: Arnd Bergmann, David Airlie, Alison Wang, linux-arm-kernel,
dri-devel, Xiubo Li, Daniel Vetter, Jianwei Wang, linux-kernel
On Mon, May 02, 2016 at 02:22:04PM -0700, Stefan Agner wrote:
> On 2016-05-02 04:00, Arnd Bergmann wrote:
> > The fsl dcu now uses the clk-provider interfaces, which are not available
> > when CONFIG_COMMON_CLK is disabled:
> >
> > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c: In function 'fsl_dcu_drm_probe':
> > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:362:20: error: implicit
> > declaration of function '__clk_get_name'
> > [-Werror=implicit-function-declaration]
> > pix_clk_in_name = __clk_get_name(pix_clk_in);
> >
> > This adds a Kconfig dependency to prevent the driver from being enabled
> > in this case.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 2d701449bce1 ("drm/fsl-dcu: use common clock framework for
> > pixel clock divider")
>
> Oh right, thx!
>
> Acked-by: Stefan Agner <stefan@agner.ch>
>
> @Dave, can you pick that up directly or do you prefer a pull request?
Smashed into drm-misc, thanks.
-Daniel
>
> --
> Stefan
>
> > ---
> > drivers/gpu/drm/fsl-dcu/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig
> > index c78cf3f605d0..b9c714de6e40 100644
> > --- a/drivers/gpu/drm/fsl-dcu/Kconfig
> > +++ b/drivers/gpu/drm/fsl-dcu/Kconfig
> > @@ -1,6 +1,6 @@
> > config DRM_FSL_DCU
> > tristate "DRM Support for Freescale DCU"
> > - depends on DRM && OF && ARM
> > + depends on DRM && OF && ARM && COMMON_CLK
> > select BACKLIGHT_CLASS_DEVICE
> > select BACKLIGHT_LCD_SUPPORT
> > select DRM_KMS_HELPER
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-03 8:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-02 11:00 [PATCH] drm/fsl-dcu: add COMMON_CLK dependency Arnd Bergmann
2016-05-02 21:22 ` Stefan Agner
2016-05-03 8:18 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).