* [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request()
@ 2020-07-04 7:28 Baolin Wang
2020-07-10 8:23 ` Baolin Wang
2020-07-10 14:00 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Baolin Wang @ 2020-07-04 7:28 UTC (permalink / raw)
To: axboe; +Cc: ming.lei, baolin.wang, baolin.wang7, linux-block, linux-kernel
We've already validated the 'q->elevator' before calling ->ops.completed_request()
in blk_mq_sched_completed_request(), thus no need to validate rq->internal_tag again,
and remove it.
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
---
block/blk-mq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index abcf590f6238..78572b2e1675 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -550,8 +550,7 @@ inline void __blk_mq_end_request(struct request *rq, blk_status_t error)
blk_stat_add(rq, now);
}
- if (rq->internal_tag != BLK_MQ_NO_TAG)
- blk_mq_sched_completed_request(rq, now);
+ blk_mq_sched_completed_request(rq, now);
blk_account_io_done(rq, now);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request()
2020-07-04 7:28 [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request() Baolin Wang
@ 2020-07-10 8:23 ` Baolin Wang
2020-07-10 9:47 ` Ming Lei
2020-07-10 14:00 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Baolin Wang @ 2020-07-10 8:23 UTC (permalink / raw)
To: axboe; +Cc: ming.lei, baolin.wang7, linux-block, linux-kernel
Hi,
On Sat, Jul 04, 2020 at 03:28:21PM +0800, Baolin Wang wrote:
> We've already validated the 'q->elevator' before calling ->ops.completed_request()
> in blk_mq_sched_completed_request(), thus no need to validate rq->internal_tag again,
> and remove it.
A gentle ping?
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> block/blk-mq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index abcf590f6238..78572b2e1675 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -550,8 +550,7 @@ inline void __blk_mq_end_request(struct request *rq, blk_status_t error)
> blk_stat_add(rq, now);
> }
>
> - if (rq->internal_tag != BLK_MQ_NO_TAG)
> - blk_mq_sched_completed_request(rq, now);
> + blk_mq_sched_completed_request(rq, now);
>
> blk_account_io_done(rq, now);
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request()
2020-07-10 8:23 ` Baolin Wang
@ 2020-07-10 9:47 ` Ming Lei
0 siblings, 0 replies; 4+ messages in thread
From: Ming Lei @ 2020-07-10 9:47 UTC (permalink / raw)
To: Baolin Wang; +Cc: axboe, baolin.wang7, linux-block, linux-kernel
On Fri, Jul 10, 2020 at 04:23:04PM +0800, Baolin Wang wrote:
> Hi,
>
> On Sat, Jul 04, 2020 at 03:28:21PM +0800, Baolin Wang wrote:
> > We've already validated the 'q->elevator' before calling ->ops.completed_request()
> > in blk_mq_sched_completed_request(), thus no need to validate rq->internal_tag again,
> > and remove it.
>
> A gentle ping?
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request()
2020-07-04 7:28 [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request() Baolin Wang
2020-07-10 8:23 ` Baolin Wang
@ 2020-07-10 14:00 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2020-07-10 14:00 UTC (permalink / raw)
To: Baolin Wang; +Cc: ming.lei, baolin.wang7, linux-block, linux-kernel
On 7/4/20 1:28 AM, Baolin Wang wrote:
> We've already validated the 'q->elevator' before calling ->ops.completed_request()
> in blk_mq_sched_completed_request(), thus no need to validate rq->internal_tag again,
> and remove it.
Applied, but I reformatted and edited your commit message.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-10 14:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-04 7:28 [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request() Baolin Wang
2020-07-10 8:23 ` Baolin Wang
2020-07-10 9:47 ` Ming Lei
2020-07-10 14:00 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).