* Re: [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
2020-02-08 22:07 [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs Colin King
@ 2020-02-09 15:34 ` Cezary Rojewski
2020-02-10 8:49 ` Dan Carpenter
2020-02-10 14:09 ` [alsa-devel] " Pierre-Louis Bossart
2 siblings, 0 replies; 4+ messages in thread
From: Cezary Rojewski @ 2020-02-09 15:34 UTC (permalink / raw)
To: Colin King
Cc: Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Vinod Koul, Subhransu S . Prusty,
alsa-devel, kernel-janitors, linux-kernel
On 2020-02-08 23:07, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function sst_platform_get_resources always returns zero and
> error return codes set by the function are never returned. Fix this
> by returning the error return code in variable ret rather than the
> hard coded zero.
>
> Addresses-Coverity: ("Unused value")
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/intel/atom/sst/sst_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
> index d952719bc098..5862fe968083 100644
> --- a/sound/soc/intel/atom/sst/sst_pci.c
> +++ b/sound/soc/intel/atom/sst/sst_pci.c
> @@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
> do_release_regions:
> pci_release_regions(pci);
> - return 0;
> + return ret;
> }
>
> /*
>
Thank you for the fix.
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
2020-02-08 22:07 [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs Colin King
2020-02-09 15:34 ` Cezary Rojewski
@ 2020-02-10 8:49 ` Dan Carpenter
2020-02-10 14:09 ` [alsa-devel] " Pierre-Louis Bossart
2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-02-10 8:49 UTC (permalink / raw)
To: Colin King, Vinod Koul
Cc: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood, Jie Yang,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Subhransu S . Prusty,
alsa-devel, kernel-janitors, linux-kernel
On Sat, Feb 08, 2020 at 10:07:20PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function sst_platform_get_resources always returns zero and
> error return codes set by the function are never returned. Fix this
> by returning the error return code in variable ret rather than the
> hard coded zero.
>
> Addresses-Coverity: ("Unused value")
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/intel/atom/sst/sst_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
> index d952719bc098..5862fe968083 100644
> --- a/sound/soc/intel/atom/sst/sst_pci.c
> +++ b/sound/soc/intel/atom/sst/sst_pci.c
> @@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
> do_release_regions:
> pci_release_regions(pci);
It's weird that we release the regions on the success path.
regards,
dan carpenter
> - return 0;
> + return ret;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [alsa-devel] [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
2020-02-08 22:07 [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs Colin King
2020-02-09 15:34 ` Cezary Rojewski
2020-02-10 8:49 ` Dan Carpenter
@ 2020-02-10 14:09 ` Pierre-Louis Bossart
2 siblings, 0 replies; 4+ messages in thread
From: Pierre-Louis Bossart @ 2020-02-10 14:09 UTC (permalink / raw)
To: Colin King, Cezary Rojewski, Liam Girdwood, Jie Yang, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Vinod Koul, Subhransu S . Prusty,
alsa-devel
Cc: kernel-janitors, linux-kernel
On 2/8/20 4:07 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function sst_platform_get_resources always returns zero and
> error return codes set by the function are never returned. Fix this
> by returning the error return code in variable ret rather than the
> hard coded zero.
>
> Addresses-Coverity: ("Unused value")
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Yes, it's clearly bad.
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
I don't think this impacts anyone though, the code can only be used for
Merrifield/Tangier.
> ---
> sound/soc/intel/atom/sst/sst_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
> index d952719bc098..5862fe968083 100644
> --- a/sound/soc/intel/atom/sst/sst_pci.c
> +++ b/sound/soc/intel/atom/sst/sst_pci.c
> @@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
> do_release_regions:
> pci_release_regions(pci);
> - return 0;
> + return ret;
> }
>
> /*
>
^ permalink raw reply [flat|nested] 4+ messages in thread