* linux-next: build failure after merge of the ieee1394 tree
@ 2024-02-02 0:16 Stephen Rothwell
2024-02-02 1:04 ` Takashi Sakamoto
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2024-02-02 0:16 UTC (permalink / raw)
To: Takashi Sakamoto
Cc: Li Zhijian, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
Hi all,
After merging the ieee1394 tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/firewire/core-device.c: In function 'show_text_leaf':
drivers/firewire/core-device.c:369:48: error: 'bufsize' undeclared (first use in this function); did you mean 'ksize'?
369 | bufsize);
| ^~~~~~~
| ksize
Caused by commit
67a5a58c0443 ("firewire: Kill unnecessary buf check in device_attribute.show")
interacting with commit
47dc55181dcb ("firewire: core: search descriptor leaf just after vendor directory entry in root directory")
from Linus' tree (v6.8-rc2 - that the ieee1394 tree has just been rebased on
top of). I have dropped the ieee1394 tree for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the ieee1394 tree
2024-02-02 0:16 linux-next: build failure after merge of the ieee1394 tree Stephen Rothwell
@ 2024-02-02 1:04 ` Takashi Sakamoto
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Sakamoto @ 2024-02-02 1:04 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Li Zhijian, Linux Kernel Mailing List, Linux Next Mailing List
Hi Stephen,
I'm sorry for the build failure. Indeed, It is my fault to merge
some fixes for v3.8-rc3 ahead. (I just checked merge conflict
between the issued commits...)
However, I'm out until next Tuesday. Let you cancel merging
ieee1394 tree in the next few days. I'm sorry to trouble you...
On Fri, Feb 2, 2024, at 09:16, Stephen Rothwell wrote:
> Hi all,
>
> After merging the ieee1394 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/firewire/core-device.c: In function 'show_text_leaf':
> drivers/firewire/core-device.c:369:48: error: 'bufsize' undeclared
> (first use in this function); did you mean 'ksize'?
> 369 | bufsize);
> | ^~~~~~~
> | ksize
>
> Caused by commit
>
> 67a5a58c0443 ("firewire: Kill unnecessary buf check in device_attribute.show")
>
> interacting with commit
>
> 47dc55181dcb ("firewire: core: search descriptor leaf just after
> vendor directory entry in root directory")
>
> from Linus' tree (v6.8-rc2 - that the ieee1394 tree has just been rebased on
> top of). I have dropped the ieee1394 tree for today.
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the ieee1394 tree
2023-05-30 2:24 Stephen Rothwell
@ 2023-05-30 10:44 ` Takashi Sakamoto
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Sakamoto @ 2023-05-30 10:44 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
Hi Stephen,
On Tue, May 30, 2023 at 12:24:50PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the ieee1394 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/firewire/firewire-uapi-test.o
>
> Caused by commit
>
> dc7c51638f46 ("firewire: add KUnit test to check layout of UAPI structures")
>
> I have used the ieee1394 tree from next-20230525 for today.
>
> --
> Cheers,
> Stephen Rothwell
Indeed. I overlooked that the code can be configured for tristate.
I posted a patch to fix it and applied it to my for-next branch.
* https://git.kernel.org/ieee1394/linux1394/c/e003498ec055
I'm sorry to interrupt your work flow.
Thanks
Takashi Sakamoto
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build failure after merge of the ieee1394 tree
@ 2023-05-30 2:24 Stephen Rothwell
2023-05-30 10:44 ` Takashi Sakamoto
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2023-05-30 2:24 UTC (permalink / raw)
To: Takashi Sakamoto; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
Hi all,
After merging the ieee1394 tree, today's linux-next build (x86_64
allmodconfig) failed like this:
ERROR: modpost: missing MODULE_LICENSE() in drivers/firewire/firewire-uapi-test.o
Caused by commit
dc7c51638f46 ("firewire: add KUnit test to check layout of UAPI structures")
I have used the ieee1394 tree from next-20230525 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the ieee1394 tree
2010-07-27 1:48 Stephen Rothwell
@ 2010-07-27 8:07 ` Stefan Richter
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Richter @ 2010-07-27 8:07 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux1394-devel, linux-next, linux-kernel
Stephen Rothwell wrote:
> After merging the ieee1394 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/firewire/nosy.c: In function 'packet_buffer_get':
> drivers/firewire/nosy.c:154: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
> drivers/firewire/nosy.c:154: error: implicit declaration of function 'signal_pending'
> drivers/firewire/nosy.c:154: error: implicit declaration of function 'schedule'
> drivers/firewire/nosy.c: In function 'packet_buffer_put':
> drivers/firewire/nosy.c:221: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
> drivers/firewire/nosy.c: In function 'remove_card':
> drivers/firewire/nosy.c:514: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
>
> Forgot to include something?
>
> I have used the ieee1394 tree from next-20100726 for today.
Oh right. Every user of <linux/wait.h> must also include
<linux/sched.h>, unfortunately. I saw the same problem months ago with
another driver, I wonder why I did not catch it this time.
I will fix it later today. This code is in a topic branch for a new
driver; I will rewrite that branch to stay fully bisectable.
--
Stefan Richter
-=====-==-=- -=== ==-==
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build failure after merge of the ieee1394 tree
@ 2010-07-27 1:48 Stephen Rothwell
2010-07-27 8:07 ` Stefan Richter
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2010-07-27 1:48 UTC (permalink / raw)
To: Stefan Richter, linux1394-devel; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
Hi all,
After merging the ieee1394 tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/firewire/nosy.c: In function 'packet_buffer_get':
drivers/firewire/nosy.c:154: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
drivers/firewire/nosy.c:154: error: implicit declaration of function 'signal_pending'
drivers/firewire/nosy.c:154: error: implicit declaration of function 'schedule'
drivers/firewire/nosy.c: In function 'packet_buffer_put':
drivers/firewire/nosy.c:221: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
drivers/firewire/nosy.c: In function 'remove_card':
drivers/firewire/nosy.c:514: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
Forgot to include something?
I have used the ieee1394 tree from next-20100726 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-02 1:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-02 0:16 linux-next: build failure after merge of the ieee1394 tree Stephen Rothwell
2024-02-02 1:04 ` Takashi Sakamoto
-- strict thread matches above, loose matches on Subject: below --
2023-05-30 2:24 Stephen Rothwell
2023-05-30 10:44 ` Takashi Sakamoto
2010-07-27 1:48 Stephen Rothwell
2010-07-27 8:07 ` Stefan Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).