linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] average: Clarify the restrictions
@ 2022-06-01  7:19 Jui-Tse Huang
  2022-06-01 15:58 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Jui-Tse Huang @ 2022-06-01  7:19 UTC (permalink / raw)
  To: linux-kernel
  Cc: Jui-Tse Huang, Mark Rutland, Johannes Berg, Bruno Randolf,
	Ching-Chun Huang

There is several restrictions in the EWMA helper macro that the
developers should take care of, but the comment does not mentioned yet,
thus, this patch clarify the restrictions.

Signed-off-by: Jui-Tse Huang <juitse.huang@gmail.com>
---

Notes:
    v2: fix spelling and wording (Bruno Randolf)

 include/linux/average.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/average.h b/include/linux/average.h
index a1a8f09631ce..ff0953ba2820 100644
--- a/include/linux/average.h
+++ b/include/linux/average.h
@@ -13,6 +13,9 @@
  * precision and fall-off coefficient determined at compile-time
  * and built into the generated helper funtions.
  *
+ * This implementation supports up to 30 bits of precition, and only
+ * the API for fetching non-fractional part is provided for now.
+ *
  * The first argument to the macro is the name that will be used
  * for the struct and helper functions.
  *
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] average: Clarify the restrictions
  2022-06-01  7:19 [PATCH v2] average: Clarify the restrictions Jui-Tse Huang
@ 2022-06-01 15:58 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2022-06-01 15:58 UTC (permalink / raw)
  To: Jui-Tse Huang, linux-kernel
  Cc: Mark Rutland, Johannes Berg, Bruno Randolf, Ching-Chun Huang



On 6/1/22 00:19, Jui-Tse Huang wrote:
> There is several restrictions in the EWMA helper macro that the
> developers should take care of, but the comment does not mentioned yet,
> thus, this patch clarify the restrictions.
> 
> Signed-off-by: Jui-Tse Huang <juitse.huang@gmail.com>
> ---
> 
> Notes:
>     v2: fix spelling and wording (Bruno Randolf)
> 
>  include/linux/average.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/average.h b/include/linux/average.h
> index a1a8f09631ce..ff0953ba2820 100644
> --- a/include/linux/average.h
> +++ b/include/linux/average.h
> @@ -13,6 +13,9 @@
>   * precision and fall-off coefficient determined at compile-time
>   * and built into the generated helper funtions.

                                          functions.
>   *
> + * This implementation supports up to 30 bits of precition, and only

                                                    precision,

> + * the API for fetching non-fractional part is provided for now.
> + *
>   * The first argument to the macro is the name that will be used
>   * for the struct and helper functions.
>   *

-- 
~Randy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-01 15:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-01  7:19 [PATCH v2] average: Clarify the restrictions Jui-Tse Huang
2022-06-01 15:58 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).