* [PATCH] get_maintainer: Remove uses of P: for maintainer name
@ 2020-02-06 3:22 Joe Perches
2020-02-06 4:14 ` Dan Williams
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2020-02-06 3:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: Dan Williams, LKML
commit 1ca84ed6425f ("MAINTAINERS: Reclaim the P: tag for
Maintainer Entry Profile") changed the use of the "P:" tag
from "Person" to "Profile (ie: special subsystem coding styles
and characteristics)"
Change how get_maintainer.pl parses the "P:" tag to match.
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/get_maintainer.pl | 24 ------------------------
1 file changed, 24 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 34085d..a00156 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1341,35 +1341,11 @@ sub add_categories {
}
}
} elsif ($ptype eq "M") {
- my ($name, $address) = parse_email($pvalue);
- if ($name eq "") {
- if ($i > 0) {
- my $tv = $typevalue[$i - 1];
- if ($tv =~ m/^([A-Z]):\s*(.*)/) {
- if ($1 eq "P") {
- $name = $2;
- $pvalue = format_email($name, $address, $email_usename);
- }
- }
- }
- }
if ($email_maintainer) {
my $role = get_maintainer_role($i);
push_email_addresses($pvalue, $role);
}
} elsif ($ptype eq "R") {
- my ($name, $address) = parse_email($pvalue);
- if ($name eq "") {
- if ($i > 0) {
- my $tv = $typevalue[$i - 1];
- if ($tv =~ m/^([A-Z]):\s*(.*)/) {
- if ($1 eq "P") {
- $name = $2;
- $pvalue = format_email($name, $address, $email_usename);
- }
- }
- }
- }
if ($email_reviewer) {
my $subsystem = get_subsystem_name($i);
push_email_addresses($pvalue, "reviewer:$subsystem");
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] get_maintainer: Remove uses of P: for maintainer name
2020-02-06 3:22 [PATCH] get_maintainer: Remove uses of P: for maintainer name Joe Perches
@ 2020-02-06 4:14 ` Dan Williams
2020-02-06 6:47 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Dan Williams @ 2020-02-06 4:14 UTC (permalink / raw)
To: Joe Perches; +Cc: Andrew Morton, LKML
On Wed, Feb 5, 2020 at 7:23 PM Joe Perches <joe@perches.com> wrote:
>
> commit 1ca84ed6425f ("MAINTAINERS: Reclaim the P: tag for
> Maintainer Entry Profile") changed the use of the "P:" tag
> from "Person" to "Profile (ie: special subsystem coding styles
> and characteristics)"
>
> Change how get_maintainer.pl parses the "P:" tag to match.
Looks ok to me:
Acked-by: Dan Williams <dan.j.william@intel.com>
...although I was not able to trigger any unexpected results running
against drivers/nvdimm/.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] get_maintainer: Remove uses of P: for maintainer name
2020-02-06 4:14 ` Dan Williams
@ 2020-02-06 6:47 ` Joe Perches
0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2020-02-06 6:47 UTC (permalink / raw)
To: Dan Williams; +Cc: Andrew Morton, LKML
On Wed, 2020-02-05 at 20:14 -0800, Dan Williams wrote:
> On Wed, Feb 5, 2020 at 7:23 PM Joe Perches <joe@perches.com> wrote:
> > commit 1ca84ed6425f ("MAINTAINERS: Reclaim the P: tag for
> > Maintainer Entry Profile") changed the use of the "P:" tag
> > from "Person" to "Profile (ie: special subsystem coding styles
> > and characteristics)"
> >
> > Change how get_maintainer.pl parses the "P:" tag to match.
>
> Looks ok to me:
>
> Acked-by: Dan Williams <dan.j.william@intel.com>
>
> ...although I was not able to trigger any unexpected results running
> against drivers/nvdimm/.
Because there aren't any entries like
P: First Last
M: maintainer@domain.tld
where the name was a P: entry and the
email address was on the next line.
That was the form before 2009, but there
were still a few entries until you changed
them recently.
A long time ago:
commit 8b58be884a9fd650abb7f7adf3f885fb9cecd79d
Author: Joe Perches <joe@perches.com>
Date: Wed Jul 29 15:04:30 2009 -0700
MAINTAINERS: coalesce name and email address lines
Switch the MAINTAINERS email address format from
P: Linus Torvalds
M: torvalds@linux-foundation.org
to
M: Linus Torvalds <torvalds@linux-foundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-06 6:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-06 3:22 [PATCH] get_maintainer: Remove uses of P: for maintainer name Joe Perches
2020-02-06 4:14 ` Dan Williams
2020-02-06 6:47 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).