From: Sergei Shtepa <sergei.shtepa@veeam.com>
To: Hillf Danton <hdanton@sina.com>
Cc: <axboe@kernel.dk>, <corbet@lwn.net>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 18/21] block, blksnap: snapshot
Date: Mon, 2 Jan 2023 10:58:38 +0100 [thread overview]
Message-ID: <974ffb8c-8623-d249-f69f-ac5cfd498950@veeam.com> (raw)
In-Reply-To: <20230101110542.3395-1-hdanton@sina.com>
On 1/1/23 12:05, Hillf Danton wrote:
> Subject:
> Re: [PATCH v2 18/21] block, blksnap: snapshot
> From:
> Hillf Danton <hdanton@sina.com>
> Date:
> 1/1/23, 12:05
>
> To:
> Sergei Shtepa <sergei.shtepa@veeam.com>
> CC:
> axboe@kernel.dk, corbet@lwn.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org
>
>
> On 9 Dec 2022 15:23:28 +0100 Sergei Shtepa <sergei.shtepa@veeam.com>
>> +int snapshot_create(struct blk_snap_dev *dev_id_array, unsigned int count,
>> + uuid_t *id)
>> +{
>> + struct snapshot *snapshot = NULL;
>> + int ret;
>> + unsigned int inx;
>> +
>> + pr_info("Create snapshot for devices:\n");
>> + for (inx = 0; inx < count; ++inx)
>> + pr_info("\t%u:%u\n", dev_id_array[inx].mj,
>> + dev_id_array[inx].mn);
>> +
>> + ret = check_same_devices(dev_id_array, count);
>> + if (ret)
>> + return ret;
>> +
>> + snapshot = snapshot_new(count);
>> + if (IS_ERR(snapshot)) {
>> + pr_err("Unable to create snapshot: failed to allocate snapshot structure\n");
>> + return PTR_ERR(snapshot);
>> + }
>> +
>> + ret = -ENODEV;
>> + for (inx = 0; inx < count; ++inx) {
>> + dev_t dev_id =
>> + MKDEV(dev_id_array[inx].mj, dev_id_array[inx].mn);
>> + struct tracker *tracker;
>> +
>> + tracker = tracker_create_or_get(dev_id);
>> + if (IS_ERR(tracker)) {
>> + pr_err("Unable to create snapshot\n");
>> + pr_err("Failed to add device [%u:%u] to snapshot tracking\n",
>> + MAJOR(dev_id), MINOR(dev_id));
>> + ret = PTR_ERR(tracker);
>> + goto fail;
>> + }
>> +
>> + snapshot->tracker_array[inx] = tracker;
>> + snapshot->count++;
>> + }
>> +
>> + down_write(&snapshots_lock);
>> + list_add_tail(&snapshots, &snapshot->link);
>> + up_write(&snapshots_lock);
> Given list_for_each_entry below, typo wrt &snapshots found in the fresh 2023?
>
Thanks.
It seems I just swapped the parameters by mistake.
It should be better:
```
down_write(&snapshots_lock);
list_add_tail(&snapshot->link, &snapshots);
up_write(&snapshots_lock);
```
>> +
>> + uuid_copy(id, &snapshot->id);
>> + pr_info("Snapshot %pUb was created\n", &snapshot->id);
>> + return 0;
>> +fail:
>> + pr_err("Snapshot cannot be created\n");
>> +
>> + snapshot_put(snapshot);
>> + return ret;
>> +}
>> +
>> +static struct snapshot *snapshot_get_by_id(uuid_t *id)
>> +{
>> + struct snapshot *snapshot = NULL;
>> + struct snapshot *s;
>> +
>> + down_read(&snapshots_lock);
>> + if (list_empty(&snapshots))
>> + goto out;
>> +
>> + list_for_each_entry(s, &snapshots, link) {
>> + if (uuid_equal(&s->id, id)) {
>> + snapshot = s;
>> + snapshot_get(snapshot);
>> + break;
>> + }
>> + }
>> +out:
>> + up_read(&snapshots_lock);
>> + return snapshot;
>> +}
next prev parent reply other threads:[~2023-01-02 9:58 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 14:23 [PATCH v2 00/21] blksnap - block devices snapshots module Sergei Shtepa
2022-12-09 14:23 ` [PATCH v2 01/21] documentation, blkfilter: Block Device Filtering Mechanism Sergei Shtepa
2022-12-10 4:15 ` Bagas Sanjaya
2022-12-09 14:23 ` [PATCH v2 02/21] block, " Sergei Shtepa
2022-12-15 9:26 ` Christoph Hellwig
2022-12-15 10:46 ` Sergei Shtepa
2022-12-16 7:04 ` Christoph Hellwig
2023-01-31 23:58 ` Mike Snitzer
2023-02-01 11:09 ` Fabio Fantoni
2023-02-01 13:16 ` Sergei Shtepa
2022-12-09 14:23 ` [PATCH v2 03/21] documentation, capability: fix Generic Block Device Capability Sergei Shtepa
2022-12-13 12:13 ` Fabio Fantoni
2022-12-30 15:35 ` Fabio Fantoni
2022-12-09 14:23 ` [PATCH v2 04/21] documentation, blksnap: Block Devices Snapshots Module Sergei Shtepa
2022-12-10 3:50 ` Bagas Sanjaya
2022-12-09 14:23 ` [PATCH v2 05/21] block, blksnap: header file of the module interface Sergei Shtepa
2022-12-09 22:13 ` kernel test robot
2022-12-09 23:14 ` kernel test robot
2022-12-09 14:23 ` [PATCH v2 06/21] block, blksnap: module management interface functions Sergei Shtepa
2022-12-15 9:28 ` Christoph Hellwig
[not found] ` <CGME20230103153406eucas1p205c48bd767e6a86f6f1121db7eb5fc19@eucas1p2.samsung.com>
2023-01-03 15:26 ` Pankaj Raghav
2022-12-09 14:23 ` [PATCH v2 07/21] block, blksnap: init() and exit() functions Sergei Shtepa
2022-12-15 9:30 ` Christoph Hellwig
2022-12-09 14:23 ` [PATCH v2 08/21] block, blksnap: interaction with sysfs Sergei Shtepa
2022-12-09 14:23 ` [PATCH v2 09/21] block, blksnap: attaching and detaching the filter and handling I/O units Sergei Shtepa
2022-12-15 10:01 ` Christoph Hellwig
2022-12-09 14:23 ` [PATCH v2 10/21] block, blksnap: map of change block tracking Sergei Shtepa
2022-12-09 14:23 ` [PATCH v2 11/21] block, blksnap: minimum data storage unit of the original block device Sergei Shtepa
2022-12-09 14:23 ` [PATCH v2 12/21] block, blksnap: buffer in memory for the minimum data storage unit Sergei Shtepa
2022-12-09 14:23 ` [PATCH v2 13/21] block, blksnap: functions and structures for performing block I/O operations Sergei Shtepa
2022-12-15 10:06 ` Christoph Hellwig
2022-12-09 14:23 ` [PATCH v2 14/21] block, blksnap: storage for storing difference blocks Sergei Shtepa
2022-12-09 14:23 ` [PATCH v2 15/21] block, blksnap: event queue from the difference storage Sergei Shtepa
2022-12-09 14:23 ` [PATCH v2 16/21] block, blksnap: owner of information about overwritten blocks of the original block device Sergei Shtepa
2022-12-09 14:23 ` [PATCH v2 17/21] block, blksnap: snapshot image " Sergei Shtepa
2022-12-15 9:45 ` Christoph Hellwig
2022-12-09 14:23 ` [PATCH v2 18/21] block, blksnap: snapshot Sergei Shtepa
2022-12-09 14:23 ` [PATCH v2 19/21] block, blksnap: Kconfig and Makefile Sergei Shtepa
2022-12-09 14:23 ` [PATCH v2 20/21] block, blksnap: adds a blksnap to the kernel tree Sergei Shtepa
2022-12-09 21:53 ` kernel test robot
2022-12-09 14:23 ` [PATCH v2 21/21] block, blksnap: adds a maintainer for new files Sergei Shtepa
2022-12-10 3:23 ` [PATCH v2 00/21] blksnap - block devices snapshots module Bagas Sanjaya
2022-12-10 22:57 ` Sergei Shtepa
[not found] ` <20230101071813.3329-1-hdanton@sina.com>
2023-01-02 9:44 ` [PATCH v2 17/21] block, blksnap: snapshot image block device Sergei Shtepa
[not found] ` <20230101110542.3395-1-hdanton@sina.com>
2023-01-02 9:58 ` Sergei Shtepa [this message]
2023-01-17 21:04 ` [PATCH v2 00/21] blksnap - block devices snapshots module Mike Snitzer
2023-01-18 10:51 ` Hannes Reinecke
2023-01-24 11:34 ` Sergei Shtepa
2023-01-31 20:47 ` Mike Snitzer
2023-02-01 2:32 ` Mason Giles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=974ffb8c-8623-d249-f69f-ac5cfd498950@veeam.com \
--to=sergei.shtepa@veeam.com \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).