* Build warning on 32-bit PPC - bisected to commit 989cea5c14be
@ 2016-12-21 19:49 Larry Finger
2016-12-22 2:02 ` Nicholas Piggin
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2016-12-21 19:49 UTC (permalink / raw)
To: Nicholas Piggin, Russell King, Michal Marek; +Cc: LKML
I am getting the following warning when I build kernel 4.9-git on my PowerBook
G4 with a 32-bit PPC processor:
AS arch/powerpc/kernel/misc_32.o
arch/powerpc/kernel/misc_32.S:299:7: warning: "CONFIG_FSL_BOOKE" is not defined
[-Wundef]
This problem has been bisected to commit 989cea5c14be ("kbuild: prevent
lib-ksyms.o rebuilds").
Thanks,
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Build warning on 32-bit PPC - bisected to commit 989cea5c14be
2016-12-21 19:49 Build warning on 32-bit PPC - bisected to commit 989cea5c14be Larry Finger
@ 2016-12-22 2:02 ` Nicholas Piggin
2016-12-22 14:53 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Piggin @ 2016-12-22 2:02 UTC (permalink / raw)
To: Larry Finger; +Cc: Russell King, Michal Marek, LKML, linuxppc-dev
On Wed, 21 Dec 2016 13:49:07 -0600
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> I am getting the following warning when I build kernel 4.9-git on my PowerBook
> G4 with a 32-bit PPC processor:
>
> AS arch/powerpc/kernel/misc_32.o
> arch/powerpc/kernel/misc_32.S:299:7: warning: "CONFIG_FSL_BOOKE" is not defined
> [-Wundef]
>
> This problem has been bisected to commit 989cea5c14be ("kbuild: prevent
> lib-ksyms.o rebuilds").
>
> Thanks,
>
> Larry
Hi Larry,
This is strange you've bisected it there, I can't see how that patch would
trigger it. That said, powerpc has had a few small build system glitches.
It looks like this warning could be fixed by changing #elif CONFIG_FSL_BOOKE
to #elif defined (CONFIG_FSL_BOOKE). Want to send a patch (if it works)?
Thanks,
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Build warning on 32-bit PPC - bisected to commit 989cea5c14be
2016-12-22 2:02 ` Nicholas Piggin
@ 2016-12-22 14:53 ` Larry Finger
0 siblings, 0 replies; 3+ messages in thread
From: Larry Finger @ 2016-12-22 14:53 UTC (permalink / raw)
To: Nicholas Piggin; +Cc: Russell King, Michal Marek, LKML, linuxppc-dev
On 12/21/2016 08:02 PM, Nicholas Piggin wrote:
> Hi Larry,
>
> This is strange you've bisected it there, I can't see how that patch would
> trigger it. That said, powerpc has had a few small build system glitches.
>
> It looks like this warning could be fixed by changing #elif CONFIG_FSL_BOOKE
> to #elif defined (CONFIG_FSL_BOOKE). Want to send a patch (if it works)?
Nick,
I agree that the "bad" commit does not look likely to be the problem, but I
verified it by checking out the previous commit, which does not show the
problem. I'm quite sure that PowerPC has a lot of quirks and glitches beyond
those caused by the Apple hardware.
I have tested the change and I will submit the patch.
Thanks,
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-22 14:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-21 19:49 Build warning on 32-bit PPC - bisected to commit 989cea5c14be Larry Finger
2016-12-22 2:02 ` Nicholas Piggin
2016-12-22 14:53 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).