* Re: [1/2] bcma: fix building without OF_IRQ
[not found] <20160323155243.D1AB4615C6@smtp.codeaurora.org>
@ 2016-03-24 13:19 ` Arnd Bergmann
2016-03-24 13:53 ` Kalle Valo
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2016-03-24 13:19 UTC (permalink / raw)
To: Kalle Valo
Cc: Rafał Miłecki, Hauke Mehrtens, linux-wireless, linux-kernel
On Wednesday 23 March 2016 15:52:43 Kalle Valo wrote:
> > The bcma driver core can be built with or without DT support, but
> > it fails to build when CONFIG_OF=y and CONFIG_OF_IRQ=n, which
> > can happen on platforms that do not support IRQ domains.
> >
> > ERROR: "irq_create_of_mapping" [drivers/bcma/bcma.ko] undefined!
> > ERROR: "of_irq_parse_raw" [drivers/bcma/bcma.ko] undefined!
> > ERROR: "of_irq_parse_one" [drivers/bcma/bcma.ko] undefined!
> >
> > This adds another compile-time check for OF_IRQ, but also
> > gets rid of now unneeded #ifdef checks: Using the simpler
> > IS_ENABLED() check for OF_IRQ also covers the case of not
> > having CONFIG_OF enabled. The check for CONFIG_OF_ADDRESS
> > was added to allow building on architectures without
> > OF_ADDRESS, but that has been addressed already in
> > b1d06b60e90c ("of: Provide static inline function for
> > of_translate_address if needed").
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks, applied to wireless-drivers.git.
>
Thanks! I see you have applied patch 1/2 but not patch 2/2.
As mentioned in the comment for patch 2, it should be tested
better, but I want to make sure that someone still has it
on their radar.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [1/2] bcma: fix building without OF_IRQ
2016-03-24 13:19 ` [1/2] bcma: fix building without OF_IRQ Arnd Bergmann
@ 2016-03-24 13:53 ` Kalle Valo
2016-03-24 14:05 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2016-03-24 13:53 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Rafał Miłecki, Hauke Mehrtens, linux-wireless, linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> On Wednesday 23 March 2016 15:52:43 Kalle Valo wrote:
>> > The bcma driver core can be built with or without DT support, but
>> > it fails to build when CONFIG_OF=y and CONFIG_OF_IRQ=n, which
>> > can happen on platforms that do not support IRQ domains.
>> >
>> > ERROR: "irq_create_of_mapping" [drivers/bcma/bcma.ko] undefined!
>> > ERROR: "of_irq_parse_raw" [drivers/bcma/bcma.ko] undefined!
>> > ERROR: "of_irq_parse_one" [drivers/bcma/bcma.ko] undefined!
>> >
>> > This adds another compile-time check for OF_IRQ, but also
>> > gets rid of now unneeded #ifdef checks: Using the simpler
>> > IS_ENABLED() check for OF_IRQ also covers the case of not
>> > having CONFIG_OF enabled. The check for CONFIG_OF_ADDRESS
>> > was added to allow building on architectures without
>> > OF_ADDRESS, but that has been addressed already in
>> > b1d06b60e90c ("of: Provide static inline function for
>> > of_translate_address if needed").
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Thanks, applied to wireless-drivers.git.
>>
>
> Thanks! I see you have applied patch 1/2 but not patch 2/2.
>
> As mentioned in the comment for patch 2, it should be tested
> better, but I want to make sure that someone still has it
> on their radar.
Just to avoid any confusions I assume you are talking about this patch:
[v2] bcma: use of_dma_configure() to set initial dma mask
https://patchwork.kernel.org/patch/8608751/
It's on my patchwork queue and I'm planning to apply it to
wireless-drivers-next once it opens again. But I'm not able to test the
patch myself, I hope someone else could do it.
--
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [1/2] bcma: fix building without OF_IRQ
2016-03-24 13:53 ` Kalle Valo
@ 2016-03-24 14:05 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-03-24 14:05 UTC (permalink / raw)
To: Kalle Valo
Cc: Rafał Miłecki, Hauke Mehrtens, linux-wireless, linux-kernel
On Thursday 24 March 2016 15:53:14 Kalle Valo wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > On Wednesday 23 March 2016 15:52:43 Kalle Valo wrote:
> >> > The bcma driver core can be built with or without DT support, but
> >> > it fails to build when CONFIG_OF=y and CONFIG_OF_IRQ=n, which
> >> > can happen on platforms that do not support IRQ domains.
> >> >
> >> > ERROR: "irq_create_of_mapping" [drivers/bcma/bcma.ko] undefined!
> >> > ERROR: "of_irq_parse_raw" [drivers/bcma/bcma.ko] undefined!
> >> > ERROR: "of_irq_parse_one" [drivers/bcma/bcma.ko] undefined!
> >> >
> >> > This adds another compile-time check for OF_IRQ, but also
> >> > gets rid of now unneeded #ifdef checks: Using the simpler
> >> > IS_ENABLED() check for OF_IRQ also covers the case of not
> >> > having CONFIG_OF enabled. The check for CONFIG_OF_ADDRESS
> >> > was added to allow building on architectures without
> >> > OF_ADDRESS, but that has been addressed already in
> >> > b1d06b60e90c ("of: Provide static inline function for
> >> > of_translate_address if needed").
> >> >
> >> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >>
> >> Thanks, applied to wireless-drivers.git.
> >>
> >
> > Thanks! I see you have applied patch 1/2 but not patch 2/2.
> >
> > As mentioned in the comment for patch 2, it should be tested
> > better, but I want to make sure that someone still has it
> > on their radar.
>
> Just to avoid any confusions I assume you are talking about this patch:
>
> [v2] bcma: use of_dma_configure() to set initial dma mask
> https://patchwork.kernel.org/patch/8608751/
Correct.
> It's on my patchwork queue and I'm planning to apply it to
> wireless-drivers-next once it opens again.
Ok, sounds good.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [1/2] bcma: fix building without OF_IRQ
2016-03-17 9:20 [PATCH 1/2] " Arnd Bergmann
@ 2016-03-23 15:52 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2016-03-23 15:52 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Rafał Miłecki, Arnd Bergmann, Hauke Mehrtens,
linux-wireless, linux-kernel
> The bcma driver core can be built with or without DT support, but
> it fails to build when CONFIG_OF=y and CONFIG_OF_IRQ=n, which
> can happen on platforms that do not support IRQ domains.
>
> ERROR: "irq_create_of_mapping" [drivers/bcma/bcma.ko] undefined!
> ERROR: "of_irq_parse_raw" [drivers/bcma/bcma.ko] undefined!
> ERROR: "of_irq_parse_one" [drivers/bcma/bcma.ko] undefined!
>
> This adds another compile-time check for OF_IRQ, but also
> gets rid of now unneeded #ifdef checks: Using the simpler
> IS_ENABLED() check for OF_IRQ also covers the case of not
> having CONFIG_OF enabled. The check for CONFIG_OF_ADDRESS
> was added to allow building on architectures without
> OF_ADDRESS, but that has been addressed already in
> b1d06b60e90c ("of: Provide static inline function for
> of_translate_address if needed").
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applied to wireless-drivers.git.
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-24 14:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20160323155243.D1AB4615C6@smtp.codeaurora.org>
2016-03-24 13:19 ` [1/2] bcma: fix building without OF_IRQ Arnd Bergmann
2016-03-24 13:53 ` Kalle Valo
2016-03-24 14:05 ` Arnd Bergmann
2016-03-17 9:20 [PATCH 1/2] " Arnd Bergmann
2016-03-23 15:52 ` [1/2] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).