* [PATCH 0/3] staging: rtl8723bs: remove MGS_8192C trace logs
@ 2021-04-09 12:40 Fabio Aiuto
2021-04-09 12:40 ` [PATCH 1/3] staging: rtl8723bs: remove all MSG_8192C logs Fabio Aiuto
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabio Aiuto @ 2021-04-09 12:40 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto
This patchset removes the tracing private macro MSG_8192C.
This macro belongs to a redundant driver specific tracing
macro family.
Moreover the default behaviour is _do nothing_ as to
activate it, it's necessary to hardcode a DEBUG symbol
definition.
Fabio Aiuto (3):
staging: rtl8723bs: remove all MSG_8192C logs
staging: rtl8723bs: remove commented out MSG_8192C log
staging: rtl8723bs: remove MSG_8192C macro definitions
drivers/staging/rtl8723bs/hal/odm.c | 3 ---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ----
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ----
drivers/staging/rtl8723bs/include/rtw_debug.h | 6 ------
4 files changed, 17 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] staging: rtl8723bs: remove all MSG_8192C logs
2021-04-09 12:40 [PATCH 0/3] staging: rtl8723bs: remove MGS_8192C trace logs Fabio Aiuto
@ 2021-04-09 12:40 ` Fabio Aiuto
2021-04-09 12:40 ` [PATCH 2/3] staging: rtl8723bs: remove commented out MSG_8192C log Fabio Aiuto
2021-04-09 12:40 ` [PATCH 3/3] staging: rtl8723bs: remove MSG_8192C macro definitions Fabio Aiuto
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Aiuto @ 2021-04-09 12:40 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto
remove all MSG_8192C logs.
MSG_8192C is a private trace mechanism macro and is deactivated.
(i.e. the default behaviour is _do nothing_)
The only way to activate it is to manually define a debug
symbol.
So just remove it.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ----
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ----
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index e31ad3feed62..dcb7cb131432 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -1787,8 +1787,6 @@ static struct hal_version ReadChipVersion8723B(struct adapter *padapter)
else
pHalData->rf_type = RF_1T1R;
- MSG_8192C("RF_Type is %x!!\n", pHalData->rf_type);
-
return ChipVersion;
}
@@ -2139,8 +2137,6 @@ u8 GetEEPROMSize8723B(struct adapter *padapter)
/* 6: EEPROM used is 93C46, 4: boot from E-Fuse. */
size = (cr & BOOT_FROM_EEPROM) ? 6 : 4;
- MSG_8192C("EEPROM type is %s\n", size == 4 ? "E-FUSE" : "93C46");
-
return size;
}
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 0251ddafe605..989f6974c817 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -1175,7 +1175,6 @@ static s32 _ReadAdapterInfo8723BS(struct adapter *padapter)
val8 = rtw_read8(padapter, 0x4e);
- MSG_8192C("%s, 0x4e = 0x%x\n", __func__, val8);
val8 |= BIT(6);
rtw_write8(padapter, 0x4e, val8);
@@ -1192,9 +1191,6 @@ static s32 _ReadAdapterInfo8723BS(struct adapter *padapter)
CardDisableRTL8723BSdio(padapter);/* for the power consumption issue, wifi ko module is loaded during booting, but wifi GUI is off */
}
-
- MSG_8192C("<==== _ReadAdapterInfo8723BS in %d ms\n", jiffies_to_msecs(jiffies - start));
-
return _SUCCESS;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] staging: rtl8723bs: remove commented out MSG_8192C log
2021-04-09 12:40 [PATCH 0/3] staging: rtl8723bs: remove MGS_8192C trace logs Fabio Aiuto
2021-04-09 12:40 ` [PATCH 1/3] staging: rtl8723bs: remove all MSG_8192C logs Fabio Aiuto
@ 2021-04-09 12:40 ` Fabio Aiuto
2021-04-09 12:40 ` [PATCH 3/3] staging: rtl8723bs: remove MSG_8192C macro definitions Fabio Aiuto
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Aiuto @ 2021-04-09 12:40 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto
remove commented out MSG_8192C log.
MSG_8192C is a private trace mechanism macro and is deactivated.
(i.e. the default behaviour is _do nothing_)
The only way to activate it is to manually define a debug
symbol.
So just remove it.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
drivers/staging/rtl8723bs/hal/odm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723bs/hal/odm.c
index 6f8f38a58237..dea4e3679b8e 100644
--- a/drivers/staging/rtl8723bs/hal/odm.c
+++ b/drivers/staging/rtl8723bs/hal/odm.c
@@ -776,9 +776,6 @@ void odm_TXPowerTrackingInit(struct dm_odm_t *pDM_Odm)
else
pdmpriv->TxPowerTrackControl = false;
-
- /* MSG_8192C("pdmpriv->TxPowerTrackControl = %d\n", pdmpriv->TxPowerTrackControl); */
-
/* pDM_Odm->RFCalibrateInfo.TxPowerTrackControl = true; */
pDM_Odm->RFCalibrateInfo.ThermalValue = pHalData->EEPROMThermalMeter;
pDM_Odm->RFCalibrateInfo.ThermalValue_IQK = pHalData->EEPROMThermalMeter;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] staging: rtl8723bs: remove MSG_8192C macro definitions
2021-04-09 12:40 [PATCH 0/3] staging: rtl8723bs: remove MGS_8192C trace logs Fabio Aiuto
2021-04-09 12:40 ` [PATCH 1/3] staging: rtl8723bs: remove all MSG_8192C logs Fabio Aiuto
2021-04-09 12:40 ` [PATCH 2/3] staging: rtl8723bs: remove commented out MSG_8192C log Fabio Aiuto
@ 2021-04-09 12:40 ` Fabio Aiuto
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Aiuto @ 2021-04-09 12:40 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Fabio Aiuto
remove obsolete MSG_8192C macro definitions.
MSG_8192C is a private trace mechanism macro and is deactivated.
(i.e. the default behaviour is _do nothing_)
The only way to activate it is to manually define a debug
symbol.
So just remove it.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
drivers/staging/rtl8723bs/include/rtw_debug.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/staging/rtl8723bs/include/rtw_debug.h
index 4c159c1a0747..65e1d9bd7099 100644
--- a/drivers/staging/rtl8723bs/include/rtw_debug.h
+++ b/drivers/staging/rtl8723bs/include/rtw_debug.h
@@ -131,7 +131,6 @@
#define _MODULE_DEFINE_ _module_efuse_
#endif
-#define MSG_8192C(x, ...) do {} while (0)
#define DBG_8192C(x, ...) do {} while (0)
#define DBG_871X_LEVEL(x, ...) do {} while (0)
@@ -196,11 +195,6 @@
#ifdef DEBUG
#if defined(_dbgdump)
- #undef MSG_8192C
- #define MSG_8192C(...) do {\
- _dbgdump(DRIVER_PREFIX __VA_ARGS__);\
- } while (0)
-
#undef DBG_8192C
#define DBG_8192C(...) do {\
_dbgdump(DRIVER_PREFIX __VA_ARGS__);\
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-09 12:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 12:40 [PATCH 0/3] staging: rtl8723bs: remove MGS_8192C trace logs Fabio Aiuto
2021-04-09 12:40 ` [PATCH 1/3] staging: rtl8723bs: remove all MSG_8192C logs Fabio Aiuto
2021-04-09 12:40 ` [PATCH 2/3] staging: rtl8723bs: remove commented out MSG_8192C log Fabio Aiuto
2021-04-09 12:40 ` [PATCH 3/3] staging: rtl8723bs: remove MSG_8192C macro definitions Fabio Aiuto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).