* [PATCH 0/2] I2C-Nomadik: Adjustments for nmk_i2c_probe()
@ 2018-02-02 15:38 SF Markus Elfring
2018-02-02 15:39 ` [PATCH 1/2] i2c-nomadik: Delete an error message for a failed memory allocation in nmk_i2c_probe() SF Markus Elfring
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: SF Markus Elfring @ 2018-02-02 15:38 UTC (permalink / raw)
To: linux-i2c, linux-arm-kernel, Linus Walleij, Wolfram Sang
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 16:34:56 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/i2c/busses/i2c-nomadik.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
2.16.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] i2c-nomadik: Delete an error message for a failed memory allocation in nmk_i2c_probe()
2018-02-02 15:38 [PATCH 0/2] I2C-Nomadik: Adjustments for nmk_i2c_probe() SF Markus Elfring
@ 2018-02-02 15:39 ` SF Markus Elfring
2018-02-02 15:40 ` [PATCH 2/2] i2c-nomadik: Improve a size determination " SF Markus Elfring
2018-02-22 12:41 ` [PATCH 0/2] I2C-Nomadik: Adjustments for nmk_i2c_probe() Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: SF Markus Elfring @ 2018-02-02 15:39 UTC (permalink / raw)
To: linux-i2c, linux-arm-kernel, Linus Walleij, Wolfram Sang
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 16:25:14 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/i2c/busses/i2c-nomadik.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index 49c7c0c91486..a783ad25fe19 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -975,7 +975,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
dev = devm_kzalloc(&adev->dev, sizeof(struct nmk_i2c_dev), GFP_KERNEL);
if (!dev) {
- dev_err(&adev->dev, "cannot allocate memory\n");
ret = -ENOMEM;
goto err_no_mem;
}
--
2.16.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] i2c-nomadik: Improve a size determination in nmk_i2c_probe()
2018-02-02 15:38 [PATCH 0/2] I2C-Nomadik: Adjustments for nmk_i2c_probe() SF Markus Elfring
2018-02-02 15:39 ` [PATCH 1/2] i2c-nomadik: Delete an error message for a failed memory allocation in nmk_i2c_probe() SF Markus Elfring
@ 2018-02-02 15:40 ` SF Markus Elfring
2018-02-22 12:41 ` [PATCH 0/2] I2C-Nomadik: Adjustments for nmk_i2c_probe() Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: SF Markus Elfring @ 2018-02-02 15:40 UTC (permalink / raw)
To: linux-i2c, linux-arm-kernel, Linus Walleij, Wolfram Sang
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 16:28:20 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/i2c/busses/i2c-nomadik.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index a783ad25fe19..e353b528140e 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -973,7 +973,7 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
struct i2c_vendor_data *vendor = id->data;
u32 max_fifo_threshold = (vendor->fifodepth / 2) - 1;
- dev = devm_kzalloc(&adev->dev, sizeof(struct nmk_i2c_dev), GFP_KERNEL);
+ dev = devm_kzalloc(&adev->dev, sizeof(*dev), GFP_KERNEL);
if (!dev) {
ret = -ENOMEM;
goto err_no_mem;
--
2.16.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] I2C-Nomadik: Adjustments for nmk_i2c_probe()
2018-02-02 15:38 [PATCH 0/2] I2C-Nomadik: Adjustments for nmk_i2c_probe() SF Markus Elfring
2018-02-02 15:39 ` [PATCH 1/2] i2c-nomadik: Delete an error message for a failed memory allocation in nmk_i2c_probe() SF Markus Elfring
2018-02-02 15:40 ` [PATCH 2/2] i2c-nomadik: Improve a size determination " SF Markus Elfring
@ 2018-02-22 12:41 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2018-02-22 12:41 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-i2c, Linux ARM, Wolfram Sang, LKML, kernel-janitors
On Fri, Feb 2, 2018 at 4:38 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 2 Feb 2018 16:34:56 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (2):
> Delete an error message for a failed memory allocation
> Improve a size determination
Those look OK.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-22 12:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-02 15:38 [PATCH 0/2] I2C-Nomadik: Adjustments for nmk_i2c_probe() SF Markus Elfring
2018-02-02 15:39 ` [PATCH 1/2] i2c-nomadik: Delete an error message for a failed memory allocation in nmk_i2c_probe() SF Markus Elfring
2018-02-02 15:40 ` [PATCH 2/2] i2c-nomadik: Improve a size determination " SF Markus Elfring
2018-02-22 12:41 ` [PATCH 0/2] I2C-Nomadik: Adjustments for nmk_i2c_probe() Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).