From: Randy Dunlap <rdunlap@infradead.org>
To: wonder_rock@126.com, guoren@kernel.org
Cc: axboe@kernel.dk, linux-csky@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] csky: Fixup compile warning
Date: Sun, 13 Feb 2022 08:00:16 -0800 [thread overview]
Message-ID: <98208fa3-4b28-cdeb-7699-dbd9d66bfa60@infradead.org> (raw)
In-Reply-To: <20220213142850.31526-1-wonder_rock@126.com>
Hi,
On 2/13/22 06:28, wonder_rock@126.com wrote:
> From: Deyan Wang <wonder_rock@126.com>
>
> arch/csky/include/asm/io.h: 8 linux/version.h not needed.
> arch/csky/kernel/process.c: 5 linux/version.h not needed.
> arch/csky/mm/dma-mapping.c: 12 linux/version.h not needed.
>
> Signed-off-by: Deyan Wang <wonder_rock@126.com>
The patch makes sense but these are not compile warnings.
They come from scripts/checkversion.pl, which can be called
by 'make versioncheck', so I suppose that something in your
build system is running 'make versioncheck'.
You could just say "csky: fix versioncheck warnings"
> ---
> arch/csky/include/asm/io.h | 1 -
> arch/csky/kernel/process.c | 1 -
> arch/csky/mm/dma-mapping.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/arch/csky/include/asm/io.h b/arch/csky/include/asm/io.h
> index f82654053dc0..ed53f0b47388 100644
> --- a/arch/csky/include/asm/io.h
> +++ b/arch/csky/include/asm/io.h
> @@ -5,7 +5,6 @@
>
> #include <linux/pgtable.h>
> #include <linux/types.h>
> -#include <linux/version.h>
>
> /*
> * I/O memory access primitives. Reads are ordered relative to any
> diff --git a/arch/csky/kernel/process.c b/arch/csky/kernel/process.c
> index 3d0ca22cd0e2..5de04707aa07 100644
> --- a/arch/csky/kernel/process.c
> +++ b/arch/csky/kernel/process.c
> @@ -2,7 +2,6 @@
> // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd.
>
> #include <linux/module.h>
> -#include <linux/version.h>
> #include <linux/sched.h>
> #include <linux/sched/task_stack.h>
> #include <linux/sched/debug.h>
> diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c
> index c3a775a7e8f9..82447029feb4 100644
> --- a/arch/csky/mm/dma-mapping.c
> +++ b/arch/csky/mm/dma-mapping.c
> @@ -9,7 +9,6 @@
> #include <linux/mm.h>
> #include <linux/scatterlist.h>
> #include <linux/types.h>
> -#include <linux/version.h>
> #include <asm/cache.h>
>
> static inline void cache_op(phys_addr_t paddr, size_t size,
--
~Randy
next prev parent reply other threads:[~2022-02-13 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 14:28 [PATCH 1/1] csky: Fixup compile warning wonder_rock
2022-02-13 16:00 ` Randy Dunlap [this message]
2022-02-14 12:02 ` [PATCH 1/1] csky: Fix versioncheck warnings wonder_rock
2022-02-14 16:17 ` Randy Dunlap
2022-02-15 4:24 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98208fa3-4b28-cdeb-7699-dbd9d66bfa60@infradead.org \
--to=rdunlap@infradead.org \
--cc=axboe@kernel.dk \
--cc=guoren@kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wonder_rock@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).