linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] csky: Fixup compile warning
@ 2022-02-13 14:28 wonder_rock
  2022-02-13 16:00 ` Randy Dunlap
  0 siblings, 1 reply; 5+ messages in thread
From: wonder_rock @ 2022-02-13 14:28 UTC (permalink / raw)
  To: guoren; +Cc: axboe, linux-csky, linux-kernel, wonder_rock

From: Deyan Wang <wonder_rock@126.com>

arch/csky/include/asm/io.h: 8 linux/version.h not needed.
arch/csky/kernel/process.c: 5 linux/version.h not needed.
arch/csky/mm/dma-mapping.c: 12 linux/version.h not needed.

Signed-off-by: Deyan Wang <wonder_rock@126.com>
---
 arch/csky/include/asm/io.h | 1 -
 arch/csky/kernel/process.c | 1 -
 arch/csky/mm/dma-mapping.c | 1 -
 3 files changed, 3 deletions(-)

diff --git a/arch/csky/include/asm/io.h b/arch/csky/include/asm/io.h
index f82654053dc0..ed53f0b47388 100644
--- a/arch/csky/include/asm/io.h
+++ b/arch/csky/include/asm/io.h
@@ -5,7 +5,6 @@
 
 #include <linux/pgtable.h>
 #include <linux/types.h>
-#include <linux/version.h>
 
 /*
  * I/O memory access primitives. Reads are ordered relative to any
diff --git a/arch/csky/kernel/process.c b/arch/csky/kernel/process.c
index 3d0ca22cd0e2..5de04707aa07 100644
--- a/arch/csky/kernel/process.c
+++ b/arch/csky/kernel/process.c
@@ -2,7 +2,6 @@
 // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd.
 
 #include <linux/module.h>
-#include <linux/version.h>
 #include <linux/sched.h>
 #include <linux/sched/task_stack.h>
 #include <linux/sched/debug.h>
diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c
index c3a775a7e8f9..82447029feb4 100644
--- a/arch/csky/mm/dma-mapping.c
+++ b/arch/csky/mm/dma-mapping.c
@@ -9,7 +9,6 @@
 #include <linux/mm.h>
 #include <linux/scatterlist.h>
 #include <linux/types.h>
-#include <linux/version.h>
 #include <asm/cache.h>
 
 static inline void cache_op(phys_addr_t paddr, size_t size,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] csky: Fixup compile warning
  2022-02-13 14:28 [PATCH 1/1] csky: Fixup compile warning wonder_rock
@ 2022-02-13 16:00 ` Randy Dunlap
  2022-02-14 12:02   ` [PATCH 1/1] csky: Fix versioncheck warnings wonder_rock
  0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2022-02-13 16:00 UTC (permalink / raw)
  To: wonder_rock, guoren; +Cc: axboe, linux-csky, linux-kernel

Hi,


On 2/13/22 06:28, wonder_rock@126.com wrote:
> From: Deyan Wang <wonder_rock@126.com>
> 
> arch/csky/include/asm/io.h: 8 linux/version.h not needed.
> arch/csky/kernel/process.c: 5 linux/version.h not needed.
> arch/csky/mm/dma-mapping.c: 12 linux/version.h not needed.
> 
> Signed-off-by: Deyan Wang <wonder_rock@126.com>

The patch makes sense but these are not compile warnings.
They come from scripts/checkversion.pl, which can be called
by 'make versioncheck', so I suppose that something in your
build system is running 'make versioncheck'.

You could just say "csky: fix versioncheck warnings"


> ---
>  arch/csky/include/asm/io.h | 1 -
>  arch/csky/kernel/process.c | 1 -
>  arch/csky/mm/dma-mapping.c | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/arch/csky/include/asm/io.h b/arch/csky/include/asm/io.h
> index f82654053dc0..ed53f0b47388 100644
> --- a/arch/csky/include/asm/io.h
> +++ b/arch/csky/include/asm/io.h
> @@ -5,7 +5,6 @@
>  
>  #include <linux/pgtable.h>
>  #include <linux/types.h>
> -#include <linux/version.h>
>  
>  /*
>   * I/O memory access primitives. Reads are ordered relative to any
> diff --git a/arch/csky/kernel/process.c b/arch/csky/kernel/process.c
> index 3d0ca22cd0e2..5de04707aa07 100644
> --- a/arch/csky/kernel/process.c
> +++ b/arch/csky/kernel/process.c
> @@ -2,7 +2,6 @@
>  // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd.
>  
>  #include <linux/module.h>
> -#include <linux/version.h>
>  #include <linux/sched.h>
>  #include <linux/sched/task_stack.h>
>  #include <linux/sched/debug.h>
> diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c
> index c3a775a7e8f9..82447029feb4 100644
> --- a/arch/csky/mm/dma-mapping.c
> +++ b/arch/csky/mm/dma-mapping.c
> @@ -9,7 +9,6 @@
>  #include <linux/mm.h>
>  #include <linux/scatterlist.h>
>  #include <linux/types.h>
> -#include <linux/version.h>
>  #include <asm/cache.h>
>  
>  static inline void cache_op(phys_addr_t paddr, size_t size,

-- 
~Randy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/1] csky: Fix versioncheck warnings
  2022-02-13 16:00 ` Randy Dunlap
@ 2022-02-14 12:02   ` wonder_rock
  2022-02-14 16:17     ` Randy Dunlap
  2022-02-15  4:24     ` Guo Ren
  0 siblings, 2 replies; 5+ messages in thread
From: wonder_rock @ 2022-02-14 12:02 UTC (permalink / raw)
  To: rdunlap; +Cc: axboe, guoren, linux-csky, linux-kernel, wonder_rock

From: Deyan Wang <wonder_rock@126.com>

arch/csky/include/asm/io.h: 8 linux/version.h not needed.
arch/csky/kernel/process.c: 5 linux/version.h not needed.
arch/csky/mm/dma-mapping.c: 12 linux/version.h not needed.

Signed-off-by: Deyan Wang <wonder_rock@126.com>
---
 arch/csky/include/asm/io.h | 1 -
 arch/csky/kernel/process.c | 1 -
 arch/csky/mm/dma-mapping.c | 1 -
 3 files changed, 3 deletions(-)

diff --git a/arch/csky/include/asm/io.h b/arch/csky/include/asm/io.h
index f82654053dc0..ed53f0b47388 100644
--- a/arch/csky/include/asm/io.h
+++ b/arch/csky/include/asm/io.h
@@ -5,7 +5,6 @@
 
 #include <linux/pgtable.h>
 #include <linux/types.h>
-#include <linux/version.h>
 
 /*
  * I/O memory access primitives. Reads are ordered relative to any
diff --git a/arch/csky/kernel/process.c b/arch/csky/kernel/process.c
index 3d0ca22cd0e2..5de04707aa07 100644
--- a/arch/csky/kernel/process.c
+++ b/arch/csky/kernel/process.c
@@ -2,7 +2,6 @@
 // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd.
 
 #include <linux/module.h>
-#include <linux/version.h>
 #include <linux/sched.h>
 #include <linux/sched/task_stack.h>
 #include <linux/sched/debug.h>
diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c
index c3a775a7e8f9..82447029feb4 100644
--- a/arch/csky/mm/dma-mapping.c
+++ b/arch/csky/mm/dma-mapping.c
@@ -9,7 +9,6 @@
 #include <linux/mm.h>
 #include <linux/scatterlist.h>
 #include <linux/types.h>
-#include <linux/version.h>
 #include <asm/cache.h>
 
 static inline void cache_op(phys_addr_t paddr, size_t size,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] csky: Fix versioncheck warnings
  2022-02-14 12:02   ` [PATCH 1/1] csky: Fix versioncheck warnings wonder_rock
@ 2022-02-14 16:17     ` Randy Dunlap
  2022-02-15  4:24     ` Guo Ren
  1 sibling, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2022-02-14 16:17 UTC (permalink / raw)
  To: wonder_rock; +Cc: axboe, guoren, linux-csky, linux-kernel



On 2/14/22 04:02, wonder_rock@126.com wrote:
> From: Deyan Wang <wonder_rock@126.com>
> 
> arch/csky/include/asm/io.h: 8 linux/version.h not needed.
> arch/csky/kernel/process.c: 5 linux/version.h not needed.
> arch/csky/mm/dma-mapping.c: 12 linux/version.h not needed.
> 
> Signed-off-by: Deyan Wang <wonder_rock@126.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  arch/csky/include/asm/io.h | 1 -
>  arch/csky/kernel/process.c | 1 -
>  arch/csky/mm/dma-mapping.c | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/arch/csky/include/asm/io.h b/arch/csky/include/asm/io.h
> index f82654053dc0..ed53f0b47388 100644
> --- a/arch/csky/include/asm/io.h
> +++ b/arch/csky/include/asm/io.h
> @@ -5,7 +5,6 @@
>  
>  #include <linux/pgtable.h>
>  #include <linux/types.h>
> -#include <linux/version.h>
>  
>  /*
>   * I/O memory access primitives. Reads are ordered relative to any
> diff --git a/arch/csky/kernel/process.c b/arch/csky/kernel/process.c
> index 3d0ca22cd0e2..5de04707aa07 100644
> --- a/arch/csky/kernel/process.c
> +++ b/arch/csky/kernel/process.c
> @@ -2,7 +2,6 @@
>  // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd.
>  
>  #include <linux/module.h>
> -#include <linux/version.h>
>  #include <linux/sched.h>
>  #include <linux/sched/task_stack.h>
>  #include <linux/sched/debug.h>
> diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c
> index c3a775a7e8f9..82447029feb4 100644
> --- a/arch/csky/mm/dma-mapping.c
> +++ b/arch/csky/mm/dma-mapping.c
> @@ -9,7 +9,6 @@
>  #include <linux/mm.h>
>  #include <linux/scatterlist.h>
>  #include <linux/types.h>
> -#include <linux/version.h>
>  #include <asm/cache.h>
>  
>  static inline void cache_op(phys_addr_t paddr, size_t size,

-- 
~Randy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] csky: Fix versioncheck warnings
  2022-02-14 12:02   ` [PATCH 1/1] csky: Fix versioncheck warnings wonder_rock
  2022-02-14 16:17     ` Randy Dunlap
@ 2022-02-15  4:24     ` Guo Ren
  1 sibling, 0 replies; 5+ messages in thread
From: Guo Ren @ 2022-02-15  4:24 UTC (permalink / raw)
  To: wonder_rock
  Cc: Randy Dunlap, Jens Axboe, linux-csky, Linux Kernel Mailing List

On Mon, Feb 14, 2022 at 8:35 PM <wonder_rock@126.com> wrote:
>
> From: Deyan Wang <wonder_rock@126.com>
>
> arch/csky/include/asm/io.h: 8 linux/version.h not needed.
> arch/csky/kernel/process.c: 5 linux/version.h not needed.
> arch/csky/mm/dma-mapping.c: 12 linux/version.h not needed.
Could you put the command in the comment log? thx

>
> Signed-off-by: Deyan Wang <wonder_rock@126.com>
> ---
>  arch/csky/include/asm/io.h | 1 -
>  arch/csky/kernel/process.c | 1 -
>  arch/csky/mm/dma-mapping.c | 1 -
>  3 files changed, 3 deletions(-)
>
> diff --git a/arch/csky/include/asm/io.h b/arch/csky/include/asm/io.h
> index f82654053dc0..ed53f0b47388 100644
> --- a/arch/csky/include/asm/io.h
> +++ b/arch/csky/include/asm/io.h
> @@ -5,7 +5,6 @@
>
>  #include <linux/pgtable.h>
>  #include <linux/types.h>
> -#include <linux/version.h>
>
>  /*
>   * I/O memory access primitives. Reads are ordered relative to any
> diff --git a/arch/csky/kernel/process.c b/arch/csky/kernel/process.c
> index 3d0ca22cd0e2..5de04707aa07 100644
> --- a/arch/csky/kernel/process.c
> +++ b/arch/csky/kernel/process.c
> @@ -2,7 +2,6 @@
>  // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd.
>
>  #include <linux/module.h>
> -#include <linux/version.h>
>  #include <linux/sched.h>
>  #include <linux/sched/task_stack.h>
>  #include <linux/sched/debug.h>
> diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c
> index c3a775a7e8f9..82447029feb4 100644
> --- a/arch/csky/mm/dma-mapping.c
> +++ b/arch/csky/mm/dma-mapping.c
> @@ -9,7 +9,6 @@
>  #include <linux/mm.h>
>  #include <linux/scatterlist.h>
>  #include <linux/types.h>
> -#include <linux/version.h>
>  #include <asm/cache.h>
>
>  static inline void cache_op(phys_addr_t paddr, size_t size,
> --
> 2.25.1
>


--
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-02-15  4:24 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-13 14:28 [PATCH 1/1] csky: Fixup compile warning wonder_rock
2022-02-13 16:00 ` Randy Dunlap
2022-02-14 12:02   ` [PATCH 1/1] csky: Fix versioncheck warnings wonder_rock
2022-02-14 16:17     ` Randy Dunlap
2022-02-15  4:24     ` Guo Ren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).