* [PATCH] net: smc: fix a NULL pointer dereference
@ 2019-03-15 4:15 Kangjie Lu
2019-03-15 10:18 ` Ursula Braun
0 siblings, 1 reply; 2+ messages in thread
From: Kangjie Lu @ 2019-03-15 4:15 UTC (permalink / raw)
To: kjlu
Cc: pakki001, Ursula Braun, Karsten Graul, David S. Miller,
linux-s390, netdev, linux-kernel
In case alloc_ordered_workqueue fails, the fix returns NULL
to avoid NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
net/smc/smc_ism.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/smc/smc_ism.c b/net/smc/smc_ism.c
index 2fff79db1a59..e89e918b88e0 100644
--- a/net/smc/smc_ism.c
+++ b/net/smc/smc_ism.c
@@ -289,6 +289,11 @@ struct smcd_dev *smcd_alloc_dev(struct device *parent, const char *name,
INIT_LIST_HEAD(&smcd->vlan);
smcd->event_wq = alloc_ordered_workqueue("ism_evt_wq-%s)",
WQ_MEM_RECLAIM, name);
+ if (!smcd->event_wq) {
+ kfree(smcd->conn);
+ kfree(smcd);
+ return NULL;
+ }
return smcd;
}
EXPORT_SYMBOL_GPL(smcd_alloc_dev);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: smc: fix a NULL pointer dereference
2019-03-15 4:15 [PATCH] net: smc: fix a NULL pointer dereference Kangjie Lu
@ 2019-03-15 10:18 ` Ursula Braun
0 siblings, 0 replies; 2+ messages in thread
From: Ursula Braun @ 2019-03-15 10:18 UTC (permalink / raw)
To: Kangjie Lu
Cc: pakki001, Karsten Graul, David S. Miller, linux-s390, netdev,
linux-kernel
On 3/15/19 5:15 AM, Kangjie Lu wrote:
> In case alloc_ordered_workqueue fails, the fix returns NULL
> to avoid NULL pointer dereference.
>
Thanks, looks good. Your patch will be part of our next patch
submission for the net-tree.
Regards, Ursula
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> net/smc/smc_ism.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/net/smc/smc_ism.c b/net/smc/smc_ism.c
> index 2fff79db1a59..e89e918b88e0 100644
> --- a/net/smc/smc_ism.c
> +++ b/net/smc/smc_ism.c
> @@ -289,6 +289,11 @@ struct smcd_dev *smcd_alloc_dev(struct device *parent, const char *name,
> INIT_LIST_HEAD(&smcd->vlan);
> smcd->event_wq = alloc_ordered_workqueue("ism_evt_wq-%s)",
> WQ_MEM_RECLAIM, name);
> + if (!smcd->event_wq) {
> + kfree(smcd->conn);
> + kfree(smcd);
> + return NULL;
> + }
> return smcd;
> }
> EXPORT_SYMBOL_GPL(smcd_alloc_dev);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-15 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-15 4:15 [PATCH] net: smc: fix a NULL pointer dereference Kangjie Lu
2019-03-15 10:18 ` Ursula Braun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).