* [PATCH] riscv: sifive: fix Kconfig errata warning
@ 2021-05-22 21:20 Randy Dunlap
2021-06-06 23:46 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2021-05-22 21:20 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Paul Walmsley, Palmer Dabbelt, Albert Ou,
linux-riscv, Vincent Chen
The SOC_SIFIVE Kconfig entry unconditionally selects ERRATA_SIFIVE.
However, ERRATA_SIFIVE depends on RISCV_ERRATA_ALTERNATIVE, which is
not set, so SOC_SIFIVE should either depend on or select
RISCV_ERRATA_ALTERNATIVE. Use 'select' here to quieten the Kconfig
warning.
WARNING: unmet direct dependencies detected for ERRATA_SIFIVE
Depends on [n]: RISCV_ERRATA_ALTERNATIVE [=n]
Selected by [y]:
- SOC_SIFIVE [=y]
Fixes: 1a0e5dbd3723 ("riscv: sifive: Add SiFive alternative ports")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-riscv@lists.infradead.org
Cc: Vincent Chen <vincent.chen@sifive.com>
---
arch/riscv/Kconfig.socs | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20210521.orig/arch/riscv/Kconfig.socs
+++ linux-next-20210521/arch/riscv/Kconfig.socs
@@ -14,6 +14,7 @@ config SOC_SIFIVE
select CLK_SIFIVE
select CLK_SIFIVE_PRCI
select SIFIVE_PLIC
+ select RISCV_ERRATA_ALTERNATIVE
select ERRATA_SIFIVE
help
This enables support for SiFive SoC platform hardware.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] riscv: sifive: fix Kconfig errata warning
2021-05-22 21:20 [PATCH] riscv: sifive: fix Kconfig errata warning Randy Dunlap
@ 2021-06-06 23:46 ` Randy Dunlap
2021-06-13 0:23 ` Palmer Dabbelt
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2021-06-06 23:46 UTC (permalink / raw)
To: linux-kernel
Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-riscv, Vincent Chen
ping. anyone?
thanks.
On 5/22/21 2:20 PM, Randy Dunlap wrote:
> The SOC_SIFIVE Kconfig entry unconditionally selects ERRATA_SIFIVE.
> However, ERRATA_SIFIVE depends on RISCV_ERRATA_ALTERNATIVE, which is
> not set, so SOC_SIFIVE should either depend on or select
> RISCV_ERRATA_ALTERNATIVE. Use 'select' here to quieten the Kconfig
> warning.
>
> WARNING: unmet direct dependencies detected for ERRATA_SIFIVE
> Depends on [n]: RISCV_ERRATA_ALTERNATIVE [=n]
> Selected by [y]:
> - SOC_SIFIVE [=y]
>
> Fixes: 1a0e5dbd3723 ("riscv: sifive: Add SiFive alternative ports")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: linux-riscv@lists.infradead.org
> Cc: Vincent Chen <vincent.chen@sifive.com>
> ---
> arch/riscv/Kconfig.socs | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210521.orig/arch/riscv/Kconfig.socs
> +++ linux-next-20210521/arch/riscv/Kconfig.socs
> @@ -14,6 +14,7 @@ config SOC_SIFIVE
> select CLK_SIFIVE
> select CLK_SIFIVE_PRCI
> select SIFIVE_PLIC
> + select RISCV_ERRATA_ALTERNATIVE
> select ERRATA_SIFIVE
> help
> This enables support for SiFive SoC platform hardware.
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] riscv: sifive: fix Kconfig errata warning
2021-06-06 23:46 ` Randy Dunlap
@ 2021-06-13 0:23 ` Palmer Dabbelt
0 siblings, 0 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2021-06-13 0:23 UTC (permalink / raw)
To: rdunlap; +Cc: linux-kernel, Paul Walmsley, aou, linux-riscv, vincent.chen
On Sun, 06 Jun 2021 16:46:15 PDT (-0700), rdunlap@infradead.org wrote:
> ping. anyone?
> thanks.
Sorry, I missed the original patch. This is on fixes.
>
> On 5/22/21 2:20 PM, Randy Dunlap wrote:
>> The SOC_SIFIVE Kconfig entry unconditionally selects ERRATA_SIFIVE.
>> However, ERRATA_SIFIVE depends on RISCV_ERRATA_ALTERNATIVE, which is
>> not set, so SOC_SIFIVE should either depend on or select
>> RISCV_ERRATA_ALTERNATIVE. Use 'select' here to quieten the Kconfig
>> warning.
>>
>> WARNING: unmet direct dependencies detected for ERRATA_SIFIVE
>> Depends on [n]: RISCV_ERRATA_ALTERNATIVE [=n]
>> Selected by [y]:
>> - SOC_SIFIVE [=y]
>>
>> Fixes: 1a0e5dbd3723 ("riscv: sifive: Add SiFive alternative ports")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Paul Walmsley <paul.walmsley@sifive.com>
>> Cc: Palmer Dabbelt <palmer@dabbelt.com>
>> Cc: Albert Ou <aou@eecs.berkeley.edu>
>> Cc: linux-riscv@lists.infradead.org
>> Cc: Vincent Chen <vincent.chen@sifive.com>
>> ---
>> arch/riscv/Kconfig.socs | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20210521.orig/arch/riscv/Kconfig.socs
>> +++ linux-next-20210521/arch/riscv/Kconfig.socs
>> @@ -14,6 +14,7 @@ config SOC_SIFIVE
>> select CLK_SIFIVE
>> select CLK_SIFIVE_PRCI
>> select SIFIVE_PLIC
>> + select RISCV_ERRATA_ALTERNATIVE
>> select ERRATA_SIFIVE
>> help
>> This enables support for SiFive SoC platform hardware.
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-13 0:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-22 21:20 [PATCH] riscv: sifive: fix Kconfig errata warning Randy Dunlap
2021-06-06 23:46 ` Randy Dunlap
2021-06-13 0:23 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).