From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
ada@thorsis.com,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Dan Murphy <dmurphy@ti.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
Joe Perches <joe@perches.com>,
kw@linux.com, Linus Walleij <linus.walleij@linaro.org>,
nishkadg.linux@gmail.com, nstoughton@logitech.com,
oleg@kaa.org.ua, Suzuki K Poulose <suzuki.poulose@arm.com>,
Tony Lindgren <tony@atomide.com>,
wenwen@cs.uga.edu,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [GIT PULL] LED updates for 5.4-rc1
Date: Wed, 18 Sep 2019 21:00:33 +0200 [thread overview]
Message-ID: <9924d94a-d3f2-b47e-4676-70b3f1771703@gmail.com> (raw)
In-Reply-To: <CAHp75VeRiNLhmWaSHnw=DhrgyFrshO5hzpnhAwsM+ZiMyaCSTw@mail.gmail.com>
On 9/18/19 9:23 AM, Andy Shevchenko wrote:
> On Wed, Sep 18, 2019 at 10:16 AM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> On Tue, Sep 17, 2019 at 6:13 PM Linus Torvalds
>> <torvalds@linux-foundation.org> wrote:
>>>
>>> So this is fine and I've pulled it,
>>
>> Famous last words. I now get a new warning:
>>
>> drivers/i2c/i2c-core-acpi.c:347:12: warning:
>> ‘i2c_acpi_find_match_adapter’ defined but not used [-Wunused-function]
>> 347 | static int i2c_acpi_find_match_adapter(struct device *dev,
>> const void *data)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> with this pull request. I'll have to look at it after dinner.
>>
>> Linus
>
> One of those *device core* patch broke i2c ACPI, which has been fixed by
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/i2c/i2c-core-acpi.c?id=644bf60088955421051e716ab9c8fe7fb7997fd7
>
> As I read above the merge commit didn't take this patch.
It's my bad that I didn't notice the warning, but after the problem
was caught and fixed it would have been good to notify all parties that
may have pulled broken commit.
> Solution might be to merge this PR after corresponding bundle of
> device core stuff.
>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-09-18 19:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 22:21 [GIT PULL] LED updates for 5.4-rc1 Jacek Anaszewski
2019-09-18 1:13 ` Linus Torvalds
2019-09-18 1:14 ` Linus Torvalds
2019-09-18 1:40 ` Linus Torvalds
2019-09-18 7:29 ` Andy Shevchenko
2019-09-18 16:53 ` Linus Torvalds
2019-09-18 17:09 ` Linus Torvalds
2019-09-18 18:51 ` Greg Kroah-Hartman
2019-09-18 7:23 ` Andy Shevchenko
2019-09-18 19:00 ` Jacek Anaszewski [this message]
2019-09-18 6:22 ` Greg Kroah-Hartman
2019-09-18 2:15 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9924d94a-d3f2-b47e-4676-70b3f1771703@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=ada@thorsis.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmurphy@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=info@metux.net \
--cc=joe@perches.com \
--cc=kw@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=nstoughton@logitech.com \
--cc=oleg@kaa.org.ua \
--cc=suzuki.poulose@arm.com \
--cc=tony@atomide.com \
--cc=torvalds@linux-foundation.org \
--cc=wenwen@cs.uga.edu \
--cc=wsa+renesas@sang-engineering.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).