linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	linux-leds@vger.kernel.org, ada@thorsis.com,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	christophe.jaillet@wanadoo.fr, dmurphy@ti.com,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	info@metux.net, Joe Perches <joe@perches.com>,
	kw@linux.com, Linus Walleij <linus.walleij@linaro.org>,
	nishkadg.linux@gmail.com, nstoughton@logitech.com,
	oleg@kaa.org.ua, Suzuki K Poulose <suzuki.poulose@arm.com>,
	Tony Lindgren <tony@atomide.com>,
	wenwen@cs.uga.edu, wsa+renesas@sang-engineering.com,
	Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [GIT PULL] LED updates for 5.4-rc1
Date: Tue, 17 Sep 2019 18:13:09 -0700	[thread overview]
Message-ID: <CAHk-=wgxNj_RBpE0xRYnMQ9W6PtyLx+LS+pZ_BqG31vute1iAg@mail.gmail.com> (raw)
In-Reply-To: <20190916222133.9119-1-jacek.anaszewski@gmail.com>

On Mon, Sep 16, 2019 at 3:21 PM Jacek Anaszewski
<jacek.anaszewski@gmail.com> wrote:
>
> There is one merge of tag with generic_lookup_helpers since
> LED class has been made using class_find_device_by_name() helper:
>
>     Merge tag 'generic_lookup_helpers' into for-next
>     platform: Add platform_find_device_by_driver() helper
>     drivers: Add generic helper to match any device
>     drivers: Introduce device lookup variants by ACPI_COMPANION device
>     drivers: Introduce device lookup variants by device type
>     drivers: Introduce device lookup variants by fwnode
>     drivers: Introduce device lookup variants by of_node
>     drivers: Introduce device lookup variants by name

So this is fine and I've pulled it, but I have to say that I
absolutely detest how this device.h header keeps just growing
endlessly:

  [torvalds@linux]$ wc include/linux/device.h
   1921  8252 66021 include/linux/device.h

that's almost 2k of header file, and it's included a _lot_:

  [torvalds@linux]$ git grep include.*linux/device.h | wc
   2518    5085  144875

and many of those includes are actually from other core header files,
so it's effectively included from even more trees.

Yes, yes, many of those 2k lines are comments. But still... Do we
really want to have that humongous 65kB, 2kloc header file, and keep
growing it forever?

Greg?

                  Linus

  reply	other threads:[~2019-09-18  1:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16 22:21 [GIT PULL] LED updates for 5.4-rc1 Jacek Anaszewski
2019-09-18  1:13 ` Linus Torvalds [this message]
2019-09-18  1:14   ` Linus Torvalds
2019-09-18  1:40     ` Linus Torvalds
2019-09-18  7:29       ` Andy Shevchenko
2019-09-18 16:53         ` Linus Torvalds
2019-09-18 17:09           ` Linus Torvalds
2019-09-18 18:51             ` Greg Kroah-Hartman
2019-09-18  7:23     ` Andy Shevchenko
2019-09-18 19:00       ` Jacek Anaszewski
2019-09-18  6:22   ` Greg Kroah-Hartman
2019-09-18  2:15 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wgxNj_RBpE0xRYnMQ9W6PtyLx+LS+pZ_BqG31vute1iAg@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=ada@thorsis.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dmurphy@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gustavo@embeddedor.com \
    --cc=info@metux.net \
    --cc=jacek.anaszewski@gmail.com \
    --cc=joe@perches.com \
    --cc=kw@linux.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=nishkadg.linux@gmail.com \
    --cc=nstoughton@logitech.com \
    --cc=oleg@kaa.org.ua \
    --cc=suzuki.poulose@arm.com \
    --cc=tony@atomide.com \
    --cc=wenwen@cs.uga.edu \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).