From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yanhong Wang <yanhong.wang@starfivetech.com>,
linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v2 5/9] dt-bindings: net: motorcomm: add support for Motorcomm YT8531
Date: Fri, 16 Dec 2022 12:15:31 +0100 [thread overview]
Message-ID: <994718d8-f3ee-af5e-bda7-f913f66597ce@linaro.org> (raw)
In-Reply-To: <20221216070632.11444-6-yanhong.wang@starfivetech.com>
On 16/12/2022 08:06, Yanhong Wang wrote:
> Add support for Motorcomm Technology YT8531 10/100/1000 Ethernet PHY.
> The document describe details of clock delay train configuration.
>
> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
Missing vendor prefix documentation. I don't think you tested this at
all with checkpatch and dt_binding_check.
> ---
> .../bindings/net/motorcomm,yt8531.yaml | 111 ++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 112 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/motorcomm,yt8531.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8531.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8531.yaml
> new file mode 100644
> index 000000000000..c5b8a09a78bb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8531.yaml
> @@ -0,0 +1,111 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/motorcomm,yt8531.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Motorcomm YT8531 Gigabit Ethernet PHY
> +
> +maintainers:
> + - Yanhong Wang <yanhong.wang@starfivetech.com>
> +
Why there is no reference to ethernet-phy.yaml?
> +select:
> + properties:
> + $nodename:
> + pattern: "^ethernet-phy(@[a-f0-9]+)?$"
I don't think that's correct approach. You know affect all phys.
> +
> + required:
> + - $nodename
> +
> +properties:
> + $nodename:
> + pattern: "^ethernet-phy(@[a-f0-9]+)?$"
Just reference ethernet-phy.yaml.
> +
> + reg:
> + minimum: 0
> + maximum: 31
> + description:
> + The ID number for the PHY.
Drop duplicated properties.
> +
> + rxc_dly_en:
No underscores in node names. Missing vendor prefix. Both apply to all
your other custom properties, unless they are not custom but generic.
Missing ref.
> + description: |
> + RGMII Receive PHY Clock Delay defined with fixed 2ns.This is used for
After every full stop goes space.
> + PHY that have configurable RX internal delays. If this property set
> + to 1, then automatically add 2ns delay pad for Receive PHY clock.
Nope, this is wrong. You wrote now boolean property as enum.
> + enum: [0, 1]
> + default: 0
> +
> + rx_delay_sel:
> + description: |
> + This is supplement to rxc_dly_en property,and it can
> + be specified in 150ps(pico seconds) steps. The effective
> + delay is: 150ps * N.
Nope. Use proper units and drop all this register stuff.
> + minimum: 0
> + maximum: 15
> + default: 0
> +
> + tx_delay_sel_fe:
> + description: |
> + RGMII Transmit PHY Clock Delay defined in pico seconds.This is used for
> + PHY's that have configurable TX internal delays when speed is 100Mbps
> + or 10Mbps. It can be specified in 150ps steps, the effective delay
> + is: 150ps * N.
The binding is in very poor shape. Please look carefully in
example-schema. All my previous comments apply everywhere.
> + minimum: 0
> + maximum: 15
> + default: 15
> +
> + tx_delay_sel:
> + description: |
> + RGMII Transmit PHY Clock Delay defined in pico seconds.This is used for
> + PHY's that have configurable TX internal delays when speed is 1000Mbps.
> + It can be specified in 150ps steps, the effective delay is: 150ps * N.
> + minimum: 0
> + maximum: 15
> + default: 1
> +
> + tx_inverted_10:
> + description: |
> + Use original or inverted RGMII Transmit PHY Clock to drive the RGMII
> + Transmit PHY Clock delay train configuration when speed is 10Mbps.
> + 0: original 1: inverted
> + enum: [0, 1]
> + default: 0
> +
> + tx_inverted_100:
> + description: |
> + Use original or inverted RGMII Transmit PHY Clock to drive the RGMII
> + Transmit PHY Clock delay train configuration when speed is 100Mbps.
> + 0: original 1: inverted
> + enum: [0, 1]
> + default: 0
> +
> + tx_inverted_1000:
> + description: |
> + Use original or inverted RGMII Transmit PHY Clock to drive the RGMII
> + Transmit PHY Clock delay train configuration when speed is 1000Mbps.
> + 0: original 1: inverted
> + enum: [0, 1]
> + default: 0
> +
> +required:
> + - reg
> +
> +additionalProperties: true
This must be false. After referencing ethernet-phy this should be
unevaluatedProperties: false.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-16 11:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 7:06 [PATCH v2 0/9] Add Ethernet driver for StarFive JH7110 SoC Yanhong Wang
2022-12-16 7:06 ` [PATCH v2 1/9] dt-bindings: net: snps,dwmac: Add dwmac-5.20 version Yanhong Wang
2022-12-16 7:06 ` [PATCH v2 2/9] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names Yanhong Wang
2022-12-16 11:03 ` Krzysztof Kozlowski
2022-12-20 6:48 ` yanhong wang
2022-12-20 9:21 ` Krzysztof Kozlowski
2022-12-27 7:48 ` yanhong wang
2022-12-27 8:18 ` Krzysztof Kozlowski
2022-12-16 7:06 ` [PATCH v2 3/9] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Yanhong Wang
2022-12-16 7:06 ` [PATCH v2 4/9] dt-bindings: net: Add bindings for StarFive dwmac Yanhong Wang
2022-12-16 11:05 ` Krzysztof Kozlowski
2022-12-20 6:53 ` yanhong wang
2022-12-16 11:06 ` Krzysztof Kozlowski
2022-12-20 6:57 ` yanhong wang
2022-12-20 18:03 ` Rob Herring
2022-12-16 7:06 ` [PATCH v2 5/9] dt-bindings: net: motorcomm: add support for Motorcomm YT8531 Yanhong Wang
2022-12-16 11:15 ` Krzysztof Kozlowski [this message]
2022-12-27 9:38 ` yanhong wang
2022-12-27 9:52 ` Krzysztof Kozlowski
2022-12-28 3:23 ` yanhong wang
2022-12-28 9:11 ` Krzysztof Kozlowski
2022-12-28 9:24 ` yanhong wang
2022-12-16 7:06 ` [PATCH v2 6/9] net: phy: motorcomm: Add YT8531 phy support Yanhong Wang
2022-12-16 8:41 ` Arun.Ramadoss
2022-12-16 11:58 ` Heiner Kallweit
2022-12-21 1:16 ` yanhong wang
2022-12-20 14:20 ` Andrew Lunn
2022-12-16 7:06 ` [PATCH v2 7/9] net: stmmac: Add glue layer for StarFive JH71x0 SoCs Yanhong Wang
2022-12-16 11:19 ` Krzysztof Kozlowski
2022-12-16 7:06 ` [PATCH v2 8/9] riscv: dts: starfive: jh7110: Add ethernet device node Yanhong Wang
2022-12-16 7:06 ` [PATCH v2 9/9] riscv: dts: starfive: visionfive-v2: Add phy clock delay train configuration Yanhong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=994718d8-f3ee-af5e-bda7-f913f66597ce@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).