* [PATCH -next] misc: ibmvmc: Use GFP_ATOMIC under spin lock
@ 2018-05-26 9:45 Wei Yongjun
2018-05-29 14:15 ` Bryant G. Ly
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-05-26 9:45 UTC (permalink / raw)
To: Bryant G. Ly, Steven Royer, Arnd Bergmann, Greg Kroah-Hartman
Cc: Wei Yongjun, linux-kernel, kernel-janitors
The function alloc_dma_buffer() is called from ibmvmc_add_buffer(),
in which a spin lock be held here, so we should use GFP_ATOMIC when
a lock is held.
Fixes: 0eca353e7ae7 ("misc: IBM Virtual Management Channel Driver (VMC)")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/misc/ibmvmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/ibmvmc.c b/drivers/misc/ibmvmc.c
index fb83d13..8f82bb9 100644
--- a/drivers/misc/ibmvmc.c
+++ b/drivers/misc/ibmvmc.c
@@ -273,7 +273,7 @@ static void *alloc_dma_buffer(struct vio_dev *vdev, size_t size,
dma_addr_t *dma_handle)
{
/* allocate memory */
- void *buffer = kzalloc(size, GFP_KERNEL);
+ void *buffer = kzalloc(size, GFP_ATOMIC);
if (!buffer) {
*dma_handle = 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] misc: ibmvmc: Use GFP_ATOMIC under spin lock
2018-05-26 9:45 [PATCH -next] misc: ibmvmc: Use GFP_ATOMIC under spin lock Wei Yongjun
@ 2018-05-29 14:15 ` Bryant G. Ly
0 siblings, 0 replies; 2+ messages in thread
From: Bryant G. Ly @ 2018-05-29 14:15 UTC (permalink / raw)
To: Wei Yongjun, Bryant G. Ly, Steven Royer, Arnd Bergmann,
Greg Kroah-Hartman
Cc: linux-kernel, kernel-janitors
On 5/26/18 4:45 AM, Wei Yongjun wrote:
> The function alloc_dma_buffer() is called from ibmvmc_add_buffer(),
> in which a spin lock be held here, so we should use GFP_ATOMIC when
> a lock is held.
>
> Fixes: 0eca353e7ae7 ("misc: IBM Virtual Management Channel Driver (VMC)")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/misc/ibmvmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/ibmvmc.c b/drivers/misc/ibmvmc.c
> index fb83d13..8f82bb9 100644
> --- a/drivers/misc/ibmvmc.c
> +++ b/drivers/misc/ibmvmc.c
> @@ -273,7 +273,7 @@ static void *alloc_dma_buffer(struct vio_dev *vdev, size_t size,
> dma_addr_t *dma_handle)
> {
> /* allocate memory */
> - void *buffer = kzalloc(size, GFP_KERNEL);
> + void *buffer = kzalloc(size, GFP_ATOMIC);
>
> if (!buffer) {
> *dma_handle = 0;
>
Reviewed-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-29 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-26 9:45 [PATCH -next] misc: ibmvmc: Use GFP_ATOMIC under spin lock Wei Yongjun
2018-05-29 14:15 ` Bryant G. Ly
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).