* [PATCH net] ethernet: adi: Move select PHYLIB from NET_VENDOR_ADI to ADIN1110
@ 2024-02-26 11:34 Geert Uytterhoeven
2024-02-27 0:23 ` Randy Dunlap
2024-02-28 11:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2024-02-26 11:34 UTC (permalink / raw)
To: Randy Dunlap, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: netdev, linux-kernel, Geert Uytterhoeven
The NET_VENDOR_* Kconfig options are used as gatekeepers. Merely
enabling such an option must not enable any other extra code.
Fixes: a9f80df4f5144030 ("net: ethernet: adi: requires PHYLIB support")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/net/ethernet/adi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/adi/Kconfig b/drivers/net/ethernet/adi/Kconfig
index c91b4dcef4ec2f5f..760a9a60bc15c184 100644
--- a/drivers/net/ethernet/adi/Kconfig
+++ b/drivers/net/ethernet/adi/Kconfig
@@ -7,7 +7,6 @@ config NET_VENDOR_ADI
bool "Analog Devices devices"
default y
depends on SPI
- select PHYLIB
help
If you have a network (Ethernet) card belonging to this class, say Y.
@@ -22,6 +21,7 @@ config ADIN1110
tristate "Analog Devices ADIN1110 MAC-PHY"
depends on SPI && NET_SWITCHDEV
select CRC8
+ select PHYLIB
help
Say yes here to build support for Analog Devices ADIN1110
Low Power 10BASE-T1L Ethernet MAC-PHY.
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] ethernet: adi: Move select PHYLIB from NET_VENDOR_ADI to ADIN1110
2024-02-26 11:34 [PATCH net] ethernet: adi: Move select PHYLIB from NET_VENDOR_ADI to ADIN1110 Geert Uytterhoeven
@ 2024-02-27 0:23 ` Randy Dunlap
2024-02-28 11:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2024-02-27 0:23 UTC (permalink / raw)
To: Geert Uytterhoeven, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: netdev, linux-kernel
Hi Geert,
On 2/26/24 03:34, Geert Uytterhoeven wrote:
> The NET_VENDOR_* Kconfig options are used as gatekeepers. Merely
> enabling such an option must not enable any other extra code.
>
> Fixes: a9f80df4f5144030 ("net: ethernet: adi: requires PHYLIB support")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/net/ethernet/adi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/adi/Kconfig b/drivers/net/ethernet/adi/Kconfig
> index c91b4dcef4ec2f5f..760a9a60bc15c184 100644
> --- a/drivers/net/ethernet/adi/Kconfig
> +++ b/drivers/net/ethernet/adi/Kconfig
> @@ -7,7 +7,6 @@ config NET_VENDOR_ADI
> bool "Analog Devices devices"
> default y
> depends on SPI
> - select PHYLIB
> help
> If you have a network (Ethernet) card belonging to this class, say Y.
>
> @@ -22,6 +21,7 @@ config ADIN1110
> tristate "Analog Devices ADIN1110 MAC-PHY"
> depends on SPI && NET_SWITCHDEV
> select CRC8
> + select PHYLIB
> help
> Say yes here to build support for Analog Devices ADIN1110
> Low Power 10BASE-T1L Ethernet MAC-PHY.
I sent the same patch last night (local time):
https://lore.kernel.org/lkml/20240226074820.29250-1-rdunlap@infradead.org/
Hopefully one of them can be merged soon.
--
#Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] ethernet: adi: Move select PHYLIB from NET_VENDOR_ADI to ADIN1110
2024-02-26 11:34 [PATCH net] ethernet: adi: Move select PHYLIB from NET_VENDOR_ADI to ADIN1110 Geert Uytterhoeven
2024-02-27 0:23 ` Randy Dunlap
@ 2024-02-28 11:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-28 11:20 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: rdunlap, davem, edumazet, kuba, pabeni, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Mon, 26 Feb 2024 12:34:02 +0100 you wrote:
> The NET_VENDOR_* Kconfig options are used as gatekeepers. Merely
> enabling such an option must not enable any other extra code.
>
> Fixes: a9f80df4f5144030 ("net: ethernet: adi: requires PHYLIB support")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/net/ethernet/adi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] ethernet: adi: Move select PHYLIB from NET_VENDOR_ADI to ADIN1110
https://git.kernel.org/netdev/net/c/943d4bd67950
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-28 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-26 11:34 [PATCH net] ethernet: adi: Move select PHYLIB from NET_VENDOR_ADI to ADIN1110 Geert Uytterhoeven
2024-02-27 0:23 ` Randy Dunlap
2024-02-28 11:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).