From: Nadav Amit <namit@vmware.com>
To: Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@amacapital.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, X86 ML <x86@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch <linux-arch@vger.kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Jiri Kosina <jkosina@suse.cz>, Andy Lutomirski <luto@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v2 0/6] x86/alternatives: text_poke() fixes
Date: Thu, 6 Sep 2018 18:38:30 +0000 [thread overview]
Message-ID: <9F76711C-393C-4F8D-B460-26D400458690@vmware.com> (raw)
In-Reply-To: <20180906183157.GK24106@hirez.programming.kicks-ass.net>
at 11:31 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Thu, Sep 06, 2018 at 11:09:23AM -0700, Andy Lutomirski wrote:
>>> On Sep 6, 2018, at 10:58 AM, Nadav Amit <namit@vmware.com> wrote:
>>> It depends what security you want. Some may consider even the short
>>> time-window in which the kernel code is writable from other cores as
>>> insufficient for security.
>>>
>>> In addition, the set removes the need for remote TLB shootdowns that
>>> text_poke() - with this fix - requires.
>>
>> I’m personally in favor of not needing a global broadcast flush to install kprobes.
>
> That's fine. But at that point its an optimization, not a correctness
> issue.
Note that patch 1/6 is still needed to fix false lockdep shoutouts due to a
recent patch.
next prev parent reply other threads:[~2018-09-06 18:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-02 17:32 [PATCH v2 0/6] x86/alternatives: text_poke() fixes Nadav Amit
2018-09-02 17:32 ` [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()" Nadav Amit
2018-09-06 19:40 ` Peter Zijlstra
2018-09-06 19:42 ` Nadav Amit
2018-09-06 19:53 ` Peter Zijlstra
2018-09-06 19:58 ` Nadav Amit
2018-09-06 20:25 ` Peter Zijlstra
2018-09-06 20:57 ` Nadav Amit
2018-09-06 21:41 ` Peter Zijlstra
2018-09-02 17:32 ` [PATCH v2 2/6] x86/mm: temporary mm struct Nadav Amit
2018-09-02 17:32 ` [PATCH v2 3/6] fork: provide a function for copying init_mm Nadav Amit
2018-09-02 17:32 ` [PATCH v2 4/6] x86/alternatives: initializing temporary mm for patching Nadav Amit
2018-09-06 9:01 ` Peter Zijlstra
2018-09-07 20:52 ` Nadav Amit
2018-09-02 17:32 ` [PATCH v2 5/6] x86/alternatives: use temporary mm for text poking Nadav Amit
2018-09-02 17:32 ` [PATCH v2 6/6] x86/alternatives: remove text_poke() return value Nadav Amit
2018-09-05 18:56 ` [PATCH v2 0/6] x86/alternatives: text_poke() fixes Peter Zijlstra
2018-09-05 19:02 ` Nadav Amit
2018-09-05 19:10 ` Nadav Amit
2018-09-06 8:13 ` Peter Zijlstra
2018-09-06 8:42 ` Peter Zijlstra
2018-09-06 9:18 ` Peter Zijlstra
2018-09-06 10:16 ` Peter Zijlstra
2018-09-06 17:01 ` Nadav Amit
2018-09-06 17:17 ` Peter Zijlstra
2018-09-06 17:58 ` Nadav Amit
2018-09-06 18:09 ` Andy Lutomirski
2018-09-06 18:31 ` Peter Zijlstra
2018-09-06 18:38 ` Nadav Amit [this message]
2018-09-06 19:19 ` Peter Zijlstra
2018-09-06 17:23 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9F76711C-393C-4F8D-B460-26D400458690@vmware.com \
--to=namit@vmware.com \
--cc=arnd@arndb.de \
--cc=dave.hansen@linux.intel.com \
--cc=jkosina@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).