From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>,
Alexander Aring <alex.aring@gmail.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
linux-wpan@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ca8210: move to gpio descriptors
Date: Sat, 28 Jan 2023 14:30:17 +0100 [thread overview]
Message-ID: <9a09a41b-1eb9-edc9-28ad-acb920e04ae4@datenfreihafen.org> (raw)
In-Reply-To: <57e74219-d439-4d10-9bb5-53fe7b30b46f@app.fastmail.com>
Hello Arnd.
On 26.01.23 17:25, Arnd Bergmann wrote:
> On Thu, Jan 26, 2023, at 17:17, Arnd Bergmann wrote:
>
>> if (ret) {
>> - dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id);
>> - gpiod_unexport(gpio_to_desc(pdata->gpio_irq));
>> - gpio_free(pdata->gpio_irq);
>> + dev_crit(&spi->dev, "request_irq %d failed\n", priv->irq_id);
>> + gpiod_put(priv->gpio_irq);
>> }
>
> I just realized that this bit depends on the "gpiolib: remove
> legacy gpio_export" patch I sent to the gpio mailing list earlier.
>
> We can probably just defer this change until that is merged,
> or alternatively I can rebase this patch to avoid the
> dependency.
Deferring the change until i picked it up from Linus or net-next in my
tree is fine. This driver is not heavily worked on (its actually marked
as orphaned) so the patch should still apply in a few days.
I will keep it in my patchwork queue of patches to be applied. No extra
work needed from your side.
regards
Stefan Schmidt
next prev parent reply other threads:[~2023-01-28 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 16:17 [PATCH] ca8210: move to gpio descriptors Arnd Bergmann
2023-01-26 16:25 ` Arnd Bergmann
2023-01-28 13:30 ` Stefan Schmidt [this message]
2023-05-03 12:01 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a09a41b-1eb9-edc9-28ad-acb920e04ae4@datenfreihafen.org \
--to=stefan@datenfreihafen.org \
--cc=alex.aring@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).