From: Jesper Juhl <jesper.juhl@gmail.com>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: "Ju, Seokmann" <Seokmann.Ju@lsil.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Kolli, Neela" <Neela.Kolli@engenio.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Megaraid cleanup
Date: Wed, 25 Jan 2006 22:22:07 +0100 [thread overview]
Message-ID: <9a8748490601251322nc1f1b7di3c02444f66fbe625@mail.gmail.com> (raw)
In-Reply-To: <1138122353.3662.7.camel@mulgrave>
[-- Attachment #1: Type: text/plain, Size: 1835 bytes --]
On 1/24/06, James Bottomley <James.Bottomley@steeleye.com> wrote:
> On Tue, 2006-01-24 at 16:41 +0100, Jesper Juhl wrote:
> > I assume you'll take care of pushing it forward or should I do that?
>
> I can't actually find this patch on the SCSI list, so resending it would
> be a good start.
>
Hmm, I guess it never made it due to size.
Below is the description I initially wrote for the patch and the patch
itself is attached as a bzip2 archive so it will hopefully make it to
you.
From: Jesper Juhl <jesper.juhl@gmail.com>
Ok, I went into drivers/scsi/megaraid.c just to fix a few compiler warnings,
but ended up doing a big spring-cleaning.
I'm sorry this patch is not split into one patch pr logical change, but I
did everything in one go from the top of the file to the bottom and
splitting the changes after I was done would have been a big task in itself.
Since all the changes are pretty trivial I hope it'll be acceptable as-is,
but if not then let me know and I'll try and split it up.
Here's a summary of the changes made :
- CodingStyle & Whitespace cleanups, incl. removing excessive blank lines.
- Merge some printk's.
- Remove some pointless casts.
- Remove some pointless initializations of variables to 0.
- Merge some variable initializations.
- return is not a function.
- Remove unneeded variables.
- Fix two warnings ;
drivers/scsi/megaraid.c:3660: warning: ignoring return value of
`copy_to_user', declared with attribute warn_unused_result
drivers/scsi/megaraid.c:4473: warning: unused variable `flags'
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
[-- Attachment #2: megaraid-cleanup.patch.bz2 --]
[-- Type: application/x-bzip2, Size: 20967 bytes --]
next prev parent reply other threads:[~2006-01-25 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9738BCBE884FDB42801FAD8A7769C265142031@NAMAIL1.ad.lsil.com>
2006-01-24 15:41 ` [PATCH] Megaraid cleanup Jesper Juhl
2006-01-24 17:05 ` James Bottomley
2006-01-25 21:22 ` Jesper Juhl [this message]
2006-02-09 21:06 ` Jesper Juhl
[not found] <9738BCBE884FDB42801FAD8A7769C265142001@NAMAIL1.ad.lsil.com>
2006-01-10 21:03 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490601251322nc1f1b7di3c02444f66fbe625@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=James.Bottomley@steeleye.com \
--cc=Neela.Kolli@engenio.com \
--cc=Seokmann.Ju@lsil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).