* [PATCH] powerpc/512x: Use dma_request_chan() instead dma_request_slave_channel()
@ 2019-12-17 7:40 Peter Ujfalusi
2019-12-17 7:42 ` Peter Ujfalusi
0 siblings, 1 reply; 4+ messages in thread
From: Peter Ujfalusi @ 2019-12-17 7:40 UTC (permalink / raw)
To: b.zolnierkie, axboe; +Cc: vkoul, linux-ide, linux-kernel
dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.
By using dma_request_chan() directly the driver can support deferred
probing against DMA.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/powerpc/platforms/512x/mpc512x_lpbfifo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
index 13631f35cd14..04bf6ecf7d55 100644
--- a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
+++ b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
@@ -434,9 +434,9 @@ static int mpc512x_lpbfifo_probe(struct platform_device *pdev)
memset(&lpbfifo, 0, sizeof(struct lpbfifo_data));
spin_lock_init(&lpbfifo.lock);
- lpbfifo.chan = dma_request_slave_channel(&pdev->dev, "rx-tx");
- if (lpbfifo.chan == NULL)
- return -EPROBE_DEFER;
+ lpbfifo.chan = dma_request_chan(&pdev->dev, "rx-tx");
+ if (IS_ERR(lpbfifo.chan))
+ return PTR_ERR(lpbfifo.chan);
if (of_address_to_resource(pdev->dev.of_node, 0, &r) != 0) {
dev_err(&pdev->dev, "bad 'reg' in 'sclpc' device tree node\n");
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/512x: Use dma_request_chan() instead dma_request_slave_channel()
2019-12-17 7:40 [PATCH] powerpc/512x: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
@ 2019-12-17 7:42 ` Peter Ujfalusi
0 siblings, 0 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2019-12-17 7:42 UTC (permalink / raw)
To: b.zolnierkie, axboe; +Cc: vkoul, linux-ide, linux-kernel
Hi,
On 17/12/2019 9.40, Peter Ujfalusi wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
>
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.
I sent this patch to wrong participants... Forgot to change directory.
The correct (ata: pxa:) should be on it way.
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/powerpc/platforms/512x/mpc512x_lpbfifo.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
> index 13631f35cd14..04bf6ecf7d55 100644
> --- a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
> +++ b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
> @@ -434,9 +434,9 @@ static int mpc512x_lpbfifo_probe(struct platform_device *pdev)
> memset(&lpbfifo, 0, sizeof(struct lpbfifo_data));
> spin_lock_init(&lpbfifo.lock);
>
> - lpbfifo.chan = dma_request_slave_channel(&pdev->dev, "rx-tx");
> - if (lpbfifo.chan == NULL)
> - return -EPROBE_DEFER;
> + lpbfifo.chan = dma_request_chan(&pdev->dev, "rx-tx");
> + if (IS_ERR(lpbfifo.chan))
> + return PTR_ERR(lpbfifo.chan);
>
> if (of_address_to_resource(pdev->dev.of_node, 0, &r) != 0) {
> dev_err(&pdev->dev, "bad 'reg' in 'sclpc' device tree node\n");
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/512x: Use dma_request_chan() instead dma_request_slave_channel()
2019-12-17 7:37 Peter Ujfalusi
@ 2020-01-06 23:33 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2020-01-06 23:33 UTC (permalink / raw)
To: Peter Ujfalusi, agust; +Cc: vkoul, linuxppc-dev, linux-kernel
On Tue, 2019-12-17 at 07:37:30 UTC, Peter Ujfalusi wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
>
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/fb185a4052b18c97ebc98f6a8db30a60abca35e0
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] powerpc/512x: Use dma_request_chan() instead dma_request_slave_channel()
@ 2019-12-17 7:37 Peter Ujfalusi
2020-01-06 23:33 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: Peter Ujfalusi @ 2019-12-17 7:37 UTC (permalink / raw)
To: agust; +Cc: vkoul, linuxppc-dev, linux-kernel
dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.
By using dma_request_chan() directly the driver can support deferred
probing against DMA.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/powerpc/platforms/512x/mpc512x_lpbfifo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
index 13631f35cd14..04bf6ecf7d55 100644
--- a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
+++ b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
@@ -434,9 +434,9 @@ static int mpc512x_lpbfifo_probe(struct platform_device *pdev)
memset(&lpbfifo, 0, sizeof(struct lpbfifo_data));
spin_lock_init(&lpbfifo.lock);
- lpbfifo.chan = dma_request_slave_channel(&pdev->dev, "rx-tx");
- if (lpbfifo.chan == NULL)
- return -EPROBE_DEFER;
+ lpbfifo.chan = dma_request_chan(&pdev->dev, "rx-tx");
+ if (IS_ERR(lpbfifo.chan))
+ return PTR_ERR(lpbfifo.chan);
if (of_address_to_resource(pdev->dev.of_node, 0, &r) != 0) {
dev_err(&pdev->dev, "bad 'reg' in 'sclpc' device tree node\n");
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-06 23:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 7:40 [PATCH] powerpc/512x: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
2019-12-17 7:42 ` Peter Ujfalusi
-- strict thread matches above, loose matches on Subject: below --
2019-12-17 7:37 Peter Ujfalusi
2020-01-06 23:33 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).